# -*- Mode: perl; indent-tabs-mode: nil -*- # # The contents of this file are subject to the Mozilla Public # License Version 1.1 (the "License"); you may not use this file # except in compliance with the License. You may obtain a copy of # the License at http://www.mozilla.org/MPL/ # # Software distributed under the License is distributed on an "AS # IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or # implied. See the License for the specific language governing # rights and limitations under the License. # # The Original Code is the Bugzilla Bug Tracking System. # # Contributor(s): Marc Schumann # Max Kanat-Alexander # Mads Bondo Dydensborg # Tsahi Asher # Noura Elhawary package Bugzilla::WebService::Bug; use strict; use base qw(Bugzilla::WebService); use Bugzilla::Constants; use Bugzilla::Error; use Bugzilla::Field; use Bugzilla::WebService::Constants; use Bugzilla::WebService::Util qw(filter); use Bugzilla::Bug; use Bugzilla::BugMail; use Bugzilla::Util qw(trim); ############# # Constants # ############# # This maps the names of internal Bugzilla bug fields to things that would # make sense to somebody who's not intimately familiar with the inner workings # of Bugzilla. (These are the field names that the WebService uses.) use constant FIELD_MAP => { status => 'bug_status', severity => 'bug_severity', description => 'comment', summary => 'short_desc', platform => 'rep_platform', }; use constant PRODUCT_SPECIFIC_FIELDS => qw(version target_milestone component); ###################################################### # Add aliases here for old method name compatibility # ###################################################### BEGIN { *get_bugs = \&get } ########### # Methods # ########### sub comments { my ($self, $params) = @_; if (!(defined $params->{bug_ids} || defined $params->{comment_ids})) { ThrowCodeError('params_required', { function => 'Bug.comments', params => ['bug_ids', 'comment_ids'] }); } my $bug_ids = $params->{bug_ids} || []; my $comment_ids = $params->{comment_ids} || []; my $dbh = Bugzilla->dbh; my $user = Bugzilla->user; my %bugs; foreach my $bug_id (@$bug_ids) { my $bug = Bugzilla::Bug->check($bug_id); # We want the API to always return comments in the same order. my $comments = Bugzilla::Bug::GetComments( $bug->id, 'oldest_to_newest', $params->{new_since}); my @result; foreach my $comment (@$comments) { next if $comment->{isprivate} && !$user->is_insider; $comment->{bug_id} = $bug->id; push(@result, $self->_translate_comment($comment, $params)); } $bugs{$bug->id}{'comments'} = \@result; } my %comments; if (scalar @$comment_ids) { my @ids = map { trim($_) } @$comment_ids; my @sql_ids = map { $dbh->quote($_) } @ids; my $comment_data = $dbh->selectall_arrayref( 'SELECT comment_id AS id, bug_id, who, bug_when AS time, isprivate, thetext AS body, type, extra_data FROM longdescs WHERE ' . $dbh->sql_in('comment_id', \@sql_ids), {Slice=>{}}); # See if we were passed any invalid comment ids. my %got_ids = map { $_->{id} => 1 } @$comment_data; foreach my $comment_id (@ids) { if (!$got_ids{$comment_id}) { ThrowUserError('comment_id_invalid', { id => $comment_id }); } } # Now make sure that we can see all the associated bugs. my %got_bug_ids = map { $_->{bug_id} => 1 } @$comment_data; Bugzilla::Bug->check($_) foreach (keys %got_bug_ids); foreach my $comment (@$comment_data) { if ($comment->{isprivate} && !$user->is_insider) { ThrowUserError('comment_is_private', { id => $comment->{id} }); } $comment->{author} = new Bugzilla::User($comment->{who}); $comment->{body} = Bugzilla::Bug::format_comment($comment); $comments{$comment->{id}} = $self->_translate_comment($comment, $params); } } return { bugs => \%bugs, comments => \%comments }; } # Helper for Bug.comments sub _translate_comment { my ($self, $comment, $filters) = @_; return filter $filters, { id => $self->type('int', $comment->{id}), bug_id => $self->type('int', $comment->{bug_id}), author => $self->type('string', $comment->{author}->login), time => $self->type('dateTime', $comment->{'time'}), is_private => $self->type('boolean', $comment->{isprivate}), text => $self->type('string', $comment->{body}), }; } sub get { my ($self, $params) = @_; my $ids = $params->{ids}; defined $ids || ThrowCodeError('param_required', { param => 'ids' }); my @return; foreach my $bug_id (@$ids) { my $bug = Bugzilla::Bug->check($bug_id); # Timetracking fields are deleted if the user doesn't belong to # the corresponding group. unless (Bugzilla->user->in_group(Bugzilla->params->{'timetrackinggroup'})) { delete $bug->{'estimated_time'}; delete $bug->{'remaining_time'}; delete $bug->{'deadline'}; } # This is done in this fashion in order to produce a stable API. # The internals of Bugzilla::Bug are not stable enough to just # return them directly. my %item; $item{'creation_time'} = $self->type('dateTime', $bug->creation_ts); $item{'last_change_time'} = $self->type('dateTime', $bug->delta_ts); $item{'internals'} = $bug; $item{'id'} = $self->type('int', $bug->bug_id); $item{'summary'} = $self->type('string', $bug->short_desc); $item{'assigned_to'} = $self->type('string', $bug->assigned_to->login ); $item{'resolution'} = $self->type('string', $bug->resolution); $item{'status'} = $self->type('string', $bug->bug_status); $item{'is_open'} = $self->type('boolean', $bug->status->is_open); $item{'severity'} = $self->type('string', $bug->bug_severity); $item{'priority'} = $self->type('string', $bug->priority); $item{'product'} = $self->type('string', $bug->product); $item{'component'} = $self->type('string', $bug->component); $item{'dupe_of'} = $self->type('int', $bug->dup_id); # if we do not delete this key, additional user info, including their # real name, etc, will wind up in the 'internals' hashref delete $item{internals}->{assigned_to_obj}; if (Bugzilla->params->{'usebugaliases'}) { $item{'alias'} = $self->type('string', $bug->alias); } else { # For API reasons, we always want the value to appear, we just # don't want it to have a value if aliases are turned off. $item{'alias'} = undef; } push(@return, \%item); } return { bugs => \@return }; } # this is a function that gets bug activity for list of bug ids # it can be called as the following: # $call = $rpc->call( 'Bug.get_history', { ids => [1,2] }); sub get_history { my ($self, $params) = @_; my $ids = $params->{ids}; defined $ids || ThrowCodeError('param_required', { param => 'ids' }); my @return; foreach my $bug_id (@$ids) { my %item; my $bug = Bugzilla::Bug->check($bug_id); $bug_id = $bug->id; my ($activity) = Bugzilla::Bug::GetBugActivity($bug_id); $item{$bug_id} = []; foreach my $changeset (@$activity) { my %bug_history; $bug_history{when} = $self->type('dateTime', $self->datetime_format($changeset->{when})); $bug_history{who} = $self->type('string', $changeset->{who}); $bug_history{changes} = []; foreach my $change (@{ $changeset->{changes} }) { my $attach_id = delete $change->{attachid}; if ($attach_id) { $change->{attachment_id} = $self->type('int', $attach_id); } $change->{removed} = $self->type('string', $change->{removed}); $change->{added} = $self->type('string', $change->{added}); $change->{field_name} = $self->type('string', delete $change->{fieldname}); # This is going to go away in the future from GetBugActivity # so we shouldn't put it in the API. delete $change->{field}; push (@{$bug_history{changes}}, $change); } push (@{$item{$bug_id}}, \%bug_history); } # alias is returned in case users passes a mixture of ids and aliases # then they get to know which bug activity relates to which value # they passed if (Bugzilla->params->{'usebugaliases'}) { $item{alias} = $self->type('string', $bug->alias); } else { # For API reasons, we always want the value to appear, we just # don't want it to have a value if aliases are turned off. $item{alias} = undef; } push(@return, \%item); } return { bugs => \@return }; } sub create { my ($self, $params) = @_; Bugzilla->login(LOGIN_REQUIRED); my %field_values; foreach my $field (keys %$params) { my $field_name = FIELD_MAP->{$field} || $field; $field_values{$field_name} = $params->{$field}; } # WebService users can't set the creation date of a bug. delete $field_values{'creation_ts'}; my $bug = Bugzilla::Bug->create(\%field_values); Bugzilla::BugMail::Send($bug->bug_id, { changer => $bug->reporter->login }); return { id => $self->type('int', $bug->bug_id) }; } sub legal_values { my ($self, $params) = @_; my $field = FIELD_MAP->{$params->{field}} || $params->{field}; my @global_selects = Bugzilla->get_fields( {type => [FIELD_TYPE_SINGLE_SELECT, FIELD_TYPE_MULTI_SELECT]}); my $values; if (grep($_->name eq $field, @global_selects)) { $values = get_legal_field_values($field); } elsif (grep($_ eq $field, PRODUCT_SPECIFIC_FIELDS)) { my $id = $params->{product_id}; defined $id || ThrowCodeError('param_required', { function => 'Bug.legal_values', param => 'product_id' }); grep($_->id eq $id, @{Bugzilla->user->get_accessible_products}) || ThrowUserError('product_access_denied', { product => $id }); my $product = new Bugzilla::Product($id); my @objects; if ($field eq 'version') { @objects = @{$product->versions}; } elsif ($field eq 'target_milestone') { @objects = @{$product->milestones}; } elsif ($field eq 'component') { @objects = @{$product->components}; } $values = [map { $_->name } @objects]; } else { ThrowCodeError('invalid_field_name', { field => $params->{field} }); } my @result; foreach my $val (@$values) { push(@result, $self->type('string', $val)); } return { values => \@result }; } sub add_comment { my ($self, $params) = @_; #The user must login in order add a comment Bugzilla->login(LOGIN_REQUIRED); # Check parameters defined $params->{id} || ThrowCodeError('param_required', { param => 'id' }); my $comment = $params->{comment}; (defined $comment && trim($comment) ne '') || ThrowCodeError('param_required', { param => 'comment' }); my $bug = Bugzilla::Bug->check($params->{id}); Bugzilla->user->can_edit_product($bug->product_id) || ThrowUserError("product_edit_denied", {product => $bug->product}); # Append comment $bug->add_comment($comment, { isprivate => $params->{private}, work_time => $params->{work_time} }); # Capture the call to bug->update (which creates the new comment) in # a transaction so we're sure to get the correct comment_id. my $dbh = Bugzilla->dbh; $dbh->bz_start_transaction(); $bug->update(); my $new_comment_id = $dbh->bz_last_key('longdescs', 'comment_id'); $dbh->bz_commit_transaction(); # Send mail. Bugzilla::BugMail::Send($bug->bug_id, { changer => Bugzilla->user->login }); return { id => $self->type('int', $new_comment_id) }; } 1; __END__ =head1 NAME Bugzilla::Webservice::Bug - The API for creating, changing, and getting the details of bugs. =head1 DESCRIPTION This part of the Bugzilla API allows you to file a new bug in Bugzilla, or get information about bugs that have already been filed. =head1 METHODS See L for a description of how parameters are passed, and what B, B, and B mean. =head2 Utility Functions =over =item C B =over =item B Tells you what values are allowed for a particular field. =item B =over =item C - The name of the field you want information about. This should be the same as the name you would use in L, below. =item C - If you're picking a product-specific field, you have to specify the id of the product you want the values for. =back =item B C - An array of strings: the legal values for this field. The values will be sorted as they normally would be in Bugzilla. =item B =over =item 106 (Invalid Product) You were required to specify a product, and either you didn't, or you specified an invalid product (or a product that you can't access). =item 108 (Invalid Field Name) You specified a field that doesn't exist or isn't a drop-down field. =back =back =back =head2 Bug Information =over =item C B =over =item B This allows you to get data about comments, given a list of bugs and/or comment ids. =item B B: At least one of C or C is required. In addition to the parameters below, this method also accepts the standard L and L arguments. =over =item C C An array that can contain both bug IDs and bug aliases. All of the comments (that are visible to you) will be returned for the specified bugs. =item C C An array of integer comment_ids. These comments will be returned individually, separate from any other comments in their respective bugs. =item C C If specified, the method will only return comments I than this time. This only affects comments returned from the C argument. You will always be returned all comments you request in the C argument, even if they are older than this date. =back =item B Two items are returned: =over =item C This is used for bugs specified in C. This is a hash, where the keys are the numeric ids of the bugs, and the value is a hash with a single key, C, which is an array of comments. (The format of comments is described below.) Note that any individual bug will only be returned once, so if you specify an id multiple times in C, it will still only be returned once. =item C Each individual comment requested in C is returned here, in a hash where the numeric comment id is the key, and the value is the comment. (The format of comments is described below.) =back A "comment" as described above is a hash that contains the following keys: =over =item id C The globally unique ID for the comment. =item bug_id C The ID of the bug that this comment is on. =item text C The actual text of the comment. =item author C The login name of the comment's author. =item time C The time (in Bugzilla's timezone) that the comment was added. =item is_private C True if this comment is private (only visible to a certain group called the "insidergroup"), False otherwise. =back =item B This method can throw all the same errors as L. In addition, it can also throw the following errors: =over =item 110 (Comment Is Private) You specified the id of a private comment in the C argument, and you are not in the "insider group" that can see private comments. =item 111 (Invalid Comment ID) You specified an id in the C argument that is invalid--either you specified something that wasn't a number, or there is no comment with that id. =back =back =item C B =over =item B Gets information about particular bugs in the database. Note: Can also be called as "get_bugs" for compatibilty with Bugzilla 3.0 API. =item B =over =item C An array of numbers and strings. If an element in the array is entirely numeric, it represents a bug_id from the Bugzilla database to fetch. If it contains any non-numeric characters, it is considered to be a bug alias instead, and the bug with that alias will be loaded. Note that it's possible for aliases to be disabled in Bugzilla, in which case you will be told that you have specified an invalid bug_id if you try to specify an alias. (It will be error 100.) =back =item B A hash containing a single element, C. This is an array of hashes. Each hash contains the following items: =over =item alias C The alias of this bug. If there is no alias or aliases are disabled in this Bugzilla, this will be an empty string. =item assigned_to C The login name of the user to whom the bug is assigned. =item component C The name of the current component of this bug. =item creation_time C When the bug was created. =item dupe_of C The bug ID of the bug that this bug is a duplicate of. If this bug isn't a duplicate of any bug, this will be an empty int. =item id C The numeric bug_id of this bug. =item internals B A hash. The internals of a L object. This is extremely unstable, and you should only rely on this if you absolutely have to. The structure of the hash may even change between point releases of Bugzilla. =item is_open C Returns true (1) if this bug is open, false (0) if it is closed. =item last_change_time C When the bug was last changed. =item priority C The priority of the bug. =item product C The name of the product this bug is in. =item resolution C The current resolution of the bug, or an empty string if the bug is open. =item severity C The current severity of the bug. =item status C The current status of the bug. =item summary C The summary of this bug. =back =item B =over =item 100 (Invalid Bug Alias) If you specified an alias and either: (a) the Bugzilla you're querying doesn't support aliases or (b) there is no bug with that alias. =item 101 (Invalid Bug ID) The bug_id you specified doesn't exist in the database. =item 102 (Access Denied) You do not have access to the bug_id you specified. =back =item B =over =item The following properties were added to this method's return value in Bugzilla B<3.4>: =over =item assigned_to =item component =item dupe_of =item is_open =item priority =item product =item resolution =item severity =item status =back =back =back =item C B =over =item B Gets the history of changes for particular bugs in the database. =item B =over =item C An array of numbers and strings. If an element in the array is entirely numeric, it represents a bug_id from the Bugzilla database to fetch. If it contains any non-numeric characters, it is considered to be a bug alias instead, and the data bug with that alias will be loaded. Note that it's possible for aliases to be disabled in Bugzilla, in which case you will be told that you have specified an invalid bug_id if you try to specify an alias. (It will be error 100.) =back =item B A hash containing a single element, C. This is a hash of hashes. Each hash has the numeric bug id as a key, and contains the following items: =over =item alias C The alias of this bug. If there is no alias or aliases are disabled in this Bugzilla, this will be undef. =over =item when C The date the bug activity/change happened. =item who C The login name of the user who performed the bug change. =item changes C An array of hashes which contain all the changes that happened to the bug at this time (as specified by C). Each hash contains the following items: =over =item field_name C The name of the bug field that has changed. =item removed C The previous value of the bug field which has been deleted by the change. =item added C The new value of the bug field which has been added by the change. =item attachment_id C The id of the attachment that was changed. This only appears if the change was to an attachment, otherwise C will not be present in this hash. =back =back =back =item B The same as L. =item B =over =item Added in Bugzilla B<3.4>. =back =back =back =head2 Bug Creation and Modification =over =item C B =over =item B This allows you to create a new bug in Bugzilla. If you specify any invalid fields, they will be ignored. If you specify any fields you are not allowed to set, they will just be set to their defaults or ignored. You cannot currently set all the items here that you can set on enter_bug.cgi. The WebService interface may allow you to set things other than those listed here, but realize that anything undocumented is B and will very likely change in the future. =item B Some params must be set, or an error will be thrown. These params are marked B. Some parameters can have defaults set in Bugzilla, by the administrator. If these parameters have defaults set, you can omit them. These parameters are marked B. Clients that want to be able to interact uniformly with multiple Bugzillas should always set both the params marked B and those marked B, because some Bugzillas may not have defaults set for B parameters, and then this method will throw an error if you don't specify them. The descriptions of the parameters below are what they mean when Bugzilla is being used to track software bugs. They may have other meanings in some installations. =over =item C (string) B - The name of the product the bug is being filed against. =item C (string) B - The name of a component in the product above. =item C (string) B - A brief description of the bug being filed. =item C (string) B - A version of the product above; the version the bug was found in. =item C (string) B - The initial description for this bug. Some Bugzilla installations require this to not be blank. =item C (string) B - The operating system the bug was discovered on. =item C (string) B - What type of hardware the bug was experienced on. =item C (string) B - What order the bug will be fixed in by the developer, compared to the developer's other bugs. =item C (string) B - How severe the bug is. =item C (string) - A brief alias for the bug that can be used instead of a bug number when accessing this bug. Must be unique in all of this Bugzilla. =item C (username) - A user to assign this bug to, if you don't want it to be assigned to the component owner. =item C (array) - An array of usernames to CC on this bug. =item C (username) - If this installation has QA Contacts enabled, you can set the QA Contact here if you don't want to use the component's default QA Contact. =item C (string) - The status that this bug should start out as. Note that only certain statuses can be set on bug creation. =item C (string) - A valid target milestone for this product. =back In addition to the above parameters, if your installation has any custom fields, you can set them just by passing in the name of the field and its value as a string. =item B A hash with one element, C. This is the id of the newly-filed bug. =item B =over =item 51 (Invalid Object) The component you specified is not valid for this Product. =item 103 (Invalid Alias) The alias you specified is invalid for some reason. See the error message for more details. =item 104 (Invalid Field) One of the drop-down fields has an invalid value, or a value entered in a text field is too long. The error message will have more detail. =item 105 (Invalid Component) You didn't specify a component. =item 106 (Invalid Product) Either you didn't specify a product, this product doesn't exist, or you don't have permission to enter bugs in this product. =item 107 (Invalid Summary) You didn't specify a summary for the bug. =item 504 (Invalid User) Either the QA Contact, Assignee, or CC lists have some invalid user in them. The error message will have more details. =back =item B =over =item Before B<3.0.4>, parameters marked as B were actually B, due to a bug in Bugzilla. =back =back =item C B =over =item B This allows you to add a comment to a bug in Bugzilla. =item B =over =item C (int) B - The id or alias of the bug to append a comment to. =item C (string) B - The comment to append to the bug. If this is empty or all whitespace, an error will be thrown saying that you did not set the C parameter. =item C (boolean) - If set to true, the comment is private, otherwise it is assumed to be public. =item C (double) - Adds this many hours to the "Hours Worked" on the bug. If you are not in the time tracking group, this value will be ignored. =back =item B A hash with one element, C whose value is the id of the newly-created comment. =item B =over =item 100 (Invalid Bug Alias) If you specified an alias and either: (a) the Bugzilla you're querying doesn't support aliases or (b) there is no bug with that alias. =item 101 (Invalid Bug ID) The id you specified doesn't exist in the database. =item 108 (Bug Edit Denied) You did not have the necessary rights to edit the bug. =back =item B =over =item Added in Bugzilla B<3.2>. =item Modified to return the new comment's id in Bugzilla B<3.4> =back =back =back