# This Source Code Form is subject to the terms of the Mozilla Public # License, v. 2.0. If a copy of the MPL was not distributed with this # file, You can obtain one at http://mozilla.org/MPL/2.0/. # # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. package Bugzilla::WebService::Server::XMLRPC; use 5.10.1; use strict; use XMLRPC::Transport::HTTP; use Bugzilla::WebService::Server; if ($ENV{MOD_PERL}) { our @ISA = qw(XMLRPC::Transport::HTTP::Apache Bugzilla::WebService::Server); } else { our @ISA = qw(XMLRPC::Transport::HTTP::CGI Bugzilla::WebService::Server); } use Bugzilla::WebService::Constants; use Bugzilla::Util; BEGIN { # Allow WebService methods to call XMLRPC::Lite's type method directly *Bugzilla::WebService::type = sub { my ($self, $type, $value) = @_; if ($type eq 'dateTime') { # This is the XML-RPC implementation, see the README in Bugzilla/WebService/. # Our "base" implementation is in Bugzilla::WebService::Server. $value = Bugzilla::WebService::Server->datetime_format_outbound($value); $value =~ s/-//g; } elsif ($type eq 'email') { $type = 'string'; if (Bugzilla->params->{'webservice_email_filter'}) { $value = email_filter($value); } } return XMLRPC::Data->type($type)->value($value); }; # Add support for ETags into XMLRPC WebServices *Bugzilla::WebService::bz_etag = sub { return Bugzilla::WebService::Server->bz_etag($_[1]); }; } sub initialize { my $self = shift; my %retval = $self->SUPER::initialize(@_); $retval{'serializer'} = Bugzilla::XMLRPC::Serializer->new; $retval{'deserializer'} = Bugzilla::XMLRPC::Deserializer->new; $retval{'dispatch_with'} = WS_DISPATCH; return %retval; } sub make_response { my $self = shift; my $cgi = Bugzilla->cgi; $self->SUPER::make_response(@_); # XMLRPC::Transport::HTTP::CGI doesn't know about Bugzilla carrying around # its cookies in Bugzilla::CGI, so we need to copy them over. foreach my $cookie (@{$cgi->{'Bugzilla_cookie_list'}}) { $self->response->headers->push_header('Set-Cookie', $cookie); } # Copy across security related headers from Bugzilla::CGI foreach my $header (split(/[\r\n]+/, $cgi->header)) { my ($name, $value) = $header =~ /^([^:]+): (.*)/; if (!$self->response->headers->header($name)) { $self->response->headers->header($name => $value); } } # ETag support my $etag = $self->bz_etag; if (!$etag) { my $data = $self->response->as_string; $etag = $self->bz_etag($data); } if ($etag && $cgi->check_etag($etag)) { $self->response->headers->push_header('ETag', $etag); $self->response->headers->push_header('status', '304 Not Modified'); } elsif ($etag) { $self->response->headers->push_header('ETag', $etag); } } sub handle_login { my ($self, $classes, $action, $uri, $method) = @_; my $class = $classes->{$uri}; my $full_method = $uri . "." . $method; $self->SUPER::handle_login($class, $method, $full_method); return; } 1; # This exists to validate input parameters (which XMLRPC::Lite doesn't do) # and also, in some cases, to more-usefully decode them. package Bugzilla::XMLRPC::Deserializer; use 5.10.1; use strict; # We can't use "use parent" because XMLRPC::Serializer doesn't return # a true value. use XMLRPC::Lite; our @ISA = qw(XMLRPC::Deserializer); use Bugzilla::Error; use Bugzilla::WebService::Constants qw(XMLRPC_CONTENT_TYPE_WHITELIST); use Scalar::Util qw(tainted); sub deserialize { my $self = shift; # Only allow certain content types to protect against CSRF attacks my $content_type = lc($ENV{'CONTENT_TYPE'}); # Remove charset, etc, if provided $content_type =~ s/^([^;]+);.*/$1/; if (!grep($_ eq $content_type, XMLRPC_CONTENT_TYPE_WHITELIST)) { ThrowUserError('xmlrpc_illegal_content_type', { content_type => $ENV{'CONTENT_TYPE'} }); } my ($xml) = @_; my $som = $self->SUPER::deserialize(@_); if (tainted($xml)) { $som->{_bz_do_taint} = 1; } bless $som, 'Bugzilla::XMLRPC::SOM'; my $params = $som->paramsin; # This allows positional parameters for Testopia. $params = {} if ref $params ne 'HASH'; Bugzilla->input_params($params); return $som; } # Some method arguments need to be converted in some way, when they are input. sub decode_value { my $self = shift; my ($type) = @{ $_[0] }; my $value = $self->SUPER::decode_value(@_); # We only validate/convert certain types here. return $value if $type !~ /^(?:int|i4|boolean|double|dateTime\.iso8601)$/; # Though the XML-RPC standard doesn't allow an empty , # ,or , we do, and we just say # "that's undef". if (grep($type eq $_, qw(int double dateTime))) { return undef if $value eq ''; } my $validator = $self->_validation_subs->{$type}; if (!$validator->($value)) { ThrowUserError('xmlrpc_invalid_value', { type => $type, value => $value }); } # We convert dateTimes to a DB-friendly date format. if ($type eq 'dateTime.iso8601') { if ($value !~ /T.*[\-+Z]/i) { # The caller did not specify a timezone, so we assume UTC. # pass 'Z' specifier to datetime_from to force it $value = $value . 'Z'; } $value = Bugzilla::WebService::Server::XMLRPC->datetime_format_inbound($value); } return $value; } sub _validation_subs { my $self = shift; return $self->{_validation_subs} if $self->{_validation_subs}; # The only place that XMLRPC::Lite stores any sort of validation # regex is in XMLRPC::Serializer. We want to re-use those regexes here. my $lookup = Bugzilla::XMLRPC::Serializer->new->typelookup; # $lookup is a hash whose values are arrayrefs, and whose keys are the # names of types. The second item of each arrayref is a subroutine # that will do our validation for us. my %validators = map { $_ => $lookup->{$_}->[1] } (keys %$lookup); # Add a boolean validator $validators{'boolean'} = sub {$_[0] =~ /^[01]$/}; # Some types have multiple names, or have a different name in # XMLRPC::Serializer than their standard XML-RPC name. $validators{'dateTime.iso8601'} = $validators{'dateTime'}; $validators{'i4'} = $validators{'int'}; $self->{_validation_subs} = \%validators; return \%validators; } 1; package Bugzilla::XMLRPC::SOM; use 5.10.1; use strict; use XMLRPC::Lite; our @ISA = qw(XMLRPC::SOM); use Bugzilla::WebService::Util qw(taint_data); sub paramsin { my $self = shift; if (!$self->{bz_params_in}) { my @params = $self->SUPER::paramsin(@_); if ($self->{_bz_do_taint}) { taint_data(@params); } $self->{bz_params_in} = \@params; } my $params = $self->{bz_params_in}; return wantarray ? @$params : $params->[0]; } 1; # This package exists to fix a UTF-8 bug in SOAP::Lite. # See http://rt.cpan.org/Public/Bug/Display.html?id=32952. package Bugzilla::XMLRPC::Serializer; use 5.10.1; use strict; use Scalar::Util qw(blessed reftype); # We can't use "use parent" because XMLRPC::Serializer doesn't return # a true value. use XMLRPC::Lite; our @ISA = qw(XMLRPC::Serializer); sub new { my $class = shift; my $self = $class->SUPER::new(@_); # This fixes UTF-8. $self->{'_typelookup'}->{'base64'} = [10, sub { !utf8::is_utf8($_[0]) && $_[0] =~ /[^\x09\x0a\x0d\x20-\x7f]/}, 'as_base64']; # This makes arrays work right even though we're a subclass. # (See http://rt.cpan.org//Ticket/Display.html?id=34514) $self->{'_encodingStyle'} = ''; return $self; } # Here the XMLRPC::Serializer is extended to use the XMLRPC nil extension. sub encode_object { my $self = shift; my @encoded = $self->SUPER::encode_object(@_); return $encoded[0]->[0] eq 'nil' ? ['value', {}, [@encoded]] : @encoded; } # Removes undefined values so they do not produce invalid XMLRPC. sub envelope { my $self = shift; my ($type, $method, $data) = @_; # If the type isn't a successful response we don't want to change the values. if ($type eq 'response') { _strip_undefs($data); } return $self->SUPER::envelope($type, $method, $data); } # In an XMLRPC response we have to handle hashes of arrays, hashes, scalars, # Bugzilla objects (reftype = 'HASH') and XMLRPC::Data objects. # The whole XMLRPC::Data object must be removed if its value key is undefined # so it cannot be recursed like the other hash type objects. sub _strip_undefs { my ($initial) = @_; my $type = reftype($initial) or return; if ($type eq "HASH") { while (my ($key, $value) = each(%$initial)) { if ( !defined $value || (blessed $value && $value->isa('XMLRPC::Data') && !defined $value->value) ) { # If the value is undefined remove it from the hash. delete $initial->{$key}; } else { _strip_undefs($value); } } } elsif ($type eq "ARRAY") { for (my $count = 0; $count < scalar @{$initial}; $count++) { my $value = $initial->[$count]; if ( !defined $value || (blessed $value && $value->isa('XMLRPC::Data') && !defined $value->value) ) { # If the value is undefined remove it from the array. splice(@$initial, $count, 1); $count--; } else { _strip_undefs($value); } } } } sub BEGIN { no strict 'refs'; for my $type (qw(double i4 int dateTime)) { my $method = 'as_' . $type; *$method = sub { my ($self, $value) = @_; if (!defined($value)) { return as_nil(); } else { my $super_method = "SUPER::$method"; return $self->$super_method($value); } } } } sub as_nil { return ['nil', {}]; } 1; __END__ =head1 NAME Bugzilla::WebService::Server::XMLRPC - The XML-RPC Interface to Bugzilla =head1 DESCRIPTION This documentation describes things about the Bugzilla WebService that are specific to XML-RPC. For a general overview of the Bugzilla WebServices, see L. =head1 XML-RPC The XML-RPC standard is described here: L =head1 CONNECTING The endpoint for the XML-RPC interface is the C script in your Bugzilla installation. For example, if your Bugzilla is at C, then your XML-RPC client would access the API via: C =head1 PARAMETERS C fields are the standard C XML-RPC field. They should be in C format (where C is a literal T). As of Bugzilla B<3.6>, Bugzilla always expects C fields to be in the UTC timezone, and all returned C values are in the UTC timezone. All other fields are standard XML-RPC types. =head2 How XML-RPC WebService Methods Take Parameters All functions take a single argument, a C<< >> that contains all parameters. The names of the parameters listed in the API docs for each function are the C<< >> element for the struct C<< >>s. =head1 EXTENSIONS TO THE XML-RPC STANDARD =head2 Undefined Values Normally, XML-RPC does not allow empty values for C, C, or C fields. Bugzilla does--it treats empty values as C (called C or C in some programming languages). Bugzilla accepts a timezone specifier at the end of C fields that are specified as method arguments. The format of the timezone specifier is specified in the ISO-8601 standard. If no timezone specifier is included, the passed-in time is assumed to be in the UTC timezone. Bugzilla will never output a timezone specifier on returned data, because doing so would violate the XML-RPC specification. All returned times are in the UTC timezone. Bugzilla also accepts an element called C<< >>, as specified by the XML-RPC extension here: L, which is always considered to be C, no matter what it contains. Bugzilla does not use C<< >> values in returned data, because currently most clients do not support C<< >>. Instead, any fields with C values will be stripped from the response completely. Therefore B. =begin private nil is implemented by XMLRPC::Lite, in XMLRPC::Deserializer::decode_value in the CPAN SVN since 14th Dec 2008 L and in Fedora's perl-SOAP-Lite package in versions 0.68-1 and above. =end private =head1 SEE ALSO L =head1 B =over =item make_response =item initialize =item handle_login =back