#!/usr/bin/perl -wT # -*- Mode: perl; indent-tabs-mode: nil -*- # # The contents of this file are subject to the Mozilla Public # License Version 1.1 (the "License"); you may not use this file # except in compliance with the License. You may obtain a copy of # the License at http://www.mozilla.org/MPL/ # # Software distributed under the License is distributed on an "AS # IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or # implied. See the License for the specific language governing # rights and limitations under the License. # # The Original Code is the Bugzilla Bug Tracking System. # # The Initial Developer of the Original Code is Netscape Communications # Corporation. Portions created by Netscape are # Copyright (C) 1998 Netscape Communications Corporation. All # Rights Reserved. # # Contributor(s): Dave Miller # Joel Peshkin # Jacob Steenhagen # Vlad Dascalu # Frédéric Buclin # Code derived from editowners.cgi and editusers.cgi use strict; use lib "."; use Bugzilla; use Bugzilla::Constants; use Bugzilla::User; require "globals.pl"; my $cgi = Bugzilla->cgi; my $dbh = Bugzilla->dbh; use vars qw($template $vars); Bugzilla->login(LOGIN_REQUIRED); print Bugzilla->cgi->header(); UserInGroup("creategroups") || ThrowUserError("auth_failure", {group => "creategroups", action => "edit", object => "groups"}); my $action = trim($cgi->param('action') || ''); # RederiveRegexp: update user_group_map with regexp-based grants sub RederiveRegexp ($$) { my $regexp = shift; my $gid = shift; my $dbh = Bugzilla->dbh; my $sth = $dbh->prepare("SELECT userid, login_name FROM profiles"); my $sthqry = $dbh->prepare("SELECT 1 FROM user_group_map WHERE user_id = ? AND group_id = ? AND grant_type = ? and isbless = 0"); my $sthadd = $dbh->prepare("INSERT INTO user_group_map (user_id, group_id, grant_type, isbless) VALUES (?, ?, ?, 0)"); my $sthdel = $dbh->prepare("DELETE FROM user_group_map WHERE user_id = ? AND group_id = ? AND grant_type = ? and isbless = 0"); $sth->execute(); while (my ($uid, $login) = $sth->fetchrow_array()) { my $present = $dbh->selectrow_array($sthqry, undef, $uid, $gid, GRANT_REGEXP); if (($regexp =~ /\S+/) && ($login =~ m/$regexp/i)) { $sthadd->execute($uid, $gid, GRANT_REGEXP) unless $present; } else { $sthdel->execute($uid, $gid, GRANT_REGEXP) if $present; } } } # CheckGroupID checks that a positive integer is given and is # actually a valid group ID. If all tests are successful, the # trimmed group ID is returned. sub CheckGroupID { my ($group_id) = @_; $group_id = trim($group_id || 0); ThrowUserError("group_not_specified") unless $group_id; (detaint_natural($group_id) && Bugzilla->dbh->selectrow_array("SELECT id FROM groups WHERE id = ?", undef, $group_id)) || ThrowUserError("invalid_group_ID"); return $group_id; } # This subroutine is called when: # - a new group is created. CheckGroupName checks that its name # is not empty and is not already used by any existing group. # - an existing group is edited. CheckGroupName checks that its # name has not been deleted or renamed to another existing # group name (whose group ID is different from $group_id). # In both cases, an error message is returned to the user if any # test fails! Else, the trimmed group name is returned. sub CheckGroupName { my ($name, $group_id) = @_; $name = trim($name || ''); trick_taint($name); ThrowUserError("empty_group_name") unless $name; my $excludeself = (defined $group_id) ? " AND id != $group_id" : ""; my $name_exists = Bugzilla->dbh->selectrow_array("SELECT name FROM groups " . "WHERE name = ? $excludeself", undef, $name); if ($name_exists) { ThrowUserError("group_exists", { name => $name }); } return $name; } # CheckGroupDesc checks that a non empty description is given. The # trimmed description is returned. sub CheckGroupDesc { my ($desc) = @_; $desc = trim($desc || ''); trick_taint($desc); ThrowUserError("empty_group_description") unless $desc; return $desc; } # CheckGroupRegexp checks that the regular expression is valid # (the regular expression being optional, the test is successful # if none is given, as expected). The trimmed regular expression # is returned. sub CheckGroupRegexp { my ($regexp) = @_; $regexp = trim($regexp || ''); trick_taint($regexp); ThrowUserError("invalid_regexp") unless (eval {qr/$regexp/}); return $regexp; } # If no action is specified, get a list of all groups available. unless ($action) { my @groups; SendSQL("SELECT id,name,description,userregexp,isactive,isbuggroup " . "FROM groups " . "ORDER BY isbuggroup, name"); while (MoreSQLData()) { my ($id, $name, $description, $regexp, $isactive, $isbuggroup) = FetchSQLData(); my $group = {}; $group->{'id'} = $id; $group->{'name'} = $name; $group->{'description'} = $description; $group->{'regexp'} = $regexp; $group->{'isactive'} = $isactive; $group->{'isbuggroup'} = $isbuggroup; push(@groups, $group); } $vars->{'groups'} = \@groups; print Bugzilla->cgi->header(); $template->process("admin/groups/list.html.tmpl", $vars) || ThrowTemplateError($template->error()); exit; } # # action='changeform' -> present form for altering an existing group # # (next action will be 'postchanges') # if ($action eq 'changeform') { # Check that an existing group ID is given my $group_id = CheckGroupID($cgi->param('group')); my ($name, $description, $regexp, $isactive, $isbuggroup) = $dbh->selectrow_array("SELECT name, description, userregexp, " . "isactive, isbuggroup " . "FROM groups WHERE id = ?", undef, $group_id); # For each group, we use left joins to establish the existence of # a record making that group a member of this group # and the existence of a record permitting that group to bless # this one my @groups; SendSQL("SELECT groups.id, groups.name, groups.description," . " CASE WHEN group_group_map.member_id IS NOT NULL THEN 1 ELSE 0 END," . " CASE WHEN B.member_id IS NOT NULL THEN 1 ELSE 0 END," . " CASE WHEN C.member_id IS NOT NULL THEN 1 ELSE 0 END" . " FROM groups" . " LEFT JOIN group_group_map" . " ON group_group_map.member_id = groups.id" . " AND group_group_map.grantor_id = $group_id" . " AND group_group_map.grant_type = " . GROUP_MEMBERSHIP . " LEFT JOIN group_group_map as B" . " ON B.member_id = groups.id" . " AND B.grantor_id = $group_id" . " AND B.grant_type = " . GROUP_BLESS . " LEFT JOIN group_group_map as C" . " ON C.member_id = groups.id" . " AND C.grantor_id = $group_id" . " AND C.grant_type = " . GROUP_VISIBLE . " ORDER by name"); while (MoreSQLData()) { my ($grpid, $grpnam, $grpdesc, $grpmember, $blessmember, $membercansee) = FetchSQLData(); my $group = {}; $group->{'grpid'} = $grpid; $group->{'grpnam'} = $grpnam; $group->{'grpdesc'} = $grpdesc; $group->{'grpmember'} = $grpmember; $group->{'blessmember'} = $blessmember; $group->{'membercansee'}= $membercansee; push(@groups, $group); } $vars->{'group_id'} = $group_id; $vars->{'name'} = $name; $vars->{'description'} = $description; $vars->{'regexp'} = $regexp; $vars->{'isactive'} = $isactive; $vars->{'isbuggroup'} = $isbuggroup; $vars->{'groups'} = \@groups; print Bugzilla->cgi->header(); $template->process("admin/groups/edit.html.tmpl", $vars) || ThrowTemplateError($template->error()); exit; } # # action='add' -> present form for parameters for new group # # (next action will be 'new') # if ($action eq 'add') { print Bugzilla->cgi->header(); $template->process("admin/groups/create.html.tmpl", $vars) || ThrowTemplateError($template->error()); exit; } # # action='new' -> add group entered in the 'action=add' screen # if ($action eq 'new') { # Check that a not already used group name is given, that # a description is also given and check if the regular # expression is valid (if any). my $name = CheckGroupName($cgi->param('name')); my $desc = CheckGroupDesc($cgi->param('desc')); my $regexp = CheckGroupRegexp($cgi->param('regexp')); my $isactive = $cgi->param('isactive') ? 1 : 0; # Add the new group SendSQL("INSERT INTO groups ( " . "name, description, isbuggroup, userregexp, isactive, last_changed " . " ) VALUES ( " . SqlQuote($name) . ", " . SqlQuote($desc) . ", " . "1," . SqlQuote($regexp) . ", " . $isactive . ", NOW())" ); my $gid = $dbh->bz_last_key('groups', 'id'); my $admin = GroupNameToId('admin'); # Since we created a new group, give the "admin" group all privileges # initially. SendSQL("INSERT INTO group_group_map (member_id, grantor_id, grant_type) VALUES ($admin, $gid, " . GROUP_MEMBERSHIP . ")"); SendSQL("INSERT INTO group_group_map (member_id, grantor_id, grant_type) VALUES ($admin, $gid, " . GROUP_BLESS . ")"); SendSQL("INSERT INTO group_group_map (member_id, grantor_id, grant_type) VALUES ($admin, $gid, " . GROUP_VISIBLE . ")"); # Permit all existing products to use the new group if makeproductgroups. if ($cgi->param('insertnew')) { SendSQL("INSERT INTO group_control_map " . "(group_id, product_id, entry, membercontrol, " . "othercontrol, canedit) " . "SELECT $gid, products.id, 0, " . CONTROLMAPSHOWN . ", " . CONTROLMAPNA . ", 0 " . "FROM products"); } RederiveRegexp($regexp, $gid); print Bugzilla->cgi->header(); $template->process("admin/groups/created.html.tmpl", $vars) || ThrowTemplateError($template->error()); exit; } # # action='del' -> ask if user really wants to delete # # (next action would be 'delete') # if ($action eq 'del') { # Check that an existing group ID is given my $gid = CheckGroupID($cgi->param('group')); my ($name, $desc, $isbuggroup) = $dbh->selectrow_array("SELECT name, description, isbuggroup " . "FROM groups WHERE id = ?", undef, $gid); # System groups cannot be deleted! if (!$isbuggroup) { ThrowUserError("system_group_not_deletable", { name => $name }); } my $hasusers = 0; SendSQL("SELECT user_id FROM user_group_map WHERE group_id = $gid AND isbless = 0"); if (FetchOneColumn()) { $hasusers = 1; } my $hasbugs = 0; my $buglist = "0"; SendSQL("SELECT bug_id FROM bug_group_map WHERE group_id = $gid"); if (MoreSQLData()) { $hasbugs = 1; while (MoreSQLData()) { my ($bug) = FetchSQLData(); $buglist .= "," . $bug; } } my $hasproduct = 0; SendSQL("SELECT name FROM products WHERE name=" . SqlQuote($name)); if (MoreSQLData()) { $hasproduct = 1; } my $hasflags = 0; SendSQL("SELECT id FROM flagtypes WHERE grant_group_id = $gid OR request_group_id = $gid"); if (FetchOneColumn()) { $hasflags = 1; } $vars->{'gid'} = $gid; $vars->{'name'} = $name; $vars->{'description'} = $desc; $vars->{'hasusers'} = $hasusers; $vars->{'hasbugs'} = $hasbugs; $vars->{'hasproduct'} = $hasproduct; $vars->{'hasflags'} = $hasflags; $vars->{'buglist'} = $buglist; print Bugzilla->cgi->header(); $template->process("admin/groups/delete.html.tmpl", $vars) || ThrowTemplateError($template->error()); exit; } # # action='delete' -> really delete the group # if ($action eq 'delete') { # Check that an existing group ID is given my $gid = CheckGroupID($cgi->param('group')); my ($name, $isbuggroup) = $dbh->selectrow_array("SELECT name, isbuggroup FROM groups " . "WHERE id = ?", undef, $gid); # System groups cannot be deleted! if (!$isbuggroup) { ThrowUserError("system_group_not_deletable", { name => $name }); } my $cantdelete = 0; SendSQL("SELECT user_id FROM user_group_map WHERE group_id = $gid AND isbless = 0"); if (FetchOneColumn()) { if (!defined $cgi->param('removeusers')) { $cantdelete = 1; } } SendSQL("SELECT bug_id FROM bug_group_map WHERE group_id = $gid"); if (FetchOneColumn()) { if (!defined $cgi->param('removebugs')) { $cantdelete = 1; } } SendSQL("SELECT name FROM products WHERE name=" . SqlQuote($name)); if (FetchOneColumn()) { if (!defined $cgi->param('unbind')) { $cantdelete = 1; } } SendSQL("SELECT id FROM flagtypes WHERE grant_group_id = $gid OR request_group_id = $gid"); if (FetchOneColumn()) { if (!defined $cgi->param('removeflags')) { $cantdelete = 1; } } if (!$cantdelete) { SendSQL("UPDATE flagtypes SET grant_group_id = NULL WHERE grant_group_id = $gid"); SendSQL("UPDATE flagtypes SET request_group_id = NULL WHERE request_group_id = $gid"); SendSQL("DELETE FROM user_group_map WHERE group_id = $gid"); SendSQL("DELETE FROM group_group_map WHERE grantor_id = $gid"); SendSQL("DELETE FROM bug_group_map WHERE group_id = $gid"); SendSQL("DELETE FROM group_control_map WHERE group_id = $gid"); SendSQL("DELETE FROM whine_schedules WHERE " . "mailto_type = " . MAILTO_GROUP . " " . "AND mailto = $gid"); SendSQL("DELETE FROM groups WHERE id = $gid"); } $vars->{'gid'} = $gid; $vars->{'name'} = $name; $vars->{'cantdelete'} = $cantdelete; print Bugzilla->cgi->header(); $template->process("admin/groups/deleted.html.tmpl", $vars) || ThrowTemplateError($template->error()); exit; } # # action='postchanges' -> update the groups # if ($action eq 'postchanges') { # ZLL: Bug 181589: we need to have something to remove explictly listed users from # groups in order for the conversion to 2.18 groups to work my $action; if ($cgi->param('remove_explicit_members')) { $action = 1; } elsif ($cgi->param('remove_explicit_members_regexp')) { $action = 2; } else { $action = 3; } my ($gid, $chgs, $name, $regexp) = doGroupChanges(); $vars->{'action'} = $action; $vars->{'changes'} = $chgs; $vars->{'gid'} = $gid; $vars->{'name'} = $name; if ($action == 2) { $vars->{'regexp'} = $regexp; } print Bugzilla->cgi->header(); $template->process("admin/groups/change.html.tmpl", $vars) || ThrowTemplateError($template->error()); exit; } if (($action eq 'remove_all_regexp') || ($action eq 'remove_all')) { # remove all explicit users from the group with # gid = $cgi->param('group') that match the regular expression # stored in the DB for that group or all of them period my $gid = CheckGroupID($cgi->param('group')); my $sth = $dbh->prepare("SELECT name, userregexp FROM groups WHERE id = ?"); $sth->execute($gid); my ($name, $regexp) = $sth->fetchrow_array(); $dbh->bz_lock_tables('groups WRITE', 'profiles READ', 'user_group_map WRITE'); $sth = $dbh->prepare("SELECT user_group_map.user_id, profiles.login_name FROM user_group_map INNER JOIN profiles ON user_group_map.user_id = profiles.userid WHERE user_group_map.group_id = ? AND grant_type = ? AND isbless = 0"); $sth->execute($gid, GRANT_DIRECT); my @users; my $sth2 = $dbh->prepare("DELETE FROM user_group_map WHERE user_id = ? AND isbless = 0 AND group_id = ?"); while ( my ($userid, $userlogin) = $sth->fetchrow_array() ) { if ((($regexp =~ /\S/) && ($userlogin =~ m/$regexp/i)) || ($action eq 'remove_all')) { $sth2->execute($userid,$gid); my $user = {}; $user->{'login'} = $userlogin; push(@users, $user); } } $sth = $dbh->prepare("UPDATE groups SET last_changed = NOW() WHERE id = ?"); $sth->execute($gid); $dbh->bz_unlock_tables(); $vars->{'users'} = \@users; $vars->{'name'} = $name; $vars->{'regexp'} = $regexp; $vars->{'remove_all'} = ($action eq 'remove_all'); $vars->{'gid'} = $gid; print Bugzilla->cgi->header(); $template->process("admin/groups/remove.html.tmpl", $vars) || ThrowTemplateError($template->error()); exit; } # # No valid action found # ThrowCodeError("action_unrecognized", $vars); # Helper sub to handle the making of changes to a group sub doGroupChanges { my $cgi = Bugzilla->cgi; my $dbh = Bugzilla->dbh; my $sth; $dbh->bz_lock_tables('groups WRITE', 'group_group_map WRITE', 'user_group_map WRITE', 'profiles READ', 'namedqueries READ', 'whine_queries READ'); # Check that the given group ID and regular expression are valid. # If tests are successful, trimmed values are returned by CheckGroup*. my $gid = CheckGroupID($cgi->param('group')); my $regexp = CheckGroupRegexp($cgi->param('regexp')); # The name and the description of system groups cannot be edited. # We then need to know if the group being edited is a system group. SendSQL("SELECT isbuggroup FROM groups WHERE id = $gid"); my ($isbuggroup) = FetchSQLData(); my $name; my $desc; my $isactive; my $chgs = 0; # We trust old values given by the template. If they are hacked # in a way that some of the tests below become negative, the # corresponding attributes are not updated in the DB, which does # not hurt. if ($isbuggroup) { # Check that the group name and its description are valid # and return trimmed values if tests are successful. $name = CheckGroupName($cgi->param('name'), $gid); $desc = CheckGroupDesc($cgi->param('desc')); $isactive = $cgi->param('isactive') ? 1 : 0; if ($name ne $cgi->param('oldname')) { $chgs = 1; $sth = $dbh->do("UPDATE groups SET name = ? WHERE id = ?", undef, $name, $gid); } if ($desc ne $cgi->param('olddesc')) { $chgs = 1; $sth = $dbh->do("UPDATE groups SET description = ? WHERE id = ?", undef, $desc, $gid); } if ($isactive ne $cgi->param('oldisactive')) { $chgs = 1; $sth = $dbh->do("UPDATE groups SET isactive = ? WHERE id = ?", undef, $isactive, $gid); } } if ($regexp ne $cgi->param('oldregexp')) { $chgs = 1; $sth = $dbh->do("UPDATE groups SET userregexp = ? WHERE id = ?", undef, $regexp, $gid); RederiveRegexp($regexp, $gid); } foreach my $b (grep {/^oldgrp-\d*$/} $cgi->param()) { if (defined($cgi->param($b))) { $b =~ /^oldgrp-(\d+)$/; my $v = $1; my $grp = $cgi->param("grp-$v") || 0; if (($v != $gid) && ($cgi->param("oldgrp-$v") != $grp)) { $chgs = 1; if ($grp != 0) { SendSQL("INSERT INTO group_group_map (member_id, grantor_id, grant_type) VALUES ($v, $gid," . GROUP_MEMBERSHIP . ")"); } else { SendSQL("DELETE FROM group_group_map WHERE member_id = $v AND grantor_id = $gid AND grant_type = " . GROUP_MEMBERSHIP); } } my $bless = $cgi->param("bless-$v") || 0; my $oldbless = $cgi->param("oldbless-$v"); if ((defined $oldbless) and ($oldbless != $bless)) { $chgs = 1; if ($bless != 0) { SendSQL("INSERT INTO group_group_map (member_id, grantor_id, grant_type) VALUES ($v, $gid," . GROUP_BLESS . ")"); } else { SendSQL("DELETE FROM group_group_map WHERE member_id = $v AND grantor_id = $gid AND grant_type = " . GROUP_BLESS); } } my $cansee = $cgi->param("cansee-$v") || 0; if (Param("usevisibilitygroups") && ($cgi->param("oldcansee-$v") != $cansee)) { $chgs = 1; if ($cansee != 0) { SendSQL("INSERT INTO group_group_map (member_id, grantor_id, grant_type) VALUES ($v, $gid," . GROUP_VISIBLE . ")"); } else { SendSQL("DELETE FROM group_group_map WHERE member_id = $v AND grantor_id = $gid AND grant_type = " . GROUP_VISIBLE); } } } } if ($chgs) { # mark the changes SendSQL("UPDATE groups SET last_changed = NOW() WHERE id = $gid"); } $dbh->bz_unlock_tables(); return $gid, $chgs, $name, $regexp; }