1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
|
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
#
# This Source Code Form is "Incompatible With Secondary Licenses", as
# defined by the Mozilla Public License, v. 2.0.
package Bugzilla::Extension::MozProjectReview;
use strict;
use base qw(Bugzilla::Extension);
use Bugzilla::User;
use Bugzilla::Group;
use Bugzilla::Error;
use Bugzilla::Constants;
our $VERSION = '0.01';
our %tracker_cc = (
'legal' => ['liz@mozilla.com'],
'sec-review' => ['curtisk@mozilla.com'],
'finance' => ['waoieong@mozilla.com', 'mcristobal@mozilla.com'],
'privacy-vendor' => ['smartin@mozilla.com'],
'privacy-project' => ['ahua@mozilla.com'],
'privacy-tech' => ['ahua@mozilla.com'],
'policy-business-partner' => ['smartin@mozilla.com']
);
sub post_bug_after_creation {
my ($self, $args) = @_;
my $vars = $args->{'vars'};
my $bug = $vars->{'bug'};
my $timestamp = $args->{'timestamp'};
my $user = Bugzilla->user;
my $params = Bugzilla->input_params;
my $template = Bugzilla->template;
return if !($params->{format}
&& $params->{format} eq 'moz-project-review'
&& $bug->component eq 'Project Review');
# do a match if applicable
Bugzilla::User::match_field({
'legal_cc' => { 'type' => 'multi' }
});
my ($do_sec_review, $do_legal, $do_finance, $do_privacy_vendor,
$do_privacy_tech, $do_privacy_policy);
if ($params->{'mozilla_data'} eq 'Yes') {
$do_legal = 1;
$do_privacy_policy = 1;
$do_privacy_tech = 1;
$do_sec_review = 1;
}
if ($params->{'separate_party'} eq 'Yes') {
if ($params->{'relationship_type'} ne 'Hardware Purchase') {
$do_legal = 1;
}
if ($params->{'data_access'} eq 'Yes') {
$do_privacy_policy = 1;
$do_legal = 1;
$do_sec_review = 1;
}
if ($params->{'data_access'} eq 'Yes'
&& $params->{'privacy_policy_vendor_user_data'} eq 'Yes')
{
$do_privacy_vendor = 1;
}
if ($params->{'vendor_cost'} eq '> $25,000'
|| ($params->{'vendor_cost'} eq '<= $25,000'
&& $params->{'po_needed'} eq 'Yes'))
{
$do_finance = 1;
}
}
my ($sec_review_bug, $legal_bug, $finance_bug, $privacy_vendor_bug,
$privacy_tech_bug, $privacy_policy_bug, $error, @dep_comment,
@dep_errors, @send_mail);
# Common parameters always passed to _file_child_bug
# bug_data and template_suffix will be different for each bug
my $child_params = {
parent_bug => $bug,
template_vars => $vars,
dep_comment => \@dep_comment,
dep_errors => \@dep_errors,
send_mail => \@send_mail,
};
if ($do_sec_review) {
$child_params->{'bug_data'} = {
short_desc => 'Security Review: ' . $bug->short_desc,
product => 'mozilla.org',
component => 'Security Assurance: Review Request',
bug_severity => 'normal',
groups => [ 'mozilla-employee-confidential' ],
op_sys => 'All',
rep_platform => 'All',
version => 'other',
blocked => $bug->bug_id,
};
$child_params->{'template_suffix'} = 'sec-review';
_file_child_bug($child_params);
}
if ($do_legal) {
my $component = 'General';
if ($params->{separate_party} eq 'Yes'
&& $params->{relationship_type})
{
$component = ($params->{relationship_type} eq 'Other'
|| $params->{relationship_type} eq 'Hardware Purchase')
? 'General'
: $params->{relationship_type};
}
my $legal_summary = "Legal Review: ";
$legal_summary .= $params->{legal_other_party} . " - " if $params->{legal_other_party};
$legal_summary .= $bug->short_desc;
$child_params->{'bug_data'} = {
short_desc => $legal_summary,
product => 'Legal',
component => $component,
bug_severity => 'normal',
priority => '--',
groups => [ 'legal' ],
op_sys => 'All',
rep_platform => 'All',
version => 'unspecified',
blocked => $bug->bug_id,
cc => $params->{'legal_cc'},
};
$child_params->{'template_suffix'} = 'legal';
_file_child_bug($child_params);
}
if ($do_finance) {
$child_params->{'bug_data'} = {
short_desc => 'Finance Review: ' . $bug->short_desc,
product => 'Finance',
component => 'Purchase Request Form',
bug_severity => 'normal',
priority => '--',
groups => [ 'finance' ],
op_sys => 'All',
rep_platform => 'All',
version => 'unspecified',
blocked => $bug->bug_id,
};
$child_params->{'template_suffix'} = 'finance';
_file_child_bug($child_params);
}
if ($do_privacy_tech) {
$child_params->{'bug_data'} = {
short_desc => 'Privacy-Technical Review: ' . $bug->short_desc,
product => 'mozilla.org',
component => 'Security Assurance: Review Request',
bug_severity => 'normal',
priority => '--',
keywords => 'privacy-review-needed',
groups => [ 'mozilla-employee-confidential' ],
op_sys => 'All',
rep_platform => 'All',
version => 'other',
blocked => $bug->bug_id,
};
$child_params->{'template_suffix'} = 'privacy-tech';
_file_child_bug($child_params);
}
if ($do_privacy_policy) {
$child_params->{'bug_data'} = {
short_desc => 'Privacy-Policy Review: ' . $bug->short_desc,
product => 'Privacy',
component => 'Product Review',
bug_severity => 'normal',
priority => '--',
groups => [ 'mozilla-employee-confidential' ],
op_sys => 'All',
rep_platform => 'All',
version => 'unspecified',
blocked => $bug->bug_id,
};
$child_params->{'template_suffix'} = 'privacy-policy';
_file_child_bug($child_params);
}
if ($do_privacy_vendor) {
$child_params->{'bug_data'} = {
short_desc => 'Privacy / Vendor Review: ' . $bug->short_desc,
product => 'Privacy',
component => 'Vendor Review',
bug_severity => 'normal',
priority => '--',
groups => [ 'mozilla-employee-confidential' ],
op_sys => 'All',
rep_platform => 'All',
version => 'unspecified',
blocked => $bug->bug_id,
};
$child_params->{'template_suffix'} = 'privacy-vendor';
_file_child_bug($child_params);
}
if (scalar @dep_errors) {
warn "[Bug " . $bug->id . "] Failed to create additional moz-project-review bugs:\n" .
join("\n", @dep_errors);
$vars->{'message'} = 'moz_project_review_creation_failed';
}
if (scalar @dep_comment) {
my $comment = join("\n", @dep_comment);
if (scalar @dep_errors) {
$comment .= "\n\nSome errors occurred creating dependent bugs and have been recorded";
}
$bug->add_comment($comment);
$bug->update($bug->creation_ts);
}
foreach my $bug_id (@send_mail) {
Bugzilla::BugMail::Send($bug_id, { changer => Bugzilla->user });
}
}
sub _file_child_bug {
my ($params) = @_;
my ($parent_bug, $template_vars, $template_suffix, $bug_data, $dep_comment, $dep_errors, $send_mail)
= @$params{qw(parent_bug template_vars template_suffix bug_data dep_comment dep_errors send_mail)};
my $old_error_mode = Bugzilla->error_mode;
Bugzilla->error_mode(ERROR_MODE_DIE);
my $new_bug;
eval {
my $comment;
my $full_template = "bug/create/comment-moz-project-review-$template_suffix.txt.tmpl";
Bugzilla->template->process($full_template, $template_vars, \$comment)
|| ThrowTemplateError(Bugzilla->template->error());
$bug_data->{'comment'} = $comment;
if ($new_bug = Bugzilla::Bug->create($bug_data)) {
my $set_all = {
dependson => { add => [ $new_bug->bug_id ] }
};
if (exists $tracker_cc{$template_suffix}) {
$set_all->{'cc'} = { add => $tracker_cc{$template_suffix} };
}
$parent_bug->set_all($set_all);
$parent_bug->update($parent_bug->creation_ts);
}
};
if ($@ || !($new_bug && $new_bug->{'bug_id'})) {
push(@$dep_comment, "Error creating $template_suffix review bug");
push(@$dep_errors, "$template_suffix : $@") if $@;
# Since we performed Bugzilla::Bug::create in an eval block, we
# need to manually rollback the commit as this is not done
# in Bugzilla::Error automatically for eval'ed code.
Bugzilla->dbh->bz_rollback_transaction();
}
else {
push(@$send_mail, $new_bug->id);
push(@$dep_comment, "Bug " . $new_bug->id . " - " . $new_bug->short_desc);
}
undef $@;
Bugzilla->error_mode($old_error_mode);
}
__PACKAGE__->NAME;
|
