1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
|
# -*- Mode: perl; indent-tabs-mode: nil -*-
#
# The contents of this file are subject to the Mozilla Public
# License Version 1.1 (the "License"); you may not use this file
# except in compliance with the License. You may obtain a copy of
# the License at http://www.mozilla.org/MPL/
#
# Software distributed under the License is distributed on an "AS
# IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
# implied. See the License for the specific language governing
# rights and limitations under the License.
#
# The Original Code is the Bugzilla SecureMail Extension
#
# The Initial Developer of the Original Code is the Mozilla Foundation.
# Portions created by Mozilla are Copyright (C) 2008 Mozilla Foundation.
# All Rights Reserved.
#
# Contributor(s): Max Kanat-Alexander <mkanat@bugzilla.org>
# Gervase Markham <gerv@gerv.net>
package Bugzilla::Extension::SecureMail;
use strict;
use base qw(Bugzilla::Extension);
use Bugzilla::Attachment;
use Bugzilla::Comment;
use Bugzilla::Group;
use Bugzilla::Object;
use Bugzilla::User;
use Bugzilla::Util qw(correct_urlbase trim trick_taint is_7bit_clean);
use Bugzilla::Error;
use Bugzilla::Mailer;
use Crypt::OpenPGP::Armour;
use Crypt::OpenPGP::KeyRing;
use Crypt::OpenPGP;
use Crypt::SMIME;
use Encode;
use HTML::Tree;
our $VERSION = '0.5';
use constant SECURE_NONE => 0;
use constant SECURE_BODY => 1;
use constant SECURE_ALL => 2;
##############################################################################
# Creating new columns
#
# secure_mail boolean in the 'groups' table - whether to send secure mail
# public_key text in the 'profiles' table - stores public key
##############################################################################
sub install_update_db {
my ($self, $args) = @_;
my $dbh = Bugzilla->dbh;
$dbh->bz_add_column('groups', 'secure_mail',
{TYPE => 'BOOLEAN', NOTNULL => 1, DEFAULT => 0});
$dbh->bz_add_column('profiles', 'public_key', { TYPE => 'LONGTEXT' });
}
##############################################################################
# Maintaining new columns
##############################################################################
BEGIN {
*Bugzilla::Group::secure_mail = \&_secure_mail;
}
sub _secure_mail { return $_[0]->{'secure_mail'}; }
# Make sure generic functions know about the additional fields in the user
# and group objects.
sub object_columns {
my ($self, $args) = @_;
my $class = $args->{'class'};
my $columns = $args->{'columns'};
if ($class->isa('Bugzilla::Group')) {
push(@$columns, 'secure_mail');
}
elsif ($class->isa('Bugzilla::User')) {
push(@$columns, 'public_key');
}
}
# Plug appropriate validators so we can check the validity of the two
# fields created by this extension, when new values are submitted.
sub object_validators {
my ($self, $args) = @_;
my %args = %{ $args };
my ($invocant, $validators) = @args{qw(class validators)};
if ($invocant->isa('Bugzilla::Group')) {
$validators->{'secure_mail'} = \&Bugzilla::Object::check_boolean;
}
elsif ($invocant->isa('Bugzilla::User')) {
$validators->{'public_key'} = sub {
my ($self, $value) = @_;
$value = trim($value) || '';
return $value if $value eq '';
if ($value =~ /PUBLIC KEY/) {
# PGP keys must be ASCII-armoured.
if (!Crypt::OpenPGP::Armour->unarmour($value)) {
ThrowUserError('securemail_invalid_key',
{ errstr => Crypt::OpenPGP::Armour->errstr });
}
}
elsif ($value =~ /BEGIN CERTIFICATE/) {
# S/MIME Keys must be in PEM format (Base64-encoded X.509)
#
# Crypt::SMIME seems not to like tainted values - it claims
# they aren't scalars!
trick_taint($value);
my $smime = Crypt::SMIME->new();
eval {
$smime->setPublicKey([$value]);
};
if ($@) {
ThrowUserError('securemail_invalid_key',
{ errstr => $@ });
}
}
else {
ThrowUserError('securemail_invalid_key');
}
return $value;
};
}
}
# When creating a 'group' object, set up the secure_mail field appropriately.
sub object_before_create {
my ($self, $args) = @_;
my $class = $args->{'class'};
my $params = $args->{'params'};
if ($class->isa('Bugzilla::Group')) {
$params->{secure_mail} = Bugzilla->cgi->param('secure_mail');
}
}
# On update, make sure the updating process knows about our new columns.
sub object_update_columns {
my ($self, $args) = @_;
my $object = $args->{'object'};
my $columns = $args->{'columns'};
if ($object->isa('Bugzilla::Group')) {
# This seems like a convenient moment to extract this value...
$object->set('secure_mail', Bugzilla->cgi->param('secure_mail'));
push(@$columns, 'secure_mail');
}
elsif ($object->isa('Bugzilla::User')) {
push(@$columns, 'public_key');
}
}
# Handle the setting and changing of the public key.
sub user_preferences {
my ($self, $args) = @_;
my $tab = $args->{'current_tab'};
my $save = $args->{'save_changes'};
my $handled = $args->{'handled'};
my $vars = $args->{'vars'};
my $params = Bugzilla->input_params;
return unless $tab eq 'securemail';
# Create a new user object so we don't mess with the main one, as we
# don't know where it's been...
my $user = new Bugzilla::User(Bugzilla->user->id);
if ($save) {
$user->set('public_key', $params->{'public_key'});
$user->update();
# Send user a test email
if ($user->{'public_key'}) {
_send_test_email($user);
$vars->{'test_email_sent'} = 1;
}
}
$vars->{'public_key'} = $user->{'public_key'};
# Set the 'handled' scalar reference to true so that the caller
# knows the panel name is valid and that an extension took care of it.
$$handled = 1;
}
sub template_before_process {
my ($self, $args) = @_;
my $file = $args->{'file'};
my $vars = $args->{'vars'};
# Bug dependency emails contain the subject of the dependent bug
# right before the diffs when a status has gone from open/closed
# or closed/open. We need to sanitize the subject of change.blocker
# similar to how we do referenced bugs
return unless
$file eq 'email/bugmail.html.tmpl'
|| $file eq 'email/bugmail.txt.tmpl';
if (defined $vars->{diffs}) {
foreach my $change (@{ $vars->{diffs} }) {
next if !defined $change->{blocker};
if (grep($_->secure_mail, @{ $change->{blocker}->groups_in })) {
$change->{blocker}->{short_desc} = "(Secure bug)";
}
}
}
}
sub _send_test_email {
my ($user) = @_;
my $template = Bugzilla->template_inner($user->settings->{'lang'}->{'value'});
my $vars = {
to_user => $user->email,
};
my $msg = "";
$template->process("account/email/securemail-test.txt.tmpl", $vars, \$msg)
|| ThrowTemplateError($template->error());
MessageToMTA($msg);
}
##############################################################################
# Encrypting the email
##############################################################################
sub mailer_before_send {
my ($self, $args) = @_;
my $email = $args->{'email'};
my $body = $email->body;
# Decide whether to make secure.
# This is a bit of a hack; it would be nice if it were more clear
# what sort a particular email is.
my $is_bugmail = $email->header('X-Bugzilla-Status') ||
$email->header('X-Bugzilla-Type') eq 'request';
my $is_passwordmail = !$is_bugmail && ($body =~ /cfmpw.*cxlpw/s);
my $is_test_email = $email->header('X-Bugzilla-Type') =~ /securemail-test/ ? 1 : 0;
my $is_whine_email = $email->header('X-Bugzilla-Type') eq 'whine' ? 1 : 0;
if ($is_bugmail || $is_passwordmail || $is_test_email || $is_whine_email) {
# Convert the email's To address into a User object
my $login = $email->header('To');
my $emailsuffix = Bugzilla->params->{'emailsuffix'};
$login =~ s/$emailsuffix$//;
my $user = new Bugzilla::User({ name => $login });
# Default to secure. (Of course, this means if this extension has a
# bug, lots of people are going to get bugmail falsely claiming their
# bugs are secure and they need to add a key...)
my $make_secure = SECURE_ALL;
if ($is_bugmail) {
# This is also a bit of a hack, but there's no header with the
# bug ID in. So we take the first number in the subject.
my ($bug_id) = ($email->header('Subject') =~ /\[\D+(\d+)\]/);
my $bug = new Bugzilla::Bug($bug_id);
if (!_should_secure_bug($bug)) {
$make_secure = SECURE_NONE;
}
# If the insider group has securemail enabled..
my $insider_group = Bugzilla::Group->new({ name => Bugzilla->params->{'insidergroup'} });
if ($insider_group
&& $insider_group->secure_mail
&& $make_secure == SECURE_NONE)
{
my $comment_is_private = Bugzilla->dbh->selectcol_arrayref(
"SELECT isprivate FROM longdescs WHERE bug_id=? ORDER BY bug_when",
undef, $bug_id);
# Encrypt if there are private comments on an otherwise public bug
while ($body =~ /[\r\n]--- Comment #(\d+)/g) {
my $comment_number = $1;
if ($comment_number && $comment_is_private->[$comment_number]) {
$make_secure = SECURE_BODY;
last;
}
}
# Encrypt if updating a private attachment without a comment
if ($email->header('X-Bugzilla-Changed-Fields')
&& $email->header('X-Bugzilla-Changed-Fields') =~ /Attachment #(\d+)/)
{
my $attachment = Bugzilla::Attachment->new($1);
if ($attachment && $attachment->isprivate) {
$make_secure = SECURE_BODY;
}
}
}
}
elsif ($is_passwordmail) {
# Mail is made unsecure only if the user does not have a public
# key and is not in any security groups. So specifying a public
# key OR being in a security group means the mail is kept secure
# (but, as noted above, the check is the other way around because
# we default to secure).
if ($user &&
!$user->{'public_key'} &&
!grep($_->secure_mail, @{ $user->groups }))
{
$make_secure = SECURE_NONE;
}
}
elsif ($is_whine_email) {
# When a whine email has one or more secure bugs in the body, then
# encrypt the entire email body. Subject can be left alone as it
# comes from the whine settings.
$make_secure = _should_secure_whine($email) ? SECURE_BODY : SECURE_NONE;
}
# If finding the user fails for some reason, but we determine we
# should be encrypting, we want to make the mail safe. An empty key
# does that.
my $public_key = $user ? $user->{'public_key'} : '';
# Check if the new bugmail prefix should be added to the subject.
my $add_new = ($email->header('X-Bugzilla-Type') eq 'new' &&
$user &&
$user->settings->{'bugmail_new_prefix'}->{'value'} eq 'on') ? 1 : 0;
if ($make_secure == SECURE_NONE) {
# Filter the bug_links in HTML email in case the bugs the links
# point are "secured" bugs and the user may not be able to see
# the summaries.
_filter_bug_links($email);
}
else {
_make_secure($email, $public_key, $is_bugmail && $make_secure == SECURE_ALL, $add_new);
}
}
}
# Custom hook for bugzilla.mozilla.org (see bug 752400)
sub bugmail_referenced_bugs {
my ($self, $args) = @_;
# Sanitise subjects of referenced bugs.
my $referenced_bugs = $args->{'referenced_bugs'};
# No need to sanitise subjects if the entire email will be secured.
return if _should_secure_bug($args->{'updated_bug'});
# Replace the subject if required
foreach my $ref (@$referenced_bugs) {
if (grep($_->secure_mail, @{ $ref->{'bug'}->groups_in })) {
$ref->{'short_desc'} = "(Secure bug)";
}
}
}
sub _should_secure_bug {
my ($bug) = @_;
# If there's a problem with the bug, err on the side of caution and mark it
# as secure.
return
!$bug
|| $bug->{'error'}
|| grep($_->secure_mail, @{ $bug->groups_in });
}
sub _should_secure_whine {
my ($email) = @_;
my $should_secure = 0;
$email->walk_parts(sub {
my $part = shift;
my $content_type = $part->content_type;
return if !$content_type || $content_type !~ /^text\/plain/;
my $body = $part->body;
my @bugids = $body =~ /Bug (\d+):/g;
foreach my $id (@bugids) {
$id = trim($id);
next if !$id;
my $bug = new Bugzilla::Bug($id);
if ($bug && _should_secure_bug($bug)) {
$should_secure = 1;
last;
}
}
});
return $should_secure ? 1 : 0;
}
sub _make_secure {
my ($email, $key, $sanitise_subject, $add_new) = @_;
my $subject = $email->header('Subject');
my ($bug_id) = $subject =~ /\[\D+(\d+)\]/;
my $key_type = 0;
if ($key && $key =~ /PUBLIC KEY/) {
$key_type = 'PGP';
}
elsif ($key && $key =~ /BEGIN CERTIFICATE/) {
$key_type = 'S/MIME';
}
if ($key_type eq 'PGP') {
##################
# PGP Encryption #
##################
my $pubring = new Crypt::OpenPGP::KeyRing(Data => $key);
my $pgp = new Crypt::OpenPGP(PubRing => $pubring);
if (scalar $email->parts > 1) {
my $old_boundary = $email->{ct}{attributes}{boundary};
my $to_encrypt = "Content-Type: " . $email->content_type . "\n\n";
# We need to do some fix up of each part for proper encoding and then
# stringify all parts for encrypting. We have to retain the old
# boundaries as well so that the email client can reconstruct the
# original message properly.
$email->walk_parts(\&_fix_part);
$email->walk_parts(sub {
my ($part) = @_;
if ($sanitise_subject) {
_insert_subject($part, $subject);
}
return if $part->parts > 1; # Top-level
$to_encrypt .= "--$old_boundary\n" . $part->as_string . "\n";
});
$to_encrypt .= "--$old_boundary--";
# Now create the new properly formatted PGP parts containing the
# encrypted original message
my @new_parts = (
Email::MIME->create(
attributes => {
content_type => 'application/pgp-encrypted',
encoding => '7bit',
},
body => "Version: 1\n",
),
Email::MIME->create(
attributes => {
content_type => 'application/octet-stream',
filename => 'encrypted.asc',
disposition => 'inline',
encoding => '7bit',
},
body => _pgp_encrypt($pgp, $to_encrypt)
),
);
$email->parts_set(\@new_parts);
my $new_boundary = $email->{ct}{attributes}{boundary};
# Redo the old content type header with the new boundaries
# and other information needed for PGP
$email->header_set("Content-Type",
"multipart/encrypted; " .
"protocol=\"application/pgp-encrypted\"; " .
"boundary=\"$new_boundary\"");
}
else {
_fix_part($email);
if ($sanitise_subject) {
_insert_subject($email, $subject);
}
$email->body_set(_pgp_encrypt($pgp, $email->body));
}
}
elsif ($key_type eq 'S/MIME') {
#####################
# S/MIME Encryption #
#####################
$email->walk_parts(\&_fix_part);
if ($sanitise_subject) {
$email->walk_parts(sub { _insert_subject($_[0], $subject) });
}
my $smime = Crypt::SMIME->new();
my $encrypted;
eval {
$smime->setPublicKey([$key]);
$encrypted = $smime->encrypt($email->as_string());
};
if (!$@) {
# We can't replace the Email::MIME object, so we have to swap
# out its component parts.
my $enc_obj = new Email::MIME($encrypted);
$email->header_obj_set($enc_obj->header_obj());
$email->parts_set([]);
$email->body_set($enc_obj->body());
$email->content_type_set('application/pkcs7-mime');
$email->charset_set('UTF-8') if Bugzilla->params->{'utf8'};
}
else {
$email->body_set('Error during Encryption: ' . $@);
}
}
else {
# No encryption key provided; send a generic, safe email.
my $template = Bugzilla->template;
my $message;
my $vars = {
'urlbase' => correct_urlbase(),
'bug_id' => $bug_id,
'maintainer' => Bugzilla->params->{'maintainer'}
};
$template->process('account/email/encryption-required.txt.tmpl',
$vars, \$message)
|| ThrowTemplateError($template->error());
$email->parts_set([]);
$email->content_type_set('text/plain');
$email->body_set($message);
}
if ($sanitise_subject) {
# This is designed to still work if the admin changes the word
# 'bug' to something else. However, it could break if they change
# the format of the subject line in another way.
my $new = $add_new ? ' New:' : '';
$subject =~ s/($bug_id\])\s+(.*)$/$1$new (Secure bug $bug_id updated)/;
$email->header_set('Subject', $subject);
}
}
sub _pgp_encrypt {
my ($pgp, $text) = @_;
# "@" matches every key in the public key ring, which is fine,
# because there's only one key in our keyring.
#
# We use the CAST5 cipher because the Rijndael (AES) module doesn't
# like us for some reason I don't have time to debug fully.
# ("key must be an untainted string scalar")
my $encrypted = $pgp->encrypt(Data => $text,
Recipients => "@",
Cipher => 'CAST5',
Armour => 1);
if (!defined $encrypted) {
return 'Error during Encryption: ' . $pgp->errstr;
}
return $encrypted;
}
# Insert the subject into the part's body, as the subject of the message will
# be sanitised.
# XXX this incorrectly assumes all parts of the message are the body
# we should only alter parts who's parent is multipart/alternative
sub _insert_subject {
my ($part, $subject) = @_;
my $content_type = $part->content_type or return;
if ($content_type =~ /^text\/plain/) {
if (!is_7bit_clean($subject)) {
$part->encoding_set('quoted-printable');
}
$part->body_str_set("Subject: $subject\015\012\015\012" . $part->body_str);
}
elsif ($content_type =~ /^text\/html/) {
my $tree = HTML::Tree->new->parse_content($part->body_str);
my $body = $tree->look_down(qw(_tag body));
$body->unshift_content(['div', "Subject: $subject"], ['br']);
_set_body_from_tree($part, $tree);
}
}
# Copied from Bugzilla/Mailer as this extension runs before
# this code there and Mailer.pm will no longer see the original
# message.
sub _fix_part {
my ($part) = @_;
return if $part->parts > 1; # Top-level
my $content_type = $part->content_type || '';
$content_type =~ /charset=['"](.+)['"]/;
# If no charset is defined or is the default us-ascii,
# then we encode the email to UTF-8 if Bugzilla has utf8 enabled.
# XXX - This is a hack to workaround bug 723944.
if (!$1 || $1 eq 'us-ascii') {
my $body = $part->body;
if (Bugzilla->params->{'utf8'}) {
$part->charset_set('UTF-8');
# encoding_set works only with bytes, not with utf8 strings.
my $raw = $part->body_raw;
if (utf8::is_utf8($raw)) {
utf8::encode($raw);
$part->body_set($raw);
}
}
$part->encoding_set('quoted-printable') if !is_7bit_clean($body);
}
}
sub _filter_bug_links {
my ($email) = @_;
$email->walk_parts(sub {
my $part = shift;
my $content_type = $part->content_type;
return if !$content_type || $content_type !~ /text\/html/;
my $tree = HTML::Tree->new->parse_content($part->body);
my @links = $tree->look_down( _tag => q{a}, class => qr/bz_bug_link/ );
my $updated = 0;
foreach my $link (@links) {
my $href = $link->attr('href');
my ($bug_id) = $href =~ /\Qshow_bug.cgi?id=\E(\d+)/;
my $bug = new Bugzilla::Bug($bug_id);
if ($bug && _should_secure_bug($bug)) {
$link->attr('title', '(secure bug)');
$link->attr('class', 'bz_bug_link');
$updated = 1;
}
}
if ($updated) {
_set_body_from_tree($part, $tree);
}
});
}
sub _set_body_from_tree {
my ($part, $tree) = @_;
$part->body_set($tree->as_HTML);
$part->charset_set('UTF-8') if Bugzilla->params->{'utf8'};
$part->encoding_set('quoted-printable');
}
__PACKAGE__->NAME;
|