aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLars Hjemli <hjemli@gmail.com>2007-10-27 13:50:18 +0200
committerLars Hjemli <hjemli@gmail.com>2007-10-27 13:55:12 +0200
commitc61360fea0357672d2ab84a2c5a41ae1569f5d8a (patch)
treec0d55917537b1cbc8237ee63e3a1252abbdded40
parent13d2b0b25cf19de03c7cdcf8bb708be1168aeda7 (diff)
downloadcgit-c61360fea0357672d2ab84a2c5a41ae1569f5d8a.tar.gz
cgit-c61360fea0357672d2ab84a2c5a41ae1569f5d8a.tar.xz
cgit_parse_commit(): Add missing call to xstrdup()
It's rather silly to point into random memory-locations. Also, remove a call to strdup() used on a literal char *. Signed-off-by: Lars Hjemli <hjemli@gmail.com>
-rw-r--r--parsing.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/parsing.c b/parsing.c
index ddbafd5..30e7648 100644
--- a/parsing.c
+++ b/parsing.c
@@ -242,14 +242,14 @@ struct commitinfo *cgit_parse_commit(struct commit *commit)
t = strchr(p, '\n');
if (t) {
if (*t == '\0')
- ret->subject = strdup("** empty **");
+ ret->subject = "** empty **";
else
ret->subject = substr(p, t);
p = t + 1;
while (*p == '\n')
p = strchr(p, '\n') + 1;
- ret->msg = p;
+ ret->msg = xstrdup(p);
} else
ret->subject = substr(p, p+strlen(p));