diff options
| author | Jason A. Donenfeld <Jason@zx2c4.com> | 2013-05-25 19:25:56 +0200 |
|---|---|---|
| committer | Jason A. Donenfeld <Jason@zx2c4.com> | 2013-05-25 20:33:28 +0200 |
| commit | 03eb76dfad2887127581f5f1b4e2edbe8c4ca5fe (patch) | |
| tree | fb5961f5c5f99d0b3dda25632a74036f10b8dda9 /cgit.c | |
| parent | 5a4156ef951162d669e7170b440fad6e4c9e306f (diff) | |
| download | cgit-03eb76dfad2887127581f5f1b4e2edbe8c4ca5fe.tar.gz cgit-03eb76dfad2887127581f5f1b4e2edbe8c4ca5fe.tar.xz | |
cgit.c: Do not reset HOME after unsetting it.
The number of odd cases in which git will try to read config is far too
great to keep putting a bandaid over each one, so we'll just unset it.
If it turns out that scripts really liked to know about $HOME, we can
always reset it in the filter forks.
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Diffstat (limited to 'cgit.c')
| -rw-r--r-- | cgit.c | 13 |
1 files changed, 0 insertions, 13 deletions
@@ -471,8 +471,6 @@ static char *guess_defbranch(void) static int prepare_repo_cmd(struct cgit_context *ctx) { - char *user_home; - char *xdg_home; unsigned char sha1[20]; int nongit = 0; int rc; @@ -483,11 +481,6 @@ static int prepare_repo_cmd(struct cgit_context *ctx) /* Do not look in /etc/ for gitconfig and gitattributes. */ setenv("GIT_CONFIG_NOSYSTEM", "1", 1); setenv("GIT_ATTR_NOSYSTEM", "1", 1); - - /* We unset HOME and XDG_CONFIG_HOME before calling the git setup function - * so that we don't make unneccessary filesystem accesses. */ - user_home = getenv("HOME"); - xdg_home = getenv("XDG_CONFIG_HOME"); unsetenv("HOME"); unsetenv("XDG_CONFIG_HOME"); @@ -497,12 +490,6 @@ static int prepare_repo_cmd(struct cgit_context *ctx) setup_git_directory_gently(&nongit); init_display_notes(NULL); - /* We restore the unset variables afterward. */ - if (user_home) - setenv("HOME", user_home, 1); - if (xdg_home) - setenv("XDG_CONFIG_HOME", xdg_home, 1); - if (nongit) { const char *name = ctx->repo->name; rc = errno; |