diff options
| author | John Keeping <john@keeping.me.uk> | 2015-08-14 13:47:13 +0200 |
|---|---|---|
| committer | Jason A. Donenfeld <Jason@zx2c4.com> | 2015-08-14 15:46:51 +0200 |
| commit | c53a15c77a6763b4d6fefb033923ba7493b884a2 (patch) | |
| tree | f4fe41b929428f3c13b283a4ad57b36f90c36add /ui-commit.c | |
| parent | 51d9176e4bb5c619481355c6b895c6dec30c4f82 (diff) | |
| download | cgit-c53a15c77a6763b4d6fefb033923ba7493b884a2.tar.gz cgit-c53a15c77a6763b4d6fefb033923ba7493b884a2.tar.xz | |
commit: move layout into page function
This allows us to return a proper HTTP status code when an object is not
found by switching from cgit_print_error() to cgit_print_error_page().
Signed-off-by: John Keeping <john@keeping.me.uk>
Diffstat (limited to 'ui-commit.c')
| -rw-r--r-- | ui-commit.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/ui-commit.c b/ui-commit.c index d5a888d..2bca7a0 100644 --- a/ui-commit.c +++ b/ui-commit.c @@ -27,12 +27,14 @@ void cgit_print_commit(char *hex, const char *prefix) hex = ctx.qry.head; if (get_sha1(hex, sha1)) { - cgit_print_error("Bad object id: %s", hex); + cgit_print_error_page(400, "Bad request", + "Bad object id: %s", hex); return; } commit = lookup_commit_reference(sha1); if (!commit) { - cgit_print_error("Bad commit reference: %s", hex); + cgit_print_error_page(404, "Not found", + "Bad commit reference: %s", hex); return; } info = cgit_parse_commit(commit); @@ -41,6 +43,7 @@ void cgit_print_commit(char *hex, const char *prefix) load_ref_decorations(DECORATE_FULL_REFS); + cgit_print_layout_start(); cgit_print_diff_ctrls(); html("<table summary='commit info' class='commit-info'>\n"); html("<tr><th>author</th><td>"); @@ -139,4 +142,5 @@ void cgit_print_commit(char *hex, const char *prefix) } strbuf_release(¬es); cgit_free_commitinfo(info); + cgit_print_layout_end(); } |