summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEric Bélanger <snowmaniscool@gmail.com>2011-06-24 01:45:39 +0200
committerPierre Schmitz <pierre@archlinux.de>2011-07-25 17:53:08 +0200
commit9a29f624f124b9e33e530a7fd4d7543f68977c2f (patch)
treec4d231999b14ada8908db2904d1751058a3db07f
parent3040951ca09337bcfcc138f631d1a842bc8ea21f (diff)
downloaddevtools-9a29f624f124b9e33e530a7fd4d7543f68977c2f.tar.gz
devtools-9a29f624f124b9e33e530a7fd4d7543f68977c2f.tar.xz
checkpkg: Clean up soname check output
A missing quote in a grep command was giving out false matches. By moving the objdump command in the same echo statement as the filename, we ensure that every library name are displayed on a line of their own in case they don't have a SONAME defined in their headers. That is the case for some plugin libraries. Signed-off-by: Eric Bélanger <snowmaniscool@gmail.com> Signed-off-by: Pierre Schmitz <pierre@archlinux.de>
-rwxr-xr-xcheckpkg5
1 files changed, 2 insertions, 3 deletions
diff --git a/checkpkg b/checkpkg
index f8867bd..c349795 100755
--- a/checkpkg
+++ b/checkpkg
@@ -87,9 +87,8 @@ for _pkgname in ${pkgname[@]}; do
mkdir -p pkg
cd pkg
bsdtar xf ../"$pkgfile" > /dev/null
- for i in $(diff ../filelist-$_pkgname-old ../filelist-$_pkgname | grep \> | grep \.so | awk '{print $2}'); do
- echo -n "${i}: "
- objdump -p $i | grep SONAME
+ for i in $(diff ../filelist-$_pkgname-old ../filelist-$_pkgname | grep \> | grep '\.so' | awk '{print $2}'); do
+ echo "${i}: " "$(objdump -p $i | grep SONAME)"
done
cd ..
else