diff options
| author | Joel Teichroeb <joel@teichroeb.net> | 2014-05-04 18:31:53 +0200 |
|---|---|---|
| committer | Pierre Schmitz <pierre@archlinux.de> | 2014-05-10 08:00:56 +0200 |
| commit | fdd079f3d542dbce6898512298b4271eb9e7d0d9 (patch) | |
| tree | 89be6b28e77ed2a9d4b031b9c0bb2f7240f4f0e2 | |
| parent | 9f7ba3d40791ca81ebd47e3278f02d4a61e38179 (diff) | |
| download | devtools-fdd079f3d542dbce6898512298b4271eb9e7d0d9.tar.gz devtools-fdd079f3d542dbce6898512298b4271eb9e7d0d9.tar.xz | |
Remove broken unknown arguments check and fix usage
If getopts comes across an unknown argument, $arg it set to '?' and
$OPTARG is unset. Therefore the getopts line detecting unknown arguments
doesn't work. Arguments to pass to makepkg are already handled by
passing all the aguments after the end-of-options marker (--), but this
wasn't documented in the usage text.
Signed-off-by: Pierre Schmitz <pierre@archlinux.de>
| -rw-r--r-- | makechrootpkg.in | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/makechrootpkg.in b/makechrootpkg.in index d03b703..9db0ddd 100644 --- a/makechrootpkg.in +++ b/makechrootpkg.in @@ -35,8 +35,8 @@ src_owner=${SUDO_USER:-$USER} usage() { echo "Usage: ${0##*/} [options] -r <chrootdir> [--] [makepkg args]" echo ' Run this script in a PKGBUILD dir to build a package inside a' - echo ' clean chroot. All unrecognized arguments passed to this script' - echo ' will be passed to makepkg.' + echo ' clean chroot. Arguments passed to this script after the' + echo ' end-of-options marker (--) will be passed to makepkg.' echo '' echo ' The chroot dir consists of the following directories:' echo ' <chrootdir>/{root, copy} but only "root" is required' @@ -78,7 +78,6 @@ while getopts 'hcur:I:l:nTD:d:' arg; do l) copy="$OPTARG" ;; n) run_namcap=true; makepkg_args="$makepkg_args -i" ;; T) temp_chroot=true; copy+="-$$" ;; - *) makepkg_args="$makepkg_args -$arg $OPTARG" ;; esac done |