diff options
| author | Eli Schwartz <eschwartz@archlinux.org> | 2017-09-03 09:53:40 +0200 |
|---|---|---|
| committer | Bartłomiej Piotrowski <bpiotrowski@archlinux.org> | 2018-01-21 14:16:10 +0100 |
| commit | 48b2f8dcc49d88e60bd9e4ee97c92fea8ac90721 (patch) | |
| tree | bcd8e62f82a506561d73f1c0b41932e2cc392901 /commitpkg.in | |
| parent | 3b725b58434b92e93ff90164fae8d76c4761706a (diff) | |
| download | devtools-48b2f8dcc49d88e60bd9e4ee97c92fea8ac90721.tar.gz devtools-48b2f8dcc49d88e60bd9e4ee97c92fea8ac90721.tar.xz | |
makechrootpkg: Fix anti-pattern when checking for enabled features
Don't use error-prone logic e.g.
foo=true; if $foo ...
This completely fails to act as expected when the variable is unset
because of unrelated bugs.
While this merely causes the default behavior to be "false" rather than
"true" in such cases, it is better to fail to enable explicitly
requested behavior (which will be noticed by the user) than to simply
upgrade to this behavior for free (which may not seem to have any
obvious cause).
Signed-off-by: Eli Schwartz <eschwartz@archlinux.org>
Diffstat (limited to 'commitpkg.in')
0 files changed, 0 insertions, 0 deletions