From 25aae4ecfea68b6ef3f5cd6d3c0c298df66bd14b Mon Sep 17 00:00:00 2001 From: Lukas Fleischer Date: Wed, 10 Aug 2011 15:17:59 +0200 Subject: commitpkg: Avoid unnecessary use of grep(1) Use bash patterns instead of using grep(1) to check if a source file contains the string "://". Signed-off-by: Lukas Fleischer Signed-off-by: Pierre Schmitz --- commitpkg | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/commitpkg b/commitpkg index 999c35f..07c28d4 100755 --- a/commitpkg +++ b/commitpkg @@ -79,9 +79,9 @@ esac # check if all local source files are under version control for s in "${source[@]}"; do - echo "$s" | grep -Fvq '://' && \ - svn status "$s" | grep -q '^\?' && \ - abort "$s is not under version control" + if [[ $s != *://* ]] && svn status "$s" | grep -q '^\?'; then + abort "$s is not under version control" + fi done # check if changelog and install files are under version control -- cgit v1.2.3-24-g4f1b