From 7020d2351bb3468d6b0d32ad5908b9b475ae274c Mon Sep 17 00:00:00 2001 From: Lukas Fleischer Date: Wed, 24 Aug 2011 10:18:27 +0200 Subject: checkpkg: Use read builtin to get new ".so" files The read shell builtin is the proper way to read single lines. Also, simplify grep(1) and awk(1) invocations and use a single awk(1) expression, that supports extracting file names with spaces, instead. Signed-off-by: Lukas Fleischer Signed-off-by: Pierre Schmitz --- checkpkg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/checkpkg b/checkpkg index f408267..2f442c9 100755 --- a/checkpkg +++ b/checkpkg @@ -81,7 +81,7 @@ for _pkgname in "${pkgname[@]}"; do mkdir -p pkg cd pkg bsdtar xf ../"$pkgfile" > /dev/null - for i in $(diff "../filelist-$_pkgname-old" "../filelist-$_pkgname" | grep \> | grep '\.so' | awk '{print $2}'); do + diff "../filelist-$_pkgname-old" "../filelist-$_pkgname" | awk '/>.*\.so/{$1 = ""; print $0}' | while read i; do echo "${i}: " "$(objdump -p "$i" | grep SONAME)" done cd .. -- cgit v1.2.3-24-g4f1b