Remove previously deprecated Date Helper function standard_date()

5 files changed, 5 insertions, 182 deletions

diff --git a/system/helpers/date_helper.php b/system/helpers/date_helper.php
index 0606a4562..1f8e319ca 100644
--- a/system/helpers/date_helper.php
+++ b/system/helpers/date_helper.php
@@ -122,46 +122,6 @@ if ( ! function_exists('mdate'))
 
 // ------------------------------------------------------------------------
 
-if ( ! function_exists('standard_date'))
-{
-	/**
-	 * Standard Date
-	 *
-	 * Returns a date formatted according to the submitted standard.
-	 *
-	 * As of PHP 5.2, the DateTime extension provides constants that
-	 * serve for the exact same purpose and are used with date().
-	 *
-	 * @todo	Remove in version 3.1+.
-	 * @deprecated	3.0.0	Use PHP's native date() instead.
-	 * @link	http://www.php.net/manual/en/class.datetime.php#datetime.constants.types
-	 *
-	 * @example	date(DATE_RFC822, now()); // default
-	 * @example	date(DATE_W3C, $time); // a different format and time
-	 *
-	 * @param	string	$fmt = 'DATE_RFC822'	the chosen format
-	 * @param	int	$time = NULL		Unix timestamp
-	 * @return	string
-	 */
-	function standard_date($fmt = 'DATE_RFC822', $time = NULL)
-	{
-		if (empty($time))
-		{
-			$time = now();
-		}
-
-		// Procedural style pre-defined constants from the DateTime extension
-		if (strpos($fmt, 'DATE_') !== 0 OR defined($fmt) === FALSE)
-		{
-			return FALSE;
-		}
-
-		return date(constant($fmt), $time);
-	}
-}
-
-// ------------------------------------------------------------------------
-
 if ( ! function_exists('timespan'))
 {
 	/**
diff --git a/tests/codeigniter/helpers/date_helper_test.php b/tests/codeigniter/helpers/date_helper_test.php
index 8a3502280..00139de5c 100644
--- a/tests/codeigniter/helpers/date_helper_test.php
+++ b/tests/codeigniter/helpers/date_helper_test.php
@@ -73,106 +73,6 @@ class Date_helper_test extends CI_TestCase {
 
 	// ------------------------------------------------------------------------
 
-	public function test_standard_date_rfc822()
-	{
-		$this->assertEquals(
-			date(DATE_RFC822, $this->time),
-			standard_date('DATE_RFC822', $this->time)
-		);
-	}
-
-	// ------------------------------------------------------------------------
-
-	public function test_standard_date_atom()
-	{
-		$this->assertEquals(
-			date(DATE_ATOM, $this->time),
-			standard_date('DATE_ATOM', $this->time)
-		);
-	}
-
-	// ------------------------------------------------------------------------
-
-	public function test_standard_date_cookie()
-	{
-		$this->assertEquals(
-			date(DATE_COOKIE, $this->time),
-			standard_date('DATE_COOKIE', $this->time)
-		);
-	}
-
-	// ------------------------------------------------------------------------
-
-	public function test_standard_date_iso8601()
-	{
-		$this->assertEquals(
-			date(DATE_ISO8601, $this->time),
-			standard_date('DATE_ISO8601', $this->time)
-		);
-	}
-
-	// ------------------------------------------------------------------------
-
-	public function test_standard_date_rfc850()
-	{
-		$this->assertEquals(
-			date(DATE_RFC850, $this->time),
-			standard_date('DATE_RFC850', $this->time)
-		);
-	}
-
-	// ------------------------------------------------------------------------
-
-	public function test_standard_date_rfc1036()
-	{
-		$this->assertEquals(
-			date(DATE_RFC1036, $this->time),
-			standard_date('DATE_RFC1036', $this->time)
-		);
-	}
-
-	// ------------------------------------------------------------------------
-
-	public function test_standard_date_rfc1123()
-	{
-		$this->assertEquals(
-			date(DATE_RFC1123, $this->time),
-			standard_date('DATE_RFC1123', $this->time)
-		);
-	}
-
-	// ------------------------------------------------------------------------
-
-	public function test_standard_date_rfc2822()
-	{
-		$this->assertEquals(
-			date(DATE_RFC2822, $this->time),
-			standard_date('DATE_RFC2822', $this->time)
-		);
-	}
-
-	// ------------------------------------------------------------------------
-
-	public function test_standard_date_rss()
-	{
-		$this->assertEquals(
-			date(DATE_RSS, $this->time),
-			standard_date('DATE_RSS', $this->time)
-		);
-	}
-
-	// ------------------------------------------------------------------------
-
-	public function test_standard_date_w3c()
-	{
-		$this->assertEquals(
-			date(DATE_W3C, $this->time),
-			standard_date('DATE_W3C', $this->time)
-		);
-	}
-
-	// ------------------------------------------------------------------------
-
 	public function test_timespan()
 	{
 		$this->ci_vfs_clone('system/language/english/date_lang.php');
diff --git a/user_guide_src/source/changelog.rst b/user_guide_src/source/changelog.rst
index d109c3b46..62c1ef0e1 100644
--- a/user_guide_src/source/changelog.rst
+++ b/user_guide_src/source/changelog.rst
@@ -13,6 +13,7 @@ Release Date: Not Released
    -  Removed previously deprecated :doc:`Input Library <libraries/input>` method ``is_cli_request()`` (use :php:func:`is_cli()` instead).
    -  Removed previously deprecated :doc:`Routing Class <general/routing>` methods ``fetch_directory()``, ``fetch_class()`` and ``fetch_method()`` (use the respective class properties instead).
    -  Removed previously deprecated :doc:`Config Library <libraries/config>` method ``system_url()`` (encourages insecure practices).
+   -  Removed previously deprecated :doc:`Date Helper <helpers/date_helper>` function ``standard_date()`` (use PHP's native ``date()`` instead).
    -  Removed previously deprecated *Email Helper* (had only two functions, aliases for PHP's native ``filter_var()`` and ``mail()``).
 
 -  Libraries
@@ -1115,7 +1116,7 @@ Bug fixes for 3.0
 -  Fixed a bug (#79) - :doc:`Form Validation Library <libraries/form_validation>` didn't properly validate array fields that use associative keys or have custom indexes.
 -  Fixed a bug (#427) - :doc:`Form Validation Library <libraries/form_validation>` method ``strip_image_tags()`` was an alias to a non-existent method.
 -  Fixed a bug (#1545) - :doc:`Query Builder <database/query_builder>` method ``limit()`` wasn't executed properly under Oracle.
--  Fixed a bug (#1551) - :doc:`Date Helper <helpers/date_helper>` function :php:func:`standard_date()` didn't properly format *W3C* and *ATOM* standard dates.
+-  Fixed a bug (#1551) - :doc:`Date Helper <helpers/date_helper>` function ``standard_date()`` didn't properly format *W3C* and *ATOM* standard dates.
 -  Fixed a bug where :doc:`Query Builder <database/query_builder>` method ``join()`` escaped literal values as if they were fields.
 -  Fixed a bug (#135) - PHP Error logging was impossible without the errors being displayed.
 -  Fixed a bug (#1613) - :doc:`Form Helper <helpers/form_helper>` functions :php:func:`form_multiselect()`, :php:func:`form_dropdown()` didn't properly handle empty array option groups.
@@ -3096,8 +3097,7 @@ Release Date: October 30, 2006
 -  Added :doc:`Download Helper <./helpers/download_helper>`.
 -  Added :doc:`simple_query() <./database/queries>` function to the
    database classes
--  Added :doc:`standard_date() <./helpers/date_helper>` function to
-   the Date Helper.
+-  Added ``standard_date()`` function function to the :doc:`Date Helper <helpers/date_helper>`.
 -  Added :doc:`$query->free_result() <./database/results>` to database
    class.
 -  Added :doc:`$query->list_fields() <./database/metadata>` function to
diff --git a/user_guide_src/source/helpers/date_helper.rst b/user_guide_src/source/helpers/date_helper.rst
index 600a07574..909528855 100644
--- a/user_guide_src/source/helpers/date_helper.rst
+++ b/user_guide_src/source/helpers/date_helper.rst
@@ -67,45 +67,6 @@ The following functions are available:
 	If a timestamp is not included in the second parameter the current time
 	will be used.
 
-.. php:function:: standard_date([$fmt = 'DATE_RFC822'[, $time = NULL]])
-
-	:param	string	$fmt: Date format
-	:param	int	$time: UNIX timestamp
-	:returns:	Formatted date or FALSE on invalid format
-	:rtype:	string
-
-	Lets you generate a date string in one of several standardized formats.
-
-	Example::
-
-		$format = 'DATE_RFC822';
-		$time = time();
-		echo standard_date($format, $time);
-
-	.. note:: This function is DEPRECATED. Use the native ``date()`` combined with
-		`DateTime's format constants
-		<https://secure.php.net/manual/en/class.datetime.php#datetime.constants.types>`_
-		instead::
-
-			echo date(DATE_RFC822, time());
-
-	**Supported formats:**
-
-	===============	=======================	======================================
-	Constant        Description             Example
-	===============	=======================	======================================
-	DATE_ATOM       Atom                    2005-08-15T16:13:03+0000
-	DATE_COOKIE     HTTP Cookies            Sun, 14 Aug 2005 16:13:03 UTC
-	DATE_ISO8601    ISO-8601                2005-08-14T16:13:03+00:00
-	DATE_RFC822     RFC 822                 Sun, 14 Aug 05 16:13:03 UTC
-	DATE_RFC850     RFC 850                 Sunday, 14-Aug-05 16:13:03 UTC
-	DATE_RFC1036    RFC 1036                Sunday, 14-Aug-05 16:13:03 UTC
-	DATE_RFC1123    RFC 1123                Sun, 14 Aug 2005 16:13:03 UTC
-	DATE_RFC2822    RFC 2822                Sun, 14 Aug 2005 16:13:03 +0000
-	DATE_RSS        RSS                     Sun, 14 Aug 2005 16:13:03 UTC
-	DATE_W3C        W3C                     2005-08-14T16:13:03+0000
-	===============	=======================	======================================
-
 .. php:function:: local_to_gmt([$time = ''])
 
 	:param	int	$time: UNIX timestamp
diff --git a/user_guide_src/source/installation/upgrade_320.rst b/user_guide_src/source/installation/upgrade_320.rst
index 51b2a3693..d6602e825 100644
--- a/user_guide_src/source/installation/upgrade_320.rst
+++ b/user_guide_src/source/installation/upgrade_320.rst
@@ -137,6 +137,8 @@ version 3.0.0, that have been removed in 3.2.0:
 - ``CI_Router::fetch_method()`` (use ``CI_Router::$method`` instead)
 - ``CI_Config::system_url()`` (encourages insecure practices)
 
+- ``standard_date()`` :doc:`Date Helper <../helpers/date_helper>` function (use ``date()`` instead)
+
 - The entire *Email Helper*, which only had two functions:
 
    - ``valid_email()`` (use ``filter_var($email, FILTER_VALIDATE_EMAIL)`` instead)