diff options
| author | Dimitar <dimitar@bukisa.com> | 2012-10-05 12:24:59 +0200 |
|---|---|---|
| committer | Dimitar <dimitar@bukisa.com> | 2012-10-05 12:24:59 +0200 |
| commit | 740480a7513e29e201f56c6481067108a2031509 (patch) | |
| tree | 183f2dc26dcaf2220a7d09c5904a8d7399dbfb60 | |
| parent | 6dba0cded0999ccfecce07b55df2c11e3e6cce86 (diff) | |
Bug-fix in XML-RPC library
$type and $typeof are passed as strings in this function, therefore I took the easy way and simplified the validation.
I tested with different requests (strings, numbers ..), no other issues found.
| -rwxr-xr-x[-rw-r--r--] | system/libraries/Xmlrpc.php | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/system/libraries/Xmlrpc.php b/system/libraries/Xmlrpc.php index a8aaa2088..dc5d27f8c 100644..100755 --- a/system/libraries/Xmlrpc.php +++ b/system/libraries/Xmlrpc.php @@ -1317,15 +1317,15 @@ class XML_RPC_Values extends CI_Xmlrpc { $type = $type === '' ? 'string' : $type; - if ($this->xmlrpcTypes[$type] === 1) + if ($this->xmlrpcTypes[$type] == 1) { $this->addScalar($val,$type); } - elseif ($this->xmlrpcTypes[$type] === 2) + elseif ($this->xmlrpcTypes[$type] == 2) { $this->addArray($val); } - elseif ($this->xmlrpcTypes[$type] === 3) + elseif ($this->xmlrpcTypes[$type] == 3) { $this->addStruct($val); } @@ -1351,7 +1351,7 @@ class XML_RPC_Values extends CI_Xmlrpc return 0; } - if ($typeof !== 1) + if ($typeof != 1) { echo '<strong>XML_RPC_Values</strong>: not a scalar type (${typeof})<br />'; return 0; |