summaryrefslogtreecommitdiffstats
path: root/system/database/drivers
diff options
context:
space:
mode:
Diffstat (limited to 'system/database/drivers')
-rw-r--r--system/database/drivers/oci8/oci8_utility.php2
-rw-r--r--system/database/drivers/postgre/postgre_utility.php8
-rw-r--r--system/database/drivers/sqlite/sqlite_utility.php19
3 files changed, 19 insertions, 10 deletions
diff --git a/system/database/drivers/oci8/oci8_utility.php b/system/database/drivers/oci8/oci8_utility.php
index dc259ac39..4d267dc6a 100644
--- a/system/database/drivers/oci8/oci8_utility.php
+++ b/system/database/drivers/oci8/oci8_utility.php
@@ -76,7 +76,7 @@ class CI_DB_oci8_utility extends CI_DB_utility {
*/
function _list_tables()
{
- return "select TABLE_NAME FROM ALL_TABLES";
+ return "SELECT TABLE_NAME FROM ALL_TABLES";
}
// --------------------------------------------------------------------
diff --git a/system/database/drivers/postgre/postgre_utility.php b/system/database/drivers/postgre/postgre_utility.php
index 0ee448f9e..7b51c3fe7 100644
--- a/system/database/drivers/postgre/postgre_utility.php
+++ b/system/database/drivers/postgre/postgre_utility.php
@@ -97,7 +97,7 @@ class CI_DB_postgre_utility extends CI_DB_utility {
/**
* Optimize table query
*
- * Generates a platform-specific query so that a table can be optimized
+ * Is table optimization supported in Postgre?
*
* @access private
* @param string the table name
@@ -105,7 +105,7 @@ class CI_DB_postgre_utility extends CI_DB_utility {
*/
function _optimize_table($table)
{
- return FALSE; // Is this supported in Postgre?
+ return FALSE;
}
// --------------------------------------------------------------------
@@ -113,7 +113,7 @@ class CI_DB_postgre_utility extends CI_DB_utility {
/**
* Repair table query
*
- * Generates a platform-specific query so that a table can be repaired
+ * Are table repairs supported in Postgre?
*
* @access private
* @param string the table name
@@ -121,7 +121,7 @@ class CI_DB_postgre_utility extends CI_DB_utility {
*/
function _repair_table($table)
{
- return return FALSE; // Is this supported in Postgre?
+ return return FALSE;
}
diff --git a/system/database/drivers/sqlite/sqlite_utility.php b/system/database/drivers/sqlite/sqlite_utility.php
index 43c43e03c..ae241db87 100644
--- a/system/database/drivers/sqlite/sqlite_utility.php
+++ b/system/database/drivers/sqlite/sqlite_utility.php
@@ -34,7 +34,8 @@ class CI_DB_sqlite_utility extends CI_DB_utility {
*/
function _create_database()
{
- // In SQLite, a database is created when you connect to the database
+ // In SQLite, a database is created when you connect to the database.
+ // We'll return TRUE so that an error isn't generated
return TRUE;
}
@@ -65,11 +66,17 @@ class CI_DB_sqlite_utility extends CI_DB_utility {
/**
* List databases
*
+ * I don't believe you can do a database listing with SQLite
+ * since each database is its own file. I suppose we could
+ * try reading a directory looking for SQLite files, but
+ * that doesn't seem like a terribly good idea
+ *
* @access private
* @return bool
*/
function _list_databases()
{
+
if ($this->db_debug)
{
return $this->display_error('db_unsuported_feature');
@@ -97,6 +104,8 @@ class CI_DB_sqlite_utility extends CI_DB_utility {
/**
* Drop Table
*
+ * Unsupported feature in SQLite
+ *
* @access private
* @return bool
*/
@@ -114,7 +123,7 @@ class CI_DB_sqlite_utility extends CI_DB_utility {
/**
* Optimize table query
*
- * Generates a platform-specific query so that a table can be optimized
+ * Is optimization even supported in SQLite?
*
* @access private
* @param string the table name
@@ -122,7 +131,7 @@ class CI_DB_sqlite_utility extends CI_DB_utility {
*/
function _optimize_table($table)
{
- return FALSE; // Is this supported SQLite?
+ return FALSE;
}
// --------------------------------------------------------------------
@@ -130,7 +139,7 @@ class CI_DB_sqlite_utility extends CI_DB_utility {
/**
* Repair table query
*
- * Generates a platform-specific query so that a table can be repaired
+ * Are table repairs even supported in SQLite?
*
* @access private
* @param string the table name
@@ -138,7 +147,7 @@ class CI_DB_sqlite_utility extends CI_DB_utility {
*/
function _repair_table($table)
{
- return return FALSE; // Is this supported in SQLite?
+ return return FALSE;
}