Age | Commit message (Collapse) | Author | Files | Lines |
|
Typically, in most cases, we do not need to cache all the Query String variables. That's why I suggest to improve `Cache Include Query String` behaviour — allow the developer to independently specify which variables should be cached.
For example, consider a query to the following URL address:
http://site.com/search?q=query&page=2&session=abcd&utm_source=web
In this case we don't need to build md5 hash for entire query string, because `session` or `utm_source` can be different for all users. The only variables which should be used for md5 hash should be `q` and `page`. Thus, in `config.php` we can use `$config['cache_query_string'] = array('page', 'q');`.
So:
`$config['cache_query_string'] = FALSE;` → Cache Include Query String is disabled
`$config['cache_query_string'] = TRUE;` → Cache Include Query String is enabled for all
`$config['cache_query_string'] = array('page', 'q');` → enabled only for specified variables
|
|
According to documentation, to manually delete cache for page "/foo/bar" we should run $this->output->delete_cache('/foo/bar'), but in this case MD5 hash will be calculated for "http://site.com//foo/bar" and this is why, we should pass $uri without beginning slash (ie, "foo/bar"). But the problem is that there is no way to delete cache for home page because:
1) $this->output->delete_cache('/') — MD5 hash will be calculated for "http://site.com//" and cache file will not be deleted.
2) $this->output->delete_cache('') — MD5 hash will be calculated for "http://site.com/%CURRENT_PAGE%" and again, cache file will not be deleted.
Trimming the beginning slash, we enable ability to delete cache for home page by calling $this->output->delete_cache('/'). Also, this method will work as specified in the documentation.
|
|
|
|
Signed-off-by: natepizzle <natepizzle@users.noreply.github.com>
|
|
|
|
'Class Loaded' type of messages flood log files when
log_threshold is set to 2 (debug). They're now logged
as 'info' level.
This is manually applying PR #1528, which was created
to do the same thing, but became outdated.
|
|
- Remove PHP version from license notices
- Bump year number in copyright notices
- Recommend PHP 5.4 or newer to be used
- Tell Travis-CI to test on PHP 5.3.0 instead of the latest 5.3 version
Related: #3450
|
|
This feature has proven to be problematic and it's not nearly
as flexible as a dedicated minifier library like Minify
(http://www.minifier.org/, https://github.com/matthiasmullie/minify).
The same results in terms of saving traffic can also be achievied via
gzip compression (which should also be done on the httpd level, but we
also support anyway) and stuff like mod_pagespeed.
Reverts PR #965
Related issues as a track record proving how problematic this has been:
#2078 #1499 #2163 #2092 #2387 #2637 #2710 #2120 #2171 #2631 #2326 #2795
#2791 #2772
Additionally, the count of contributors suggesting that the only way
to fix the minifier problems is to remove it, is around the same as
the count of people suggesting the feature to be implemented in the
first place. It was experimental anyway ... the experiment failed.
|
|
Close #2349
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Changed all file permissions settings throught the framework
and the documentation.
Also added configuration settings for CI_Log and CI_Image_lib
|
|
|
|
The core shouldn't depend on constants that are not defined by itself
|
|
|
|
|
|
- Use load_class() to get objects during bootstrap process.
- Change load_class() to accept a class constructor parameter
instead of previously unused class name prefix.
- Change CI_Router::__construct() to accept as a parameter.
|
|
|
|
Update copyright notices from 2013 to 2014.
And update one calendar example in user_guide from year 2013/2014 to
2014/2015.
|
|
|
|
We only used to check (and not always) if the return value of fwrite() is boolean FALSE,
while it is possible that the otherwise returned bytecount is less than the length of
data that we're trying to write. This allowed incomplete writes over network streams
and possibly a few other edge cases.
|
|
|
|
Based on PR #964
|
|
|
|
|
|
|
|
|
|
regexp patterns
|
|
|
|
delimiter used for regex bounds found in neg. lookahead
causes error using @ delimiter now for this expression
|
|
cleaned up the regex to remove extra qualifiers
used character sets where possible for clarity
main expression optimized
|
|
more elegant way to make sure that the comment is not in a js string var
|
|
|
|
|
|
is in a string or not
|
|
|
|
|
|
|
|
|
|
|
|
Added 2 additional MIME types to match against for JavaScript detection.
|
|
Note: The Driver libary tests seem to depend on that, so one occurence in CI_Loader is left until we resolve that.
|
|
|
|
|
|
Signed-off-by: Eric Roberts <eric@cryode.com>
|
|
|