Age | Commit message (Collapse) | Author | Files | Lines |
|
Re-allocated exit status codes according to three references, which follow:
BSD sysexits.h:http://www.gsp.com/cgi-bin/man.cgi?section=3&topic=sysexits
GNU recomendations:http://www.gnu.org/software/libc/manual/html_node/Exit-Status.html
Bash scripting:http://tldp.org/LDP/abs/html/exitcodes.html
The GNU recommendations stem from and expand upon the standard C/C++ library (stdlibc)
definitions, while also suggesting some best-practice conventions which happen to prevent
exit status code collisions with bash, and probably other shells.
The re-allocated codes are now mapped to constant values, set in *application/config/constants.php*,
and used throughout the CodeIgniter core. They would additionally be used in *index.php*,
but the constants file hasn't been loaded at that point, so the integer values are used
instead, and a comment follows each such use with amplifying information on why that
particular value was selected.
Finally, the errors documentation has been updated accordingly.
Signed-off-by: Daniel Hunsaker <danhunsaker@gmail.com>
|
|
feature/exit-status
|
|
Note: The Driver libary tests seem to depend on that, so one occurence in CI_Loader is left until we resolve that.
|
|
Specific codes are as follows, but can easily be changed if a different order/breakdown makes more sense:
- 0: Success; everything executed as planned
- 1: Configuration Error; something is wrong with/in the configuration file(s)
- 2: Class Not Found; what it says
- 3: Driver Method Unsupported; the method you're trying to use on a Driver doesn't exist
- 4: File Not Found; 404 error
- 5: Database Error; something is broken in the database somewhere
- 6: Invalid Input; the user attempted to submit a request with invlaid characters in 1+ key names
7 through 26 are reserved for future use
- 27: Generic Error; generated by show_error() when the status code is >= 100
28 through 127 are errors generated by user applications, normally by using show_error() with a status code below 100
128 through 254 should not be used by applications, as they are reserved by system-level functions
- 255: PHP Fatal Error; automatically generated by PHP for fatal errors, and therefore not allowed for our use
Status codes below 100 are shifted up by 28 to place them in the user error range. It may make more sense to have these codes
left alone and instead shift the CI errors into the 101 through 127 space, but that's not what I opted for here.
It would probably also be a good idea to replace the hard-coded numbers with constants or some such, but I was in a bit of a
hurry when I made these changes, so I didn't look around for the best place to do this. With proper guidance, I could
easily amend this commit with another that uses such constant values.
Signed-off-by: Daniel Hunsaker <danhunsaker@gmail.com>
|
|
|
|
|
|
Signed-off-by: Eric Roberts <eric@cryode.com>
|
|
|
|
Allows IE conditionals like the following to remain unmodified.
```html
<!--[if gt IE 8]><!--> <html class="no-js"> <!--<![endif]-->
```
Credit to joebert regex from
http://www.sitepoint.com/forums/showthread.php?696559-Regex-pattern-to-strip-HTML-comments-but-leave-conditonals&s=3eef4ceb0a59b2fdb946fa56220fb6fd&p=4678083&viewfull=1#post4678083
|
|
This reverts commit 8e12c787042396e172a7448c65bd16c3015ffb0f.
|
|
Allows IE conditionals like the following to remain unmodified.
<!--[if gt IE 8]><!--> <html class="no-js"> <!--<![endif]-->
Credit to joebert regex from
http://www.sitepoint.com/forums/showthread.php?696559-Regex-pattern-to-strip-HTML-comments-but-leave-conditonals&s=3eef4ceb0a59b2fdb946fa56220fb6fd&p=4678083&viewfull=1#post4678083
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
(following PRs #2049, #2079)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
update for Issue #2064 - take 2
|
|
method that returns $this to @return CI_DB_class_name)
|
|
Minify output in css and javascript code
|
|
Minify output in css and javascript code
|
|
(an improved version of PR #609)
|
|
(an improved version of PR #645)
Also fixed get_content_type() to only return the MIME value and created
Output library unit tests for both of these methods.
|
|
|
|
Also partially fixes issue #1295, fixes inconsistencies in some page-level docblocks and adds include checks in language files.
|
|
|
|
Remove some extra new lines
|
|
|
|
|
|
|
|
Faster, shorter code
|
|
Won't change anything in practice, but robuster (and faster) if ever
a cache file would be invalid
|
|
remove an unneeded regex capturing group and an unneeded trim()
|
|
faster method to remove the timestamp from the content to be served
|
|
|
|
|
|
Interestingly `wether` means a castrated ram in old English
|
|
|
|
|
|
https://github.com/atiredmachine/CodeIgniter into develop
|
|
that they don't differ from the rest
|
|
|