Age | Commit message (Collapse) | Author | Files | Lines |
|
- min and max values are 0 and mt_getrandmax() by default
- remove useless mt_srand() seed calls
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Added 2 additional MIME types to match against for JavaScript detection.
|
|
|
|
to begin with
Signed-off-by: Daniel Hunsaker <danhunsaker@gmail.com>
|
|
Signed-off-by: Daniel Hunsaker <danhunsaker@gmail.com>
|
|
- Removed commented lists of constants from the three reference conventions,
replacing each with the URLs at which more information can be found.
- Renamed a few constants to more closely reflect CodeIgniter conventions.
- Modified a couple of lines which were in violation of the CI Style Guide.
Signed-off-by: Daniel Hunsaker <danhunsaker@gmail.com>
|
|
feature/exit-status
|
|
Previously, only the other syntax was working: load->vars->(array('foobar' => ''))
|
|
Re-allocated exit status codes according to three references, which follow:
BSD sysexits.h:http://www.gsp.com/cgi-bin/man.cgi?section=3&topic=sysexits
GNU recomendations:http://www.gnu.org/software/libc/manual/html_node/Exit-Status.html
Bash scripting:http://tldp.org/LDP/abs/html/exitcodes.html
The GNU recommendations stem from and expand upon the standard C/C++ library (stdlibc)
definitions, while also suggesting some best-practice conventions which happen to prevent
exit status code collisions with bash, and probably other shells.
The re-allocated codes are now mapped to constant values, set in *application/config/constants.php*,
and used throughout the CodeIgniter core. They would additionally be used in *index.php*,
but the constants file hasn't been loaded at that point, so the integer values are used
instead, and a comment follows each such use with amplifying information on why that
particular value was selected.
Finally, the errors documentation has been updated accordingly.
Signed-off-by: Daniel Hunsaker <danhunsaker@gmail.com>
|
|
feature/exit-status
|
|
Note: The Driver libary tests seem to depend on that, so one occurence in CI_Loader is left until we resolve that.
|
|
|
|
Fixed is_https() to avoid incorrect detection.
|
|
Update system/core/Log.php
|
|
This reverts commit 8af05ac97513764cc539919e179794df87352c30.
|
|
This reverts commit bbc6ab4736a896be83e3e3d5f8856374ffa2984c.
|
|
This reverts commit 3de57eaea8510ea9cfd70f063565c24904669c4c.
|
|
This reverts commit 8af05ac97513764cc539919e179794df87352c30.
|
|
If using nginx instead of apache by default nginx will not populate the $_SERVER['HTTPS'] value. This change allows falling back to checking the port number of the request to determine if your on SSL or not.
The other option is adding the following to your nginx config.
fastcgi_param HTTPS on; #some php apps require this to detent https
|
|
Added a space after the comma on the ltrim().
|
|
|
|
|
|
|
|
Don't print no script access code into log file if log file is not .php anymore.
|
|
Added ltrim() as requested to strip '.' incase it's added by mistake.
|
|
Updated is_https() to avoid "NULL" or "0" values to set HTTPS.
|
|
whatever is preferred. example (.log)
This is a follow up to this pull request.
https://github.com/EllisLab/CodeIgniter/pull/2243
|
|
Updated Log.php so that a developer can extend it and change the log file extension.
It makes sense to default to .php when logs are in the public web folder. It would be nice if a developer moves the log file path we have the option to use a standard extension like .log
|
|
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
|
|
Also applied @xeptor's fix (a big thanks) to the sanitize_filename() method and added a changelog entry for it - fixes issue #73.
|
|
(where it makes sense)
Also:
- Implemented caching of configuration arrays for smileys, foreign characters and doctypes.
- Implemented cascading-style loading of configuration files (except for library configs, DB and constants.php).
|
|
|
|
|
|
|
|
As suggested in issue #2134 & PR #2149
|
|
Signed-off-by: Eric Roberts <eric@cryode.com>
|
|
Specific codes are as follows, but can easily be changed if a different order/breakdown makes more sense:
- 0: Success; everything executed as planned
- 1: Configuration Error; something is wrong with/in the configuration file(s)
- 2: Class Not Found; what it says
- 3: Driver Method Unsupported; the method you're trying to use on a Driver doesn't exist
- 4: File Not Found; 404 error
- 5: Database Error; something is broken in the database somewhere
- 6: Invalid Input; the user attempted to submit a request with invlaid characters in 1+ key names
7 through 26 are reserved for future use
- 27: Generic Error; generated by show_error() when the status code is >= 100
28 through 127 are errors generated by user applications, normally by using show_error() with a status code below 100
128 through 254 should not be used by applications, as they are reserved by system-level functions
- 255: PHP Fatal Error; automatically generated by PHP for fatal errors, and therefore not allowed for our use
Status codes below 100 are shifted up by 28 to place them in the user error range. It may make more sense to have these codes
left alone and instead shift the CI errors into the 101 through 127 space, but that's not what I opted for here.
It would probably also be a good idea to replace the hard-coded numbers with constants or some such, but I was in a bit of a
hurry when I made these changes, so I didn't look around for the best place to do this. With proper guidance, I could
easily amend this commit with another that uses such constant values.
Signed-off-by: Daniel Hunsaker <danhunsaker@gmail.com>
|
|
|
|
|
|
|
|
Signed-off-by: Eric Roberts <eric@cryode.com>
|
|
feature/output-cache-improvements
|
|
Exact same behavior, but faster. I also think it's more readable.
|