Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
|| to OR
remove the empty line at EOF
|
|
trans_complete function is committed in test mode.
Because any database drivers are set _trans_failure in test_mode,
And trans_complete function is not evaluate _trans_failure.
|
|
Re-allocated exit status codes according to three references, which follow:
BSD sysexits.h:http://www.gsp.com/cgi-bin/man.cgi?section=3&topic=sysexits
GNU recomendations:http://www.gnu.org/software/libc/manual/html_node/Exit-Status.html
Bash scripting:http://tldp.org/LDP/abs/html/exitcodes.html
The GNU recommendations stem from and expand upon the standard C/C++ library (stdlibc)
definitions, while also suggesting some best-practice conventions which happen to prevent
exit status code collisions with bash, and probably other shells.
The re-allocated codes are now mapped to constant values, set in *application/config/constants.php*,
and used throughout the CodeIgniter core. They would additionally be used in *index.php*,
but the constants file hasn't been loaded at that point, so the integer values are used
instead, and a comment follows each such use with amplifying information on why that
particular value was selected.
Finally, the errors documentation has been updated accordingly.
Signed-off-by: Daniel Hunsaker <danhunsaker@gmail.com>
|
|
feature/exit-status
|
|
DB_driver's trans_complete exception fix
|
|
checks ...
|
|
Note: The Driver libary tests seem to depend on that, so one occurence in CI_Loader is left until we resolve that.
|
|
|
|
Specific codes are as follows, but can easily be changed if a different order/breakdown makes more sense:
- 0: Success; everything executed as planned
- 1: Configuration Error; something is wrong with/in the configuration file(s)
- 2: Class Not Found; what it says
- 3: Driver Method Unsupported; the method you're trying to use on a Driver doesn't exist
- 4: File Not Found; 404 error
- 5: Database Error; something is broken in the database somewhere
- 6: Invalid Input; the user attempted to submit a request with invlaid characters in 1+ key names
7 through 26 are reserved for future use
- 27: Generic Error; generated by show_error() when the status code is >= 100
28 through 127 are errors generated by user applications, normally by using show_error() with a status code below 100
128 through 254 should not be used by applications, as they are reserved by system-level functions
- 255: PHP Fatal Error; automatically generated by PHP for fatal errors, and therefore not allowed for our use
Status codes below 100 are shifted up by 28 to place them in the user error range. It may make more sense to have these codes
left alone and instead shift the CI errors into the 101 through 127 space, but that's not what I opted for here.
It would probably also be a good idea to replace the hard-coded numbers with constants or some such, but I was in a bit of a
hurry when I made these changes, so I didn't look around for the best place to do this. With proper guidance, I could
easily amend this commit with another that uses such constant values.
Signed-off-by: Daniel Hunsaker <danhunsaker@gmail.com>
|
|
so that it's only called by drivers that need it ('mysql', 'mssql').
As proposed in issue #2187.
|
|
Exact same behavior, but faster. I also think it's more readable.
|
|
Added protected method _escape_str() to deal with quote escaping.
|
|
|
|
|
|
|
|
|
|
http://codeigniter.com/forums/viewthread/229610/
|
|
(feature request #1987)
|
|
|
|
Partially fixes issue #1295.
|
|
Partially fixes issue #1295.
|
|
Also partially fixes issue #1295, fixes inconsistencies in some page-level docblocks and adds include checks in language files.
|
|
|
|
|
|
|
|
feature/db_qb_aliasing
|
|
it), fix some typos, add encrypted database connections support and fix SQLSRV CharacterSet setting
|
|
|
|
|
|
|
|
|
|
|
|
Signed-off-by: Andrey Andreev <narf@bofh.bg>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
typecasts + add _compile_group_by() method
|
|
_delete(), _like(), _update(), _update_batch()
|
|
|
|
|
|
feature/db_subdrivers
|
|
|
|
|
|
|
|
that they're available for use by insert_string() and update_string() at all times
|