summaryrefslogtreecommitdiffstats
path: root/system/helpers/download_helper.php
AgeCommit message (Collapse)AuthorFilesLines
2013-03-04Updated in accordance with feedback from @narfbgDaniel Hunsaker1-2/+2
- Removed commented lists of constants from the three reference conventions, replacing each with the URLs at which more information can be found. - Renamed a few constants to more closely reflect CodeIgniter conventions. - Modified a couple of lines which were in violation of the CI Style Guide. Signed-off-by: Daniel Hunsaker <danhunsaker@gmail.com>
2013-02-23Updated exit codes as constant valuesDaniel Hunsaker1-2/+2
Re-allocated exit status codes according to three references, which follow: BSD sysexits.h:http://www.gsp.com/cgi-bin/man.cgi?section=3&topic=sysexits GNU recomendations:http://www.gnu.org/software/libc/manual/html_node/Exit-Status.html Bash scripting:http://tldp.org/LDP/abs/html/exitcodes.html The GNU recommendations stem from and expand upon the standard C/C++ library (stdlibc) definitions, while also suggesting some best-practice conventions which happen to prevent exit status code collisions with bash, and probably other shells. The re-allocated codes are now mapped to constant values, set in *application/config/constants.php*, and used throughout the CodeIgniter core. They would additionally be used in *index.php*, but the constants file hasn't been loaded at that point, so the integer values are used instead, and a comment follows each such use with amplifying information on why that particular value was selected. Finally, the errors documentation has been updated accordingly. Signed-off-by: Daniel Hunsaker <danhunsaker@gmail.com>
2013-02-22Merge branch 'develop' of github.com:EllisLab/CodeIgniter into ↵Daniel Hunsaker1-1/+1
feature/exit-status
2013-01-29Replace is_file() with the faster file_exists()Andrey Andreev1-1/+1
(where it makes sense) Also: - Implemented caching of configuration arrays for smileys, foreign characters and doctypes. - Implemented cascading-style loading of configuration files (except for library configs, DB and constants.php).
2013-01-25Updated all cases of exit() to return a valid codeDaniel Hunsaker1-2/+3
Specific codes are as follows, but can easily be changed if a different order/breakdown makes more sense: - 0: Success; everything executed as planned - 1: Configuration Error; something is wrong with/in the configuration file(s) - 2: Class Not Found; what it says - 3: Driver Method Unsupported; the method you're trying to use on a Driver doesn't exist - 4: File Not Found; 404 error - 5: Database Error; something is broken in the database somewhere - 6: Invalid Input; the user attempted to submit a request with invlaid characters in 1+ key names 7 through 26 are reserved for future use - 27: Generic Error; generated by show_error() when the status code is >= 100 28 through 127 are errors generated by user applications, normally by using show_error() with a status code below 100 128 through 254 should not be used by applications, as they are reserved by system-level functions - 255: PHP Fatal Error; automatically generated by PHP for fatal errors, and therefore not allowed for our use Status codes below 100 are shifted up by 28 to place them in the user error range. It may make more sense to have these codes left alone and instead shift the CI errors into the 101 through 127 space, but that's not what I opted for here. It would probably also be a good idea to replace the hard-coded numbers with constants or some such, but I was in a bit of a hurry when I made these changes, so I didn't look around for the best place to do this. With proper guidance, I could easily amend this commit with another that uses such constant values. Signed-off-by: Daniel Hunsaker <danhunsaker@gmail.com>
2013-01-01[ci skip] Happy new yearAndrey Andreev1-1/+1
2012-11-22Added support for stream-like downloads of existing files to force_download()Andrey Andreev1-3/+38
Based on code/ideas from PR #365, #1254
2012-11-01Manually apply PR #1594 (fixing phpdoc page-level generation/warnings)Andrey Andreev1-1/+2
Also partially fixes issue #1295, fixes inconsistencies in some page-level docblocks and adds include checks in language files.
2012-10-24Fix #1146Andrey Andreev1-6/+3
2012-08-14fix issue 1706Michiel Vugteveen1-1/+4
2012-06-16Spelling fixes - `wether` to `whether`Alex Bilbie1-1/+1
Interestingly `wether` means a castrated ram in old English
2012-06-05Added get_mimes() function to system/core/Commons.php.The MIMEs array from ↵Andrey Andreev1-8/+1
config/mimes.php is used by multiple core classes, libraries and helpers and each of them has implemented an own way of getting it, which is not needed and is hard to maintain. This also fixes issue #1411
2012-06-04Direct return from mimes config, instead of using global $mimes;Phil Sturgeon1-2/+2
Global variables are generally a terrible idea, especially for something as simple as this. The mimes.php now returns an array instead of just injecting a variable name into the global namespace.
2012-06-02Replaced `==` with `===` and `!=` with `!==` in /system/helpersAlex Bilbie1-1/+1
2012-05-17Clean up the helpersAndrey Andreev1-1/+1
2012-04-27Fix docblocks A-HTimothy Warren1-10/+10
2012-04-23Tweak to comments to conform to style guide.Sam Li1-1/+1
2012-04-23Added fix for issue: https://github.com/EllisLab/CodeIgniter/issues/1277Sam Li1-0/+3
2012-03-26Remove access description lines and cleanup the download, language, number, ↵Andrey Andreev1-2/+1
path & xml helpers
2012-03-11Fix erroneus regex from previous commitAndrey Andreev1-1/+1
2012-03-11Added an Android <= 2.1 specific check to force_download()Andrey Andreev1-7/+19
2012-03-10Removed quotes from the Content-Type header to support mime-type detection ↵dododedodonl1-1/+1
on android
2012-03-09Bumped CodeIgniter's PHP requirement to 5.2.4.Phil Sturgeon1-1/+1
Yes I know PHP 5.4 just came out, and yes I know PHP 5.3 has lovely features, but there are plenty of corporate systems running on CodeIgniter and PHP 5.3 still is not widely supported enough. CodeIgniter is great for distributed applications, and this is the highest we can reasonably go without breaking support. PHP 5.3 will most likely happen in another year or so. Fingers crossed on that one anyway...
2012-02-29Change end() usage due to E_STRICT messagesAndrey Andreev1-1/+2
2012-02-29Add an optional set_mime parameter to force_download()Andrey Andreev1-39/+41
2012-01-24Fix bug #195Eric Roberts1-16/+10
Fixes bug #195 regarding non-existent user agent strings when using force_download() helper.
2012-01-02Updating copyright date to 2012Greg Aker1-1/+1
2011-12-27Revert "Abstracting the loading of files in the config directory depending ↵Greg Aker1-1/+8
on environments." This reverts commit 5c1aa631c5f5ec2f6b75ba1158178418e50ba11a.
2011-12-25Abstracting the loading of files in the config directory depending on ↵Greg Aker1-8/+1
environments.
2011-10-20adding new license file (OSL 3.0) and updating readme to ReSTDerek Jones1-4/+16
added notice of license to all source files. OSL to all except the few files we ship inside of the application folder, those are AFL. Updated license in user guide. incrementing next dev version to 3.0 due to licensing change
2011-07-02backed out 648b42a75739, which was a NON-trivial whitespace commit. It ↵Derek Jones1-1/+1
broke the Typography class's string replacements, for instance
2011-04-25Fixed double-space typo.Razican1-1/+1
2011-04-19Removing internal references to the EXT constant. Additionally, marked the ↵Greg Aker1-4/+4
constant as deprecated. Use ".php" instead. Also adding upgrade notes from 2.0.2 to 2.0.3.
2011-04-06Made Environment Support optional. Comment out or delete the constant to ↵Phil Sturgeon1-1/+1
stop environment checks.
2011-03-22Fixed logic and removed the error supressingEric Barnes1-3/+3
2011-03-18Fixed coding to match standards from previous releasesEric Barnes1-1/+1
2011-03-17load config files from environment specific locations in core classes, ↵bubbafoley1-1/+8
helpers and libraries
2011-01-05Hey look, it's 2011Greg Aker1-1/+1
2010-11-10Updating PHP requirements in files 5.1.6Greg Aker1-1/+1
2010-10-04Cleanup of stray spaces and tabsBarry Mieny1-5/+5
2010-03-19Changed a few strstr to strpos for consistency w performance guidelines and ↵Robin Sowell1-1/+1
to mirror EE2.
2010-01-05updated copyrightsDerek Jones1-1/+1
2009-04-22updated copyrights to 2009Derek Jones1-1/+1
2008-11-13Changing EOL style to LFDerek Allard1-99/+99
2008-09-13updated copyrightRick Ellis1-1/+1
2008-05-13Some sweeping syntax changes for consistency:Derek Jones1-5/+5
(! foo) changed to ( ! foo) || changed to OR changed newline standardization code in various places from preg_replace to str_replace
2008-05-11Removed closing PHP tags, replaced with a comment block identifying the end ↵Derek Jones1-1/+3
of the file
2008-05-11Undoing change committed in r1115Derek Jones1-0/+1
2008-05-11removed closing PHP tag from all framework filesDerek Jones1-1/+0
2008-05-05Added get_dir_file_info(), get_file_info(), and get_mime_by_extension() to ↵Derek Allard1-1/+1
the File Helper. Changed ( ! condition) into (! condition) within the code