summaryrefslogtreecommitdiffstats
path: root/system/libraries
AgeCommit message (Collapse)AuthorFilesLines
2013-03-04Merge pull request #2190 from danhunsaker/feature/exit-statusAndrey Andreev2-5/+3
Updated all CLI-valid cases of exit() to return a valid code
2013-03-04[ci skip] Fix #2289Andrey Andreev1-3/+2
2013-03-04Reverting changes to functions that have no business being used in CLI apps ↵Daniel Hunsaker2-6/+3
to begin with Signed-off-by: Daniel Hunsaker <danhunsaker@gmail.com>
2013-03-04Oops, missed a few places where EXIT_SUCCESS was being used.Daniel Hunsaker1-2/+2
Signed-off-by: Daniel Hunsaker <danhunsaker@gmail.com>
2013-03-04Updated in accordance with feedback from @narfbgDaniel Hunsaker2-2/+2
- Removed commented lists of constants from the three reference conventions, replacing each with the URLs at which more information can be found. - Renamed a few constants to more closely reflect CodeIgniter conventions. - Modified a couple of lines which were in violation of the CI Style Guide. Signed-off-by: Daniel Hunsaker <danhunsaker@gmail.com>
2013-03-04Merge branch 'develop' of github.com:EllisLab/CodeIgniter into ↵Daniel Hunsaker1-1/+1
feature/exit-status
2013-03-02Fix Session cookie driver storing untrimmed user agent string in the ↵Daniel Robbins1-1/+1
database causing set_userdata() calls to fail when $config['sess_match_useragent'] = TRUE Signed-off-by: Daniel Robbins <github@danieljrobbins.com>
2013-02-23Updated exit codes as constant valuesDaniel Hunsaker3-4/+4
Re-allocated exit status codes according to three references, which follow: BSD sysexits.h:http://www.gsp.com/cgi-bin/man.cgi?section=3&topic=sysexits GNU recomendations:http://www.gnu.org/software/libc/manual/html_node/Exit-Status.html Bash scripting:http://tldp.org/LDP/abs/html/exitcodes.html The GNU recommendations stem from and expand upon the standard C/C++ library (stdlibc) definitions, while also suggesting some best-practice conventions which happen to prevent exit status code collisions with bash, and probably other shells. The re-allocated codes are now mapped to constant values, set in *application/config/constants.php*, and used throughout the CodeIgniter core. They would additionally be used in *index.php*, but the constants file hasn't been loaded at that point, so the integer values are used instead, and a comment follows each such use with amplifying information on why that particular value was selected. Finally, the errors documentation has been updated accordingly. Signed-off-by: Daniel Hunsaker <danhunsaker@gmail.com>
2013-02-22Merge branch 'develop' of github.com:EllisLab/CodeIgniter into ↵Daniel Hunsaker16-162/+223
feature/exit-status
2013-02-21Disable autoloader call from class_exists() occurences to improve performanceAndrey Andreev3-4/+4
Note: The Driver libary tests seem to depend on that, so one occurence in CI_Loader is left until we resolve that.
2013-02-19Issue #2086 Session_cookie's _update_db not guaranteed to updateDionysis Arvanitis1-0/+3
2013-02-19Merge pull request #2261 from nisheeth-barthwal/developAndrey Andreev1-2/+5
Fixed Issue #2239
2013-02-19Fixed the issue with bcc_batch_mode and subjectnisheeth-barthwal1-2/+5
2013-02-19Fix a code comment in Upload->_file_mime_type()vlakoff2-5/+5
Availability of dangerous functions is now tested using function_usable().
2013-02-18Removed the unused $force paramter in Email::_smtp_connect()nisheeth-barthwal1-29/+29
2013-02-18removed PR from the bug listnisheeth-barthwal1-1/+1
2013-02-18Fixed curly braces. Removed redundant method set_useragent()nisheeth-barthwal1-20/+11
2013-02-18Fixed tab-indentation. Made appropriate entries in changelognisheeth-barthwal1-283/+282
2013-02-17Added keep-alive connection to SMTP. Fixed socket read/write timeouts. Added ↵nisheeth-barthwal1-234/+290
PHP useragent
2013-02-15Fix some stuff from recent pull requestsAndrey Andreev1-2/+1
2013-02-15Various cosmetic fixesvlakoff4-5/+5
2013-02-14changes according to narfbg's requestTim1-2/+2
2013-02-13changes according to narfbg's requestTim1-3/+3
2013-02-13Added small feature to profiler: total execution time countTim1-2/+4
adds additional information to profiler like: DATABASE:  test   QUERIES: 3 (0.0016s)  (Hide)
2013-02-08Fix issue #2230Andrey Andreev1-3/+3
2013-02-08[ci skip] Remove unnecessary string casts in PaginationAndrey Andreev1-3/+2
2013-02-08Merge pull request #2199 from cryode/feature/paginationAndrey Andreev1-83/+116
Multiple pagination bug fixes & optimizations.
2013-02-08[ci skip] Add a missing spaceAndrey Andreev1-1/+1
2013-02-04Cleaned up for pull request.Sajan Parikh1-3/+1
Signed-off-by: Sajan Parikh <sajan@noppix.com>
2013-02-02Added Form Validation rule for alphanum + spaces.Sajan Parikh1-0/+15
Signed-off-by: Sajan Parikh <sajan@noppix.com>
2013-01-30Fix/improve #2211Andrey Andreev1-2/+2
2013-01-29Replace CI_Upload::clean_file_name() usage with CI_Security::sanitize_filename()Andrey Andreev1-48/+2
Also applied @xeptor's fix (a big thanks) to the sanitize_filename() method and added a changelog entry for it - fixes issue #73.
2013-01-29Replace is_file() with the faster file_exists()Andrey Andreev1-5/+8
(where it makes sense) Also: - Implemented caching of configuration arrays for smileys, foreign characters and doctypes. - Implemented cascading-style loading of configuration files (except for library configs, DB and constants.php).
2013-01-29Replace is_numeric() with ctype_digit()Eric Roberts1-6/+13
Signed-off-by: Eric Roberts <eric@cryode.com>
2013-01-29Move $get assignment to if/else.Eric Roberts1-2/+4
Signed-off-by: Eric Roberts <eric@cryode.com>
2013-01-29Remove spaces from concats.Eric Roberts1-5/+5
Signed-off-by: Eric Roberts <eric@cryode.com>
2013-01-28Some micro-optimization to the Driver library loaderAndrey Andreev1-10/+9
2013-01-28Merge branch 'develop' of github.com:EllisLab/CodeIgniter into developAndrey Andreev1-1/+8
2013-01-28Libraries' filenames must be named in a ucfirst-like mannerAndrey Andreev3-1/+1
2013-01-28Remove str_replace in returngommarah1-1/+1
2013-01-28Upload library, clean_file_name function: Fix xss bug.gommarah1-0/+7
For example: If you clear this string "%%3f3f" according to the $bad array will fail. The result will be "%3f" Because str_replace() replaces left to right. Signed-off-by: xeptor <servetozkan@live.com>
2013-01-28Multiple pagination bug fixes & optimizations.Eric Roberts1-83/+107
Signed-off-by: Eric Roberts <eric@cryode.com>
2013-01-28Remove unnecessary defined('ENVIRONMENT') checksAndrey Andreev1-1/+1
As suggested in issue #2134 & PR #2149
2013-01-26Fix a code comment in Image_libvlakoff1-1/+1
constant FILE_WRITE_MODE contains octal 0666
2013-01-25Fix issue #2191.Edwin Aw1-1/+1
Signed-off-by: Edwin Aw <tkaw220@gmail.com>
2013-01-25Updated all cases of exit() to return a valid codeDaniel Hunsaker3-4/+5
Specific codes are as follows, but can easily be changed if a different order/breakdown makes more sense: - 0: Success; everything executed as planned - 1: Configuration Error; something is wrong with/in the configuration file(s) - 2: Class Not Found; what it says - 3: Driver Method Unsupported; the method you're trying to use on a Driver doesn't exist - 4: File Not Found; 404 error - 5: Database Error; something is broken in the database somewhere - 6: Invalid Input; the user attempted to submit a request with invlaid characters in 1+ key names 7 through 26 are reserved for future use - 27: Generic Error; generated by show_error() when the status code is >= 100 28 through 127 are errors generated by user applications, normally by using show_error() with a status code below 100 128 through 254 should not be used by applications, as they are reserved by system-level functions - 255: PHP Fatal Error; automatically generated by PHP for fatal errors, and therefore not allowed for our use Status codes below 100 are shifted up by 28 to place them in the user error range. It may make more sense to have these codes left alone and instead shift the CI errors into the 101 through 127 space, but that's not what I opted for here. It would probably also be a good idea to replace the hard-coded numbers with constants or some such, but I was in a bit of a hurry when I made these changes, so I didn't look around for the best place to do this. With proper guidance, I could easily amend this commit with another that uses such constant values. Signed-off-by: Daniel Hunsaker <danhunsaker@gmail.com>
2013-01-15A few adjustments to previous commitvlakoff1-1/+1
2013-01-14Replace is_null() with === / !== NULLvlakoff8-13/+13
Exact same behavior, but faster. I also think it's more readable.
2013-01-10A tiny improvementAndrey Andreev1-3/+2
2013-01-09fix imagejpeg() parameter, should be NULL instead of empty stringTed Wood1-1/+1
generated by cgit v1.2.3-24-g4f1b (git 2.32.0) at 2024-12-19 02:39:12 +0100