summaryrefslogtreecommitdiffstats
path: root/system
AgeCommit message (Collapse)AuthorFilesLines
2013-03-04Reverting changes to functions that have no business being used in CLI apps ↵Daniel Hunsaker4-17/+10
to begin with Signed-off-by: Daniel Hunsaker <danhunsaker@gmail.com>
2013-03-04Oops, missed a few places where EXIT_SUCCESS was being used.Daniel Hunsaker4-5/+5
Signed-off-by: Daniel Hunsaker <danhunsaker@gmail.com>
2013-03-04Updated in accordance with feedback from @narfbgDaniel Hunsaker5-15/+18
- Removed commented lists of constants from the three reference conventions, replacing each with the URLs at which more information can be found. - Renamed a few constants to more closely reflect CodeIgniter conventions. - Modified a couple of lines which were in violation of the CI Style Guide. Signed-off-by: Daniel Hunsaker <danhunsaker@gmail.com>
2013-03-04Merge branch 'develop' of github.com:EllisLab/CodeIgniter into ↵Daniel Hunsaker5-15/+15
feature/exit-status
2013-03-04Fix #2298Andrey Andreev1-6/+3
2013-03-02Fix Session cookie driver storing untrimmed user agent string in the ↵Daniel Robbins1-1/+1
database causing set_userdata() calls to fail when $config['sess_match_useragent'] = TRUE Signed-off-by: Daniel Robbins <github@danieljrobbins.com>
2013-03-01Merge pull request #2287 from vlakoff/developAndrey Andreev1-1/+1
Fix this use case: load->vars->('foobar', '')
2013-03-01Optimize changes from PR #2290Andrey Andreev1-4/+2
2013-03-01Merge pull request #2290 from jonesmdj/developAndrey Andreev1-1/+3
Remove trailing delimiters from csv_from_result
2013-02-28Text helper: convert_accented_characters() optimizationvlakoff1-5/+8
Thanks to static variables, array_keys() and array_values() are now executed once only.
2013-02-28added spaces after the parameter separatorsMichelle Jones1-2/+2
2013-02-27Remove trailing delimiters from csv_from_resultMichelle Jones1-1/+3
When using the csv_from_result function, the returned string includes an extra delimiter at the end of every line, usually a comma unless another delimiter is specified. A simple addition of a couple of lines to remove the extra delimiter from the column names and the data rows is included. (Lines 241 and 251)
2013-02-27Fix this use case: load->vars->('foobar', '')vlakoff1-1/+1
Previously, only the other syntax was working: load->vars->(array('foobar' => ''))
2013-02-23Updated exit codes as constant valuesDaniel Hunsaker11-18/+22
Re-allocated exit status codes according to three references, which follow: BSD sysexits.h:http://www.gsp.com/cgi-bin/man.cgi?section=3&topic=sysexits GNU recomendations:http://www.gnu.org/software/libc/manual/html_node/Exit-Status.html Bash scripting:http://tldp.org/LDP/abs/html/exitcodes.html The GNU recommendations stem from and expand upon the standard C/C++ library (stdlibc) definitions, while also suggesting some best-practice conventions which happen to prevent exit status code collisions with bash, and probably other shells. The re-allocated codes are now mapped to constant values, set in *application/config/constants.php*, and used throughout the CodeIgniter core. They would additionally be used in *index.php*, but the constants file hasn't been loaded at that point, so the integer values are used instead, and a comment follows each such use with amplifying information on why that particular value was selected. Finally, the errors documentation has been updated accordingly. Signed-off-by: Daniel Hunsaker <danhunsaker@gmail.com>
2013-02-22Merge branch 'develop' of github.com:EllisLab/CodeIgniter into ↵Daniel Hunsaker43-341/+422
feature/exit-status
2013-02-21Merge pull request #2266 from dionysiosarvanitis/fix/trans_completeAndrey Andreev1-1/+1
DB_driver's trans_complete exception fix
2013-02-21DB_result tests seem to also depend on autoloading via the class_exists() ↵Andrey Andreev1-1/+1
checks ...
2013-02-21Disable autoloader call from class_exists() occurences to improve performanceAndrey Andreev10-20/+20
Note: The Driver libary tests seem to depend on that, so one occurence in CI_Loader is left until we resolve that.
2013-02-21Manually apply PR #2234Andrey Andreev1-0/+1
2013-02-20Remove CI_DB_pdo_driver::Andrey Andreev1-7/+0
Improving on PR #2265, the property is inherited with the same value and doesn't need to be set.
2013-02-20Merge pull request #2265 from dionysiosarvanitis/fix/trans_enabledAndrey Andreev1-1/+1
Set transaction enabled flag default to TRUE
2013-02-19Issue #2086 Session_cookie's _update_db not guaranteed to updateDionysis Arvanitis1-0/+3
2013-02-19DB_driver's trans_complete exception fixDionysis Arvanitis1-1/+1
2013-02-19Set transaction enabled flag default to TRUEDionysis Arvanitis1-1/+1
2013-02-19Merge pull request #2261 from nisheeth-barthwal/developAndrey Andreev1-2/+5
Fixed Issue #2239
2013-02-19Fixed the issue with bcc_batch_mode and subjectnisheeth-barthwal1-2/+5
2013-02-19Fix a code comment in Upload->_file_mime_type()vlakoff2-5/+5
Availability of dangerous functions is now tested using function_usable().
2013-02-18Merge pull request #2256 from nisheeth-barthwal/developAndrey Andreev1-1/+47
Added keep-alive connection to SMTP. Fixed socket read/write timeouts. Added PHP useragent.
2013-02-18Removed the unused $force paramter in Email::_smtp_connect()nisheeth-barthwal1-29/+29
2013-02-18removed PR from the bug listnisheeth-barthwal1-1/+1
2013-02-18Fixed curly braces. Removed redundant method set_useragent()nisheeth-barthwal1-20/+11
2013-02-18Fixed tab-indentation. Made appropriate entries in changelognisheeth-barthwal1-283/+282
2013-02-18Fixed form helper variable errorBo-Yi Wu1-1/+1
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
2013-02-17Added keep-alive connection to SMTP. Fixed socket read/write timeouts. Added ↵nisheeth-barthwal1-234/+290
PHP useragent
2013-02-15Fix #2247Andrey Andreev1-6/+3
2013-02-15Fix some stuff from recent pull requestsAndrey Andreev3-12/+21
2013-02-15Merge pull request #2245 from maltzurra/patch-1Andrey Andreev1-2/+2
Fixed is_https() to avoid incorrect detection.
2013-02-15Merge pull request #2243 from chrispassas/developAndrey Andreev1-1/+6
Update system/core/Log.php
2013-02-15Revert "Update system/core/Common.php"Chris Passas1-2/+2
This reverts commit 8af05ac97513764cc539919e179794df87352c30.
2013-02-15Revert "Update system/core/Log.php"Chris Passas1-9/+2
This reverts commit bbc6ab4736a896be83e3e3d5f8856374ffa2984c.
2013-02-15Revert "Revert "Update system/core/Common.php""Chris Passas1-2/+2
This reverts commit 3de57eaea8510ea9cfd70f063565c24904669c4c.
2013-02-15Revert "Update system/core/Common.php"Chris Passas1-2/+2
This reverts commit 8af05ac97513764cc539919e179794df87352c30.
2013-02-15Update system/core/Common.phpChris Passas1-2/+2
If using nginx instead of apache by default nginx will not populate the $_SERVER['HTTPS'] value.  This change allows falling back to checking the port number of the request to determine if your on SSL or not. The other option is adding the following to your nginx config. fastcgi_param HTTPS on; #some php apps require this to detent https
2013-02-15Update system/core/Log.phpChris Passas1-1/+1
Added a space after the comma on the ltrim().
2013-02-15Various cosmetic fixesvlakoff6-7/+7
2013-02-14Update system/core/Common.phpmaltzurra1-2/+1
2013-02-14Update system/core/Common.phpmaltzurra1-1/+2
2013-02-14Update system/core/Log.phpChris Passas1-1/+4
Don't print no script access code into log file if log file is not .php anymore.
2013-02-14Update system/core/Log.phpChris Passas1-1/+1
Added ltrim() as requested to strip '.' incase it's added by mistake.
2013-02-14Update system/core/Common.phpmaltzurra1-2/+2
Updated is_https() to avoid "NULL" or "0" values to set HTTPS.