From 0c75c8219e42cf629036f73944901bd9f1f286bf Mon Sep 17 00:00:00 2001 From: Adam Jackett Date: Wed, 17 Jun 2015 10:42:23 -0400 Subject: removed unnecessary change to form_radio, updated docs and added changelog entry --- system/helpers/form_helper.php | 2 -- user_guide_src/source/changelog.rst | 12 +++++++++--- user_guide_src/source/helpers/form_helper.rst | 22 +++++++++++----------- 3 files changed, 20 insertions(+), 16 deletions(-) diff --git a/system/helpers/form_helper.php b/system/helpers/form_helper.php index c77069c55..f8c6a9dde 100644 --- a/system/helpers/form_helper.php +++ b/system/helpers/form_helper.php @@ -483,8 +483,6 @@ if ( ! function_exists('form_radio')) is_array($data) OR $data = array('name' => $data); $data['type'] = 'radio'; - $extra = _attributes_to_string($extra); - return form_checkbox($data, $value, $checked, $extra); } } diff --git a/user_guide_src/source/changelog.rst b/user_guide_src/source/changelog.rst index 5c2c4d944..ee1e36521 100644 --- a/user_guide_src/source/changelog.rst +++ b/user_guide_src/source/changelog.rst @@ -8,13 +8,19 @@ Version 3.0.1 Release Date: Not Released - Core - + - Added DoS mitigation to :php:func:`hash_pbkdf2()` :doc:`compatibility function `. -- Database - +- Database + - Added ``list_fields()`` support for SQLite ('sqlite3' and 'pdo_sqlite' drivers). +- Helpers + + - :doc:`Form Helper ` changes include: + + - Made all form helpers consistent by allowing an array to be passed for extra attributes. + Bug fixes for 3.0.1 ------------------- diff --git a/user_guide_src/source/helpers/form_helper.rst b/user_guide_src/source/helpers/form_helper.rst index 781e81f96..1c55f5692 100644 --- a/user_guide_src/source/helpers/form_helper.rst +++ b/user_guide_src/source/helpers/form_helper.rst @@ -191,7 +191,7 @@ The following functions are available: :param array $data: Field attributes data :param string $value: Field value - :param mixed $extra: Extra attributes to be added to the tag *as is* either as array or string + :param mixed $extra: Extra attributes to be added to the tag either as array or string :returns: An HTML text input field tag :rtype: string @@ -235,7 +235,7 @@ The following functions are available: :param array $data: Field attributes data :param string $value: Field value - :param mixed $extra: Extra attributes to be added to the tag *as is* either as array or string + :param mixed $extra: Extra attributes to be added to the tag either as array or string :returns: An HTML password input field tag :rtype: string @@ -247,7 +247,7 @@ The following functions are available: :param array $data: Field attributes data :param string $value: Field value - :param mixed $extra: Extra attributes to be added to the tag *as is* either as array or string + :param mixed $extra: Extra attributes to be added to the tag either as array or string :returns: An HTML file upload input field tag :rtype: string @@ -260,7 +260,7 @@ The following functions are available: :param array $data: Field attributes data :param string $value: Field value - :param mixed $extra: Extra attributes to be added to the tag *as is* either as array or string + :param mixed $extra: Extra attributes to be added to the tag either as array or string :returns: An HTML textarea tag :rtype: string @@ -275,7 +275,7 @@ The following functions are available: :param string $name: Field name :param array $options: An associative array of options to be listed :param array $selected: List of fields to mark with the *selected* attribute - :param mixed $extra: Extra attributes to be added to the tag *as is* either as array or string + :param mixed $extra: Extra attributes to be added to the tag either as array or string :returns: An HTML dropdown select field tag :rtype: string @@ -344,7 +344,7 @@ The following functions are available: :param string $name: Field name :param array $options: An associative array of options to be listed :param array $selected: List of fields to mark with the *selected* attribute - :param mixed $extra: Extra attributes to be added to the tag *as is* either as array or string + :param mixed $extra: Extra attributes to be added to the tag either as array or string :returns: An HTML dropdown multiselect field tag :rtype: string @@ -427,7 +427,7 @@ The following functions are available: :param array $data: Field attributes data :param string $value: Field value :param bool $checked: Whether to mark the checkbox as being *checked* - :param mixed $extra: Extra attributes to be added to the tag *as is* either as array or string + :param mixed $extra: Extra attributes to be added to the tag either as array or string :returns: An HTML checkbox input tag :rtype: string @@ -471,7 +471,7 @@ The following functions are available: :param array $data: Field attributes data :param string $value: Field value :param bool $checked: Whether to mark the radio button as being *checked* - :param mixed $extra: Extra attributes to be added to the tag *as is* either as array or string + :param mixed $extra: Extra attributes to be added to the tag either as array or string :returns: An HTML radio input tag :rtype: string @@ -510,7 +510,7 @@ The following functions are available: :param string $data: Button name :param string $value: Button value - :param mixed $extra: Extra attributes to be added to the tag *as is* either as array or string + :param mixed $extra: Extra attributes to be added to the tag either as array or string :returns: An HTML input submit tag :rtype: string @@ -528,7 +528,7 @@ The following functions are available: :param string $data: Button name :param string $value: Button value - :param mixed $extra: Extra attributes to be added to the tag *as is* either as array or string + :param mixed $extra: Extra attributes to be added to the tag either as array or string :returns: An HTML input reset button tag :rtype: string @@ -540,7 +540,7 @@ The following functions are available: :param string $data: Button name :param string $content: Button label - :param mixed $extra: Extra attributes to be added to the tag *as is* either as array or string + :param mixed $extra: Extra attributes to be added to the tag either as array or string :returns: An HTML button tag :rtype: string -- cgit v1.2.3-24-g4f1b