From 4070a63b74a515d2998d63989db57a15a1d9f742 Mon Sep 17 00:00:00 2001 From: Gwenael G Date: Fri, 23 Jan 2015 18:09:36 +0100 Subject: This $comment_clause local variable is declared but never used. --- system/database/drivers/pdo/subdrivers/pdo_mysql_forge.php | 2 -- 1 file changed, 2 deletions(-) diff --git a/system/database/drivers/pdo/subdrivers/pdo_mysql_forge.php b/system/database/drivers/pdo/subdrivers/pdo_mysql_forge.php index c90712a99..e8e24c6b3 100644 --- a/system/database/drivers/pdo/subdrivers/pdo_mysql_forge.php +++ b/system/database/drivers/pdo/subdrivers/pdo_mysql_forge.php @@ -199,8 +199,6 @@ class CI_DB_pdo_mysql_forge extends CI_DB_pdo_forge { $extra_clause = ' FIRST'; } - $comment_clause = isset($field['comment']) ? ' COMMENT ' . $field['comment'] : ''; - return $this->db->escape_identifiers($field['name']) .(empty($field['new_name']) ? '' : ' '.$this->db->escape_identifiers($field['new_name'])) .' '.$field['type'].$field['length'] -- cgit v1.2.3-24-g4f1b From 2f58ea641fd0a571688b164c5ee7f5fa65051684 Mon Sep 17 00:00:00 2001 From: Gwenael G Date: Fri, 23 Jan 2015 18:11:50 +0100 Subject: Fix error extends class name --- system/database/drivers/pdo/subdrivers/pdo_4d_forge.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/system/database/drivers/pdo/subdrivers/pdo_4d_forge.php b/system/database/drivers/pdo/subdrivers/pdo_4d_forge.php index 9ede03e10..9dc692c1e 100644 --- a/system/database/drivers/pdo/subdrivers/pdo_4d_forge.php +++ b/system/database/drivers/pdo/subdrivers/pdo_4d_forge.php @@ -44,7 +44,7 @@ defined('BASEPATH') OR exit('No direct script access allowed'); * @author EllisLab Dev Team * @link http://codeigniter.com/user_guide/database/ */ -class CI_DB_pdo_4d_forge extends CI_DB_4d_forge { +class CI_DB_pdo_4d_forge extends CI_DB_pdo_forge { /** * CREATE DATABASE statement -- cgit v1.2.3-24-g4f1b From f1294cb402dc35db9c9b26441807d851d0449970 Mon Sep 17 00:00:00 2001 From: Gwenael G Date: Fri, 23 Jan 2015 18:19:32 +0100 Subject: Corrected loop with the $c variable --- system/database/drivers/sqlite3/sqlite3_result.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/system/database/drivers/sqlite3/sqlite3_result.php b/system/database/drivers/sqlite3/sqlite3_result.php index f5c24672e..387481b7f 100644 --- a/system/database/drivers/sqlite3/sqlite3_result.php +++ b/system/database/drivers/sqlite3/sqlite3_result.php @@ -98,7 +98,7 @@ class CI_DB_sqlite3_result extends CI_DB_result { ); $retval = array(); - for ($i = 0, $c = $this->num_fields(); $i < $this->num_fields(); $i++) + for ($i = 0, $c = $this->num_fields(); $i < $c; $i++) { $retval[$i] = new stdClass(); $retval[$i]->name = $this->result_id->columnName($i); -- cgit v1.2.3-24-g4f1b