From a3f13b74fe88a899c476efd0d275cabaaac24ff2 Mon Sep 17 00:00:00 2001 From: Mian Saleem Date: Thu, 31 Jul 2014 18:16:20 +0800 Subject: anchor popup attribute missing Please add the menubar attribute to anchor popup --- system/helpers/url_helper.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/system/helpers/url_helper.php b/system/helpers/url_helper.php index 4493d5b97..f5a880c9b 100644 --- a/system/helpers/url_helper.php +++ b/system/helpers/url_helper.php @@ -213,7 +213,7 @@ if ( ! function_exists('anchor_popup')) $window_name = '_blank'; } - foreach (array('width' => '800', 'height' => '600', 'scrollbars' => 'yes', 'status' => 'yes', 'resizable' => 'yes', 'screenx' => '0', 'screeny' => '0') as $key => $val) + foreach (array('width' => '800', 'height' => '600', 'scrollbars' => 'yes', 'menubar' => 'yes', 'status' => 'yes', 'resizable' => 'yes', 'screenx' => '0', 'screeny' => '0') as $key => $val) { $atts[$key] = isset($attributes[$key]) ? $attributes[$key] : $val; unset($attributes[$key]); @@ -558,4 +558,4 @@ if ( ! function_exists('redirect')) } /* End of file url_helper.php */ -/* Location: ./system/helpers/url_helper.php */ \ No newline at end of file +/* Location: ./system/helpers/url_helper.php */ -- cgit v1.2.3-24-g4f1b From fc88a5f319d4c32f3ce9429293549e6c90a68440 Mon Sep 17 00:00:00 2001 From: Mian Saleem Date: Thu, 31 Jul 2014 22:08:07 +0800 Subject: Update url_helper.php --- system/helpers/url_helper.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/system/helpers/url_helper.php b/system/helpers/url_helper.php index f5a880c9b..04aacede5 100644 --- a/system/helpers/url_helper.php +++ b/system/helpers/url_helper.php @@ -213,7 +213,7 @@ if ( ! function_exists('anchor_popup')) $window_name = '_blank'; } - foreach (array('width' => '800', 'height' => '600', 'scrollbars' => 'yes', 'menubar' => 'yes', 'status' => 'yes', 'resizable' => 'yes', 'screenx' => '0', 'screeny' => '0') as $key => $val) + foreach (array('width' => '800', 'height' => '600', 'scrollbars' => 'yes', 'menubar' => 'no', 'status' => 'yes', 'resizable' => 'yes', 'screenx' => '0', 'screeny' => '0') as $key => $val) { $atts[$key] = isset($attributes[$key]) ? $attributes[$key] : $val; unset($attributes[$key]); -- cgit v1.2.3-24-g4f1b From ec70152e37aeaee25b37d84e663ab52ad874ca42 Mon Sep 17 00:00:00 2001 From: Mian Saleem Date: Thu, 31 Jul 2014 22:40:25 +0800 Subject: Support for menubar attribute to the :func:`anchor_popup()` Now the menubar can be set to yes with anchor_popup() by adding new attribute array element 'menubar' => 'yes' The list of all available attribute for anchor_popup() function will be $atts = array('width' => '800', 'height' => '600', 'scrollbars' => 'yes', 'menubar' => 'no', 'status' => 'yes', 'resizable' => 'yes', 'screenx' => '0', 'screeny' => '0'); --- user_guide_src/source/changelog.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/user_guide_src/source/changelog.rst b/user_guide_src/source/changelog.rst index d2bb195b6..0f56cc193 100644 --- a/user_guide_src/source/changelog.rst +++ b/user_guide_src/source/changelog.rst @@ -80,6 +80,7 @@ Release Date: Not Released - :func:`url_title()` will now trim extra dashes from beginning and end. - :func:`anchor_popup()` will now fill the *href* attribute with the URL and its JS code will return FALSE instead. - Added JS window name support to the :func:`anchor_popup()` function. + - Added support for menubar attribute to the :func:`anchor_popup()`. - Added support (auto-detection) for HTTP/1.1 response codes 303, 307 in :func:`redirect()`. - Changed :func:`redirect()` to choose the **refresh** method only on IIS servers, instead of all servers on Windows (when **auto** is used). - Changed :func:`anchor()`, :func:`anchor_popup()`, and :func:`redirect()` to support protocol-relative URLs (e.g. *//ellislab.com/codeigniter*). -- cgit v1.2.3-24-g4f1b -- cgit v1.2.3-24-g4f1b -- cgit v1.2.3-24-g4f1b From dc5fe5a179e41792a7fd4f2019e38bb13cddc675 Mon Sep 17 00:00:00 2001 From: Mian Saleem Date: Thu, 31 Jul 2014 23:30:24 +0800 Subject: Last empty line remove --- system/helpers/url_helper.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/system/helpers/url_helper.php b/system/helpers/url_helper.php index 04aacede5..0846472e7 100644 --- a/system/helpers/url_helper.php +++ b/system/helpers/url_helper.php @@ -558,4 +558,4 @@ if ( ! function_exists('redirect')) } /* End of file url_helper.php */ -/* Location: ./system/helpers/url_helper.php */ +/* Location: ./system/helpers/url_helper.php */ \ No newline at end of file -- cgit v1.2.3-24-g4f1b