From 2172c2049fc8b8eca5dbed7b659a089e20d1fadd Mon Sep 17 00:00:00 2001 From: Florian Pritz Date: Mon, 16 Sep 2013 16:43:13 +0200 Subject: Duser: Add some comments Signed-off-by: Florian Pritz --- application/libraries/Duser/drivers/Duser_db.php | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'application/libraries/Duser/drivers/Duser_db.php') diff --git a/application/libraries/Duser/drivers/Duser_db.php b/application/libraries/Duser/drivers/Duser_db.php index 1258ec585..5252ec48e 100644 --- a/application/libraries/Duser/drivers/Duser_db.php +++ b/application/libraries/Duser/drivers/Duser_db.php @@ -9,6 +9,10 @@ class Duser_db extends Duser_Driver { + /* FIXME: If you use this driver as a template, remove can_reset_password + * and can_register_new_users. These features require the DB driver and + * will NOT work with other drivers. + */ public $optional_functions = array( 'username_exists', 'can_reset_password', -- cgit v1.2.3-24-g4f1b From bb9f9274e8c2d661a1adffd87c87c3d81ec47b4d Mon Sep 17 00:00:00 2001 From: Florian Pritz Date: Mon, 16 Sep 2013 16:49:58 +0200 Subject: Duser: Rework optional functions Not implemented functions return null and code using these no longer has to check if they are implemented, but it has to handle null properly. Signed-off-by: Florian Pritz --- application/libraries/Duser/drivers/Duser_db.php | 2 -- 1 file changed, 2 deletions(-) (limited to 'application/libraries/Duser/drivers/Duser_db.php') diff --git a/application/libraries/Duser/drivers/Duser_db.php b/application/libraries/Duser/drivers/Duser_db.php index 5252ec48e..0f4298258 100644 --- a/application/libraries/Duser/drivers/Duser_db.php +++ b/application/libraries/Duser/drivers/Duser_db.php @@ -14,10 +14,8 @@ class Duser_db extends Duser_Driver { * will NOT work with other drivers. */ public $optional_functions = array( - 'username_exists', 'can_reset_password', 'can_register_new_users', - 'get_email', ); public function login($username, $password) -- cgit v1.2.3-24-g4f1b From 260da3941fafbe40877aa2ecb52169b460e0e644 Mon Sep 17 00:00:00 2001 From: Florian Pritz Date: Sun, 22 Sep 2013 12:17:06 +0200 Subject: duser_db: Remove case sensitive username check Signed-off-by: Florian Pritz --- application/libraries/Duser/drivers/Duser_db.php | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'application/libraries/Duser/drivers/Duser_db.php') diff --git a/application/libraries/Duser/drivers/Duser_db.php b/application/libraries/Duser/drivers/Duser_db.php index 0f4298258..a58b5a298 100644 --- a/application/libraries/Duser/drivers/Duser_db.php +++ b/application/libraries/Duser/drivers/Duser_db.php @@ -28,11 +28,7 @@ class Duser_db extends Duser_Driver { WHERE `username` = ? ', array($username))->row_array(); - if (!isset($query["username"]) || $query["username"] !== $username) { - return false; - } - - if (!isset($query["password"])) { + if (empty($query)) { return false; } -- cgit v1.2.3-24-g4f1b