From 26a4f99c3b579320a4bb321ac11eb891a194b44c Mon Sep 17 00:00:00 2001 From: Florian Pritz Date: Wed, 4 Sep 2013 23:39:14 +0200 Subject: Fix off-by-one error in random_alphanum() This could result in too short strings Signed-off-by: Florian Pritz --- application/helpers/filebin_helper.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'application') diff --git a/application/helpers/filebin_helper.php b/application/helpers/filebin_helper.php index 53fc4f280..bed696c8c 100644 --- a/application/helpers/filebin_helper.php +++ b/application/helpers/filebin_helper.php @@ -218,7 +218,7 @@ function random_alphanum($min_length, $max_length = null) for($i = 0; $i < $max_length; $i++) { if (strlen($random) == $length) break; - $random .= substr($char_list, mt_rand(0, strlen($char_list)), 1); + $random .= substr($char_list, mt_rand(0, strlen($char_list) - 1), 1); } return $random; } -- cgit v1.2.3-24-g4f1b