From 24fbc61e4a46c1e9f185c36629960dce0bad71e2 Mon Sep 17 00:00:00 2001 From: Zachary Flower Date: Sun, 2 Nov 2014 21:50:15 -0700 Subject: Add support for the COMMENT field in DBForge and MySQL Forge classes (pdo, mysql, and mysqli) Signed-off-by: Zachary Flower --- system/database/drivers/pdo/subdrivers/pdo_mysql_forge.php | 1 + 1 file changed, 1 insertion(+) (limited to 'system/database/drivers/pdo') diff --git a/system/database/drivers/pdo/subdrivers/pdo_mysql_forge.php b/system/database/drivers/pdo/subdrivers/pdo_mysql_forge.php index 6cdfcabb5..85b6ebe84 100644 --- a/system/database/drivers/pdo/subdrivers/pdo_mysql_forge.php +++ b/system/database/drivers/pdo/subdrivers/pdo_mysql_forge.php @@ -206,6 +206,7 @@ class CI_DB_pdo_mysql_forge extends CI_DB_pdo_forge { .$field['null'] .$field['default'] .$field['auto_increment'] + .$field['comment'] .$field['unique'] .$extra_clause; } -- cgit v1.2.3-24-g4f1b From 9b512288772f6e0f97fc4274f304132e8f8f5db2 Mon Sep 17 00:00:00 2001 From: Zachary Flower Date: Sun, 2 Nov 2014 21:51:19 -0700 Subject: Disable database COMMENT field by default in all other DB Forge drivers Signed-off-by: Zachary Flower --- system/database/drivers/pdo/subdrivers/pdo_4d_forge.php | 7 +++++++ system/database/drivers/pdo/subdrivers/pdo_cubrid_forge.php | 7 +++++++ system/database/drivers/pdo/subdrivers/pdo_dblib_forge.php | 7 +++++++ system/database/drivers/pdo/subdrivers/pdo_firebird_forge.php | 7 +++++++ system/database/drivers/pdo/subdrivers/pdo_ibm_forge.php | 7 +++++++ system/database/drivers/pdo/subdrivers/pdo_informix_forge.php | 7 +++++++ system/database/drivers/pdo/subdrivers/pdo_oci_forge.php | 7 +++++++ system/database/drivers/pdo/subdrivers/pdo_odbc_forge.php | 7 +++++++ system/database/drivers/pdo/subdrivers/pdo_pgsql_forge.php | 7 +++++++ system/database/drivers/pdo/subdrivers/pdo_sqlite_forge.php | 7 +++++++ system/database/drivers/pdo/subdrivers/pdo_sqlsrv_forge.php | 7 +++++++ 11 files changed, 77 insertions(+) (limited to 'system/database/drivers/pdo') diff --git a/system/database/drivers/pdo/subdrivers/pdo_4d_forge.php b/system/database/drivers/pdo/subdrivers/pdo_4d_forge.php index 840297450..1852c8fe9 100644 --- a/system/database/drivers/pdo/subdrivers/pdo_4d_forge.php +++ b/system/database/drivers/pdo/subdrivers/pdo_4d_forge.php @@ -100,6 +100,13 @@ class CI_DB_pdo_4d_forge extends CI_DB_4d_forge { */ protected $_default = FALSE; + /** + * COMMENT value representation in CREATE/ALTER TABLE statements + * + * @var string + */ + protected $_comment = FALSE; + // -------------------------------------------------------------------- /** diff --git a/system/database/drivers/pdo/subdrivers/pdo_cubrid_forge.php b/system/database/drivers/pdo/subdrivers/pdo_cubrid_forge.php index cc8d46273..89db1c393 100644 --- a/system/database/drivers/pdo/subdrivers/pdo_cubrid_forge.php +++ b/system/database/drivers/pdo/subdrivers/pdo_cubrid_forge.php @@ -92,6 +92,13 @@ class CI_DB_pdo_cubrid_forge extends CI_DB_pdo_forge { 'REAL' => 'DOUBLE' ); + /** + * COMMENT value representation in CREATE/ALTER TABLE statements + * + * @var string + */ + protected $_comment = FALSE; + // -------------------------------------------------------------------- /** diff --git a/system/database/drivers/pdo/subdrivers/pdo_dblib_forge.php b/system/database/drivers/pdo/subdrivers/pdo_dblib_forge.php index c0ee490ce..d9c766ec1 100644 --- a/system/database/drivers/pdo/subdrivers/pdo_dblib_forge.php +++ b/system/database/drivers/pdo/subdrivers/pdo_dblib_forge.php @@ -72,6 +72,13 @@ class CI_DB_pdo_dblib_forge extends CI_DB_pdo_forge { 'REAL' => 'FLOAT' ); + /** + * COMMENT value representation in CREATE/ALTER TABLE statements + * + * @var string + */ + protected $_comment = FALSE; + // -------------------------------------------------------------------- /** diff --git a/system/database/drivers/pdo/subdrivers/pdo_firebird_forge.php b/system/database/drivers/pdo/subdrivers/pdo_firebird_forge.php index 87f1586d7..358f0934a 100644 --- a/system/database/drivers/pdo/subdrivers/pdo_firebird_forge.php +++ b/system/database/drivers/pdo/subdrivers/pdo_firebird_forge.php @@ -71,6 +71,13 @@ class CI_DB_pdo_firebird_forge extends CI_DB_pdo_forge { */ protected $_null = 'NULL'; + /** + * COMMENT value representation in CREATE/ALTER TABLE statements + * + * @var string + */ + protected $_comment = FALSE; + // -------------------------------------------------------------------- /** diff --git a/system/database/drivers/pdo/subdrivers/pdo_ibm_forge.php b/system/database/drivers/pdo/subdrivers/pdo_ibm_forge.php index 3227602f4..043f77f53 100644 --- a/system/database/drivers/pdo/subdrivers/pdo_ibm_forge.php +++ b/system/database/drivers/pdo/subdrivers/pdo_ibm_forge.php @@ -71,6 +71,13 @@ class CI_DB_pdo_ibm_forge extends CI_DB_pdo_forge { */ protected $_default = FALSE; + /** + * COMMENT value representation in CREATE/ALTER TABLE statements + * + * @var string + */ + protected $_comment = FALSE; + // -------------------------------------------------------------------- /** diff --git a/system/database/drivers/pdo/subdrivers/pdo_informix_forge.php b/system/database/drivers/pdo/subdrivers/pdo_informix_forge.php index 9a6e9c8a4..393b64e48 100644 --- a/system/database/drivers/pdo/subdrivers/pdo_informix_forge.php +++ b/system/database/drivers/pdo/subdrivers/pdo_informix_forge.php @@ -73,6 +73,13 @@ class CI_DB_pdo_informix_forge extends CI_DB_pdo_forge { */ protected $_default = ', '; + /** + * COMMENT value representation in CREATE/ALTER TABLE statements + * + * @var string + */ + protected $_comment = FALSE; + // -------------------------------------------------------------------- /** diff --git a/system/database/drivers/pdo/subdrivers/pdo_oci_forge.php b/system/database/drivers/pdo/subdrivers/pdo_oci_forge.php index d4f33e144..895aec43d 100644 --- a/system/database/drivers/pdo/subdrivers/pdo_oci_forge.php +++ b/system/database/drivers/pdo/subdrivers/pdo_oci_forge.php @@ -74,6 +74,13 @@ class CI_DB_pdo_oci_forge extends CI_DB_pdo_forge { */ protected $_unsigned = FALSE; + /** + * COMMENT value representation in CREATE/ALTER TABLE statements + * + * @var string + */ + protected $_comment = FALSE; + // -------------------------------------------------------------------- /** diff --git a/system/database/drivers/pdo/subdrivers/pdo_odbc_forge.php b/system/database/drivers/pdo/subdrivers/pdo_odbc_forge.php index a9ff67fa8..083cfbcf3 100644 --- a/system/database/drivers/pdo/subdrivers/pdo_odbc_forge.php +++ b/system/database/drivers/pdo/subdrivers/pdo_odbc_forge.php @@ -53,6 +53,13 @@ class CI_DB_pdo_odbc_forge extends CI_DB_pdo_forge { */ protected $_unsigned = FALSE; + /** + * COMMENT value representation in CREATE/ALTER TABLE statements + * + * @var string + */ + protected $_comment = FALSE; + // -------------------------------------------------------------------- /** diff --git a/system/database/drivers/pdo/subdrivers/pdo_pgsql_forge.php b/system/database/drivers/pdo/subdrivers/pdo_pgsql_forge.php index 00579aab4..19497bb3a 100644 --- a/system/database/drivers/pdo/subdrivers/pdo_pgsql_forge.php +++ b/system/database/drivers/pdo/subdrivers/pdo_pgsql_forge.php @@ -77,6 +77,13 @@ class CI_DB_pdo_pgsql_forge extends CI_DB_pdo_forge { */ protected $_null = 'NULL'; + /** + * COMMENT value representation in CREATE/ALTER TABLE statements + * + * @var string + */ + protected $_comment = FALSE; + // -------------------------------------------------------------------- /** diff --git a/system/database/drivers/pdo/subdrivers/pdo_sqlite_forge.php b/system/database/drivers/pdo/subdrivers/pdo_sqlite_forge.php index f7bd99ed6..81c85940e 100644 --- a/system/database/drivers/pdo/subdrivers/pdo_sqlite_forge.php +++ b/system/database/drivers/pdo/subdrivers/pdo_sqlite_forge.php @@ -74,6 +74,13 @@ class CI_DB_pdo_sqlite_forge extends CI_DB_pdo_forge { */ protected $_null = 'NULL'; + /** + * COMMENT value representation in CREATE/ALTER TABLE statements + * + * @var string + */ + protected $_comment = FALSE; + // -------------------------------------------------------------------- /** diff --git a/system/database/drivers/pdo/subdrivers/pdo_sqlsrv_forge.php b/system/database/drivers/pdo/subdrivers/pdo_sqlsrv_forge.php index b0b08a136..7adeda8ab 100644 --- a/system/database/drivers/pdo/subdrivers/pdo_sqlsrv_forge.php +++ b/system/database/drivers/pdo/subdrivers/pdo_sqlsrv_forge.php @@ -72,6 +72,13 @@ class CI_DB_pdo_sqlsrv_forge extends CI_DB_pdo_forge { 'REAL' => 'FLOAT' ); + /** + * COMMENT value representation in CREATE/ALTER TABLE statements + * + * @var string + */ + protected $_comment = FALSE; + // -------------------------------------------------------------------- /** -- cgit v1.2.3-24-g4f1b From 12ee7a1a74e45b1369876ea945ae3347da046087 Mon Sep 17 00:00:00 2001 From: Zachary Flower Date: Mon, 3 Nov 2014 08:38:41 -0700 Subject: Move comment field after unique field in db forge --- system/database/drivers/pdo/subdrivers/pdo_mysql_forge.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'system/database/drivers/pdo') diff --git a/system/database/drivers/pdo/subdrivers/pdo_mysql_forge.php b/system/database/drivers/pdo/subdrivers/pdo_mysql_forge.php index 85b6ebe84..2152dea30 100644 --- a/system/database/drivers/pdo/subdrivers/pdo_mysql_forge.php +++ b/system/database/drivers/pdo/subdrivers/pdo_mysql_forge.php @@ -206,8 +206,8 @@ class CI_DB_pdo_mysql_forge extends CI_DB_pdo_forge { .$field['null'] .$field['default'] .$field['auto_increment'] - .$field['comment'] .$field['unique'] + .$field['comment'] .$extra_clause; } -- cgit v1.2.3-24-g4f1b From e4b10bf0ad59049ed78ed9cfc5f708188f3cd442 Mon Sep 17 00:00:00 2001 From: Zachary Flower Date: Mon, 3 Nov 2014 10:42:57 -0700 Subject: Move MySQL comments to MySQL forge classes only --- system/database/drivers/pdo/subdrivers/pdo_mysql_forge.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'system/database/drivers/pdo') diff --git a/system/database/drivers/pdo/subdrivers/pdo_mysql_forge.php b/system/database/drivers/pdo/subdrivers/pdo_mysql_forge.php index 2152dea30..2e988c3f5 100644 --- a/system/database/drivers/pdo/subdrivers/pdo_mysql_forge.php +++ b/system/database/drivers/pdo/subdrivers/pdo_mysql_forge.php @@ -199,6 +199,8 @@ class CI_DB_pdo_mysql_forge extends CI_DB_pdo_forge { $extra_clause = ' FIRST'; } + $comment_clause = isset($field['comment']) ? ' COMMENT ' . $field['comment'] : ''; + return $this->db->escape_identifiers($field['name']) .(empty($field['new_name']) ? '' : ' '.$this->db->escape_identifiers($field['new_name'])) .' '.$field['type'].$field['length'] @@ -207,7 +209,7 @@ class CI_DB_pdo_mysql_forge extends CI_DB_pdo_forge { .$field['default'] .$field['auto_increment'] .$field['unique'] - .$field['comment'] + .$comment_clause .$extra_clause; } -- cgit v1.2.3-24-g4f1b From ce8aa3b5abe0b20da7dbee70fb49f440ad41b15c Mon Sep 17 00:00:00 2001 From: Zachary Flower Date: Mon, 3 Nov 2014 10:43:28 -0700 Subject: Remove comment field definition from all other forge classes --- system/database/drivers/pdo/subdrivers/pdo_4d_forge.php | 7 ------- system/database/drivers/pdo/subdrivers/pdo_cubrid_forge.php | 7 ------- system/database/drivers/pdo/subdrivers/pdo_dblib_forge.php | 7 ------- system/database/drivers/pdo/subdrivers/pdo_firebird_forge.php | 7 ------- system/database/drivers/pdo/subdrivers/pdo_ibm_forge.php | 7 ------- system/database/drivers/pdo/subdrivers/pdo_informix_forge.php | 7 ------- system/database/drivers/pdo/subdrivers/pdo_oci_forge.php | 7 ------- system/database/drivers/pdo/subdrivers/pdo_odbc_forge.php | 7 ------- system/database/drivers/pdo/subdrivers/pdo_pgsql_forge.php | 7 ------- system/database/drivers/pdo/subdrivers/pdo_sqlite_forge.php | 7 ------- system/database/drivers/pdo/subdrivers/pdo_sqlsrv_forge.php | 7 ------- 11 files changed, 77 deletions(-) (limited to 'system/database/drivers/pdo') diff --git a/system/database/drivers/pdo/subdrivers/pdo_4d_forge.php b/system/database/drivers/pdo/subdrivers/pdo_4d_forge.php index 1852c8fe9..840297450 100644 --- a/system/database/drivers/pdo/subdrivers/pdo_4d_forge.php +++ b/system/database/drivers/pdo/subdrivers/pdo_4d_forge.php @@ -100,13 +100,6 @@ class CI_DB_pdo_4d_forge extends CI_DB_4d_forge { */ protected $_default = FALSE; - /** - * COMMENT value representation in CREATE/ALTER TABLE statements - * - * @var string - */ - protected $_comment = FALSE; - // -------------------------------------------------------------------- /** diff --git a/system/database/drivers/pdo/subdrivers/pdo_cubrid_forge.php b/system/database/drivers/pdo/subdrivers/pdo_cubrid_forge.php index 89db1c393..cc8d46273 100644 --- a/system/database/drivers/pdo/subdrivers/pdo_cubrid_forge.php +++ b/system/database/drivers/pdo/subdrivers/pdo_cubrid_forge.php @@ -92,13 +92,6 @@ class CI_DB_pdo_cubrid_forge extends CI_DB_pdo_forge { 'REAL' => 'DOUBLE' ); - /** - * COMMENT value representation in CREATE/ALTER TABLE statements - * - * @var string - */ - protected $_comment = FALSE; - // -------------------------------------------------------------------- /** diff --git a/system/database/drivers/pdo/subdrivers/pdo_dblib_forge.php b/system/database/drivers/pdo/subdrivers/pdo_dblib_forge.php index d9c766ec1..c0ee490ce 100644 --- a/system/database/drivers/pdo/subdrivers/pdo_dblib_forge.php +++ b/system/database/drivers/pdo/subdrivers/pdo_dblib_forge.php @@ -72,13 +72,6 @@ class CI_DB_pdo_dblib_forge extends CI_DB_pdo_forge { 'REAL' => 'FLOAT' ); - /** - * COMMENT value representation in CREATE/ALTER TABLE statements - * - * @var string - */ - protected $_comment = FALSE; - // -------------------------------------------------------------------- /** diff --git a/system/database/drivers/pdo/subdrivers/pdo_firebird_forge.php b/system/database/drivers/pdo/subdrivers/pdo_firebird_forge.php index 358f0934a..87f1586d7 100644 --- a/system/database/drivers/pdo/subdrivers/pdo_firebird_forge.php +++ b/system/database/drivers/pdo/subdrivers/pdo_firebird_forge.php @@ -71,13 +71,6 @@ class CI_DB_pdo_firebird_forge extends CI_DB_pdo_forge { */ protected $_null = 'NULL'; - /** - * COMMENT value representation in CREATE/ALTER TABLE statements - * - * @var string - */ - protected $_comment = FALSE; - // -------------------------------------------------------------------- /** diff --git a/system/database/drivers/pdo/subdrivers/pdo_ibm_forge.php b/system/database/drivers/pdo/subdrivers/pdo_ibm_forge.php index 043f77f53..3227602f4 100644 --- a/system/database/drivers/pdo/subdrivers/pdo_ibm_forge.php +++ b/system/database/drivers/pdo/subdrivers/pdo_ibm_forge.php @@ -71,13 +71,6 @@ class CI_DB_pdo_ibm_forge extends CI_DB_pdo_forge { */ protected $_default = FALSE; - /** - * COMMENT value representation in CREATE/ALTER TABLE statements - * - * @var string - */ - protected $_comment = FALSE; - // -------------------------------------------------------------------- /** diff --git a/system/database/drivers/pdo/subdrivers/pdo_informix_forge.php b/system/database/drivers/pdo/subdrivers/pdo_informix_forge.php index 393b64e48..9a6e9c8a4 100644 --- a/system/database/drivers/pdo/subdrivers/pdo_informix_forge.php +++ b/system/database/drivers/pdo/subdrivers/pdo_informix_forge.php @@ -73,13 +73,6 @@ class CI_DB_pdo_informix_forge extends CI_DB_pdo_forge { */ protected $_default = ', '; - /** - * COMMENT value representation in CREATE/ALTER TABLE statements - * - * @var string - */ - protected $_comment = FALSE; - // -------------------------------------------------------------------- /** diff --git a/system/database/drivers/pdo/subdrivers/pdo_oci_forge.php b/system/database/drivers/pdo/subdrivers/pdo_oci_forge.php index 895aec43d..d4f33e144 100644 --- a/system/database/drivers/pdo/subdrivers/pdo_oci_forge.php +++ b/system/database/drivers/pdo/subdrivers/pdo_oci_forge.php @@ -74,13 +74,6 @@ class CI_DB_pdo_oci_forge extends CI_DB_pdo_forge { */ protected $_unsigned = FALSE; - /** - * COMMENT value representation in CREATE/ALTER TABLE statements - * - * @var string - */ - protected $_comment = FALSE; - // -------------------------------------------------------------------- /** diff --git a/system/database/drivers/pdo/subdrivers/pdo_odbc_forge.php b/system/database/drivers/pdo/subdrivers/pdo_odbc_forge.php index 083cfbcf3..a9ff67fa8 100644 --- a/system/database/drivers/pdo/subdrivers/pdo_odbc_forge.php +++ b/system/database/drivers/pdo/subdrivers/pdo_odbc_forge.php @@ -53,13 +53,6 @@ class CI_DB_pdo_odbc_forge extends CI_DB_pdo_forge { */ protected $_unsigned = FALSE; - /** - * COMMENT value representation in CREATE/ALTER TABLE statements - * - * @var string - */ - protected $_comment = FALSE; - // -------------------------------------------------------------------- /** diff --git a/system/database/drivers/pdo/subdrivers/pdo_pgsql_forge.php b/system/database/drivers/pdo/subdrivers/pdo_pgsql_forge.php index 19497bb3a..00579aab4 100644 --- a/system/database/drivers/pdo/subdrivers/pdo_pgsql_forge.php +++ b/system/database/drivers/pdo/subdrivers/pdo_pgsql_forge.php @@ -77,13 +77,6 @@ class CI_DB_pdo_pgsql_forge extends CI_DB_pdo_forge { */ protected $_null = 'NULL'; - /** - * COMMENT value representation in CREATE/ALTER TABLE statements - * - * @var string - */ - protected $_comment = FALSE; - // -------------------------------------------------------------------- /** diff --git a/system/database/drivers/pdo/subdrivers/pdo_sqlite_forge.php b/system/database/drivers/pdo/subdrivers/pdo_sqlite_forge.php index 81c85940e..f7bd99ed6 100644 --- a/system/database/drivers/pdo/subdrivers/pdo_sqlite_forge.php +++ b/system/database/drivers/pdo/subdrivers/pdo_sqlite_forge.php @@ -74,13 +74,6 @@ class CI_DB_pdo_sqlite_forge extends CI_DB_pdo_forge { */ protected $_null = 'NULL'; - /** - * COMMENT value representation in CREATE/ALTER TABLE statements - * - * @var string - */ - protected $_comment = FALSE; - // -------------------------------------------------------------------- /** diff --git a/system/database/drivers/pdo/subdrivers/pdo_sqlsrv_forge.php b/system/database/drivers/pdo/subdrivers/pdo_sqlsrv_forge.php index 7adeda8ab..b0b08a136 100644 --- a/system/database/drivers/pdo/subdrivers/pdo_sqlsrv_forge.php +++ b/system/database/drivers/pdo/subdrivers/pdo_sqlsrv_forge.php @@ -72,13 +72,6 @@ class CI_DB_pdo_sqlsrv_forge extends CI_DB_pdo_forge { 'REAL' => 'FLOAT' ); - /** - * COMMENT value representation in CREATE/ALTER TABLE statements - * - * @var string - */ - protected $_comment = FALSE; - // -------------------------------------------------------------------- /** -- cgit v1.2.3-24-g4f1b