From 2f304d6119e022abd5bd29e6a9980b7c81a27586 Mon Sep 17 00:00:00 2001 From: Derek Allard Date: Mon, 5 Jul 2010 07:40:26 -0400 Subject: altering a few examples to be more CI driven then EE driven in styleguide --- user_guide/general/styleguide.html | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) (limited to 'user_guide/general/styleguide.html') diff --git a/user_guide/general/styleguide.html b/user_guide/general/styleguide.html index 5be636a4e..1200a2c12 100644 --- a/user_guide/general/styleguide.html +++ b/user_guide/general/styleguide.html @@ -88,7 +88,7 @@ Style Guide
  • Line Breaks
  • Code Indenting
  • Bracket and Parenthetic Spacing
  • -
  • Localized Text in Control Panel
  • +
  • Localized Text
  • Private Methods and Variables
  • PHP Errors
  • Short Open Tags
  • @@ -96,7 +96,6 @@ Style Guide
  • Strings
  • SQL Queries
  • Default Function Arguments
  • -
  • Overlapping Tag Parameters
  • @@ -535,15 +534,15 @@ foreach ($query->result() as $row) // single space following PHP control structu -

    Localized Text in Control Panel

    +

    Localized Text

    -

    Any text that is output in the control panel should use language variables in your module's lang file to allow localization.

    +

    Any text that is output in the control panel should use language variables in your lang file to allow localization.

    INCORRECT: return "Invalid Selection"; CORRECT: -return $LANG->line('invalid_selection'); +return $this->lang->line('invalid_selection');
    @@ -657,12 +656,6 @@ $query = $this->db->query("SELECT foo, bar, baz, foofoo, foobar AS raboof, fooba - -

    Overlapping Tag Parameters

    -
    -

    Avoid multiple tag parameters that have effect on the same thing. For instance, instead of include= and exclude=, perhaps allow include= to handle the parameter alone, with the addition of "not", e.g. include="not bar". This will prevent problems of parameters overlapping or having to worry about which parameter has priority over another.

    -
    - -- cgit v1.2.3-24-g4f1b