functions: remove cruft from in_array

the for loop is already a NOOP when the haystack is empty, so it already
falls through to the return 1.

Signed-off-by: Dave Reisner <dreisner@archlinux.org>

1 files changed, 2 insertions, 3 deletions

diff --git a/functions b/functions
index ac7da7e..ffb00ec 100644
--- a/functions
+++ b/functions
@@ -46,9 +46,8 @@ in_array() {
     #   $1: needle
     #   ${@:2}: haystack
 
-    local needle=$1; shift
-    [[ -z $1 ]] && return 1 # Not Found
-    local item
+    local item= needle=$1; shift
+
     for item in "$@"; do
         [[ $item = $needle ]] && return 0 # Found
     done