diff options
author | Dave Reisner <dreisner@archlinux.org> | 2012-05-03 20:14:42 +0200 |
---|---|---|
committer | Dave Reisner <dreisner@archlinux.org> | 2012-05-12 15:30:32 +0200 |
commit | 41a290ce22844ac6b1d021b04df5f7659547cc56 (patch) | |
tree | fb39185340dec265d0cc7f603718a3fa779f8521 /bash-completion | |
parent | b317b01465d81b2adadd5f8d964e59622a6a7a32 (diff) | |
download | mkinitcpio-41a290ce22844ac6b1d021b04df5f7659547cc56.tar.gz mkinitcpio-41a290ce22844ac6b1d021b04df5f7659547cc56.tar.xz |
mkinitcpio: remove --basedir option
This option is just a bad idea. Initramfs creation is too important to
get wrong, and running it from outside the root FS has too many gotchas,
the worst of them being:
- where do you pull hooks from?
- how do you resolve binary dependencies within the root?
In general, dealing with the extra luggage of the base directory makes the
codebase more complicated than it needs to be (see all the '_' prefixed
functions which are called from add functions). In favor of simplifying the
code, and making it more maintainable, kill this off and force the sane
option of chroot'ing into an install if the need arises.
Signed-off-by: Dave Reisner <dreisner@archlinux.org>
Diffstat (limited to 'bash-completion')
-rw-r--r-- | bash-completion | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/bash-completion b/bash-completion index 9732747..c37484c 100644 --- a/bash-completion +++ b/bash-completion @@ -54,20 +54,19 @@ _files_from_dirs() { _mkinitcpio() { local action cur prev opts - opts=(-A --add -b --basedir -c --config -g --generate -H --hookhelp - -h --help -k --kernel -L --listhooks -M --automods -n --nocolor - -p --preset -S --skiphooks -s --save -t --builddir -v --verbose - -z --compress) + opts=(-A --add -c --config -g --generate -H --hookhelp -h --help -k --kernel + -L --listhooks -M --automods -n --nocolor -p --preset -S --skiphooks + -s --save -t --builddir -v --verbose -z --compress) _get_comp_words_by_ref cur prev case $prev in -[cg]|--config|--generate) _filedir ;; + -t|--builddir) + _filedir -d ;; -k|--kernel) _find_kernel_versions ;; - -[bt]|--basedir|--builddir) - _filedir -d ;; -p|--preset) COMPREPLY=($(compgen -W "$(_files_from_dirs -s .preset /etc/mkinitcpio.d)" -- "$cur")) ;; -[AHS]|--add|--hookhelp|--skiphooks) |