diff options
| author | Dave Reisner <dreisner@archlinux.org> | 2012-05-03 20:14:42 +0200 |
|---|---|---|
| committer | Dave Reisner <dreisner@archlinux.org> | 2012-05-12 15:30:32 +0200 |
| commit | 41a290ce22844ac6b1d021b04df5f7659547cc56 (patch) | |
| tree | fb39185340dec265d0cc7f603718a3fa779f8521 /install/autodetect | |
| parent | b317b01465d81b2adadd5f8d964e59622a6a7a32 (diff) | |
| download | mkinitcpio-41a290ce22844ac6b1d021b04df5f7659547cc56.tar.gz mkinitcpio-41a290ce22844ac6b1d021b04df5f7659547cc56.tar.xz | |
mkinitcpio: remove --basedir option
This option is just a bad idea. Initramfs creation is too important to
get wrong, and running it from outside the root FS has too many gotchas,
the worst of them being:
- where do you pull hooks from?
- how do you resolve binary dependencies within the root?
In general, dealing with the extra luggage of the base directory makes the
codebase more complicated than it needs to be (see all the '_' prefixed
functions which are called from add functions). In favor of simplifying the
code, and making it more maintainable, kill this off and force the sane
option of chroot'ing into an install if the need arises.
Signed-off-by: Dave Reisner <dreisner@archlinux.org>
Diffstat (limited to 'install/autodetect')
| -rw-r--r-- | install/autodetect | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/install/autodetect b/install/autodetect index 4ed7ccf..1daa429 100644 --- a/install/autodetect +++ b/install/autodetect @@ -25,7 +25,7 @@ build() { auto_modules >"$MODULE_FILE" # detect filesystem for root - if rootfstype=$(findmnt -uno fstype "${BASEDIR:-/}"); then + if rootfstype=$(findmnt -uno fstype '/'); then add_if_avail "$rootfstype" else error "failed to detect root filesystem" @@ -33,7 +33,7 @@ build() { fi # detect filesystem for separate /usr - if usrfstype=$(findmnt -snero fstype --tab-file "$BASEDIR/etc/fstab" /usr); then + if usrfstype=$(findmnt -snero fstype --tab-file '/etc/fstab' /usr); then add_if_avail "$usrfstype" fi |