summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJouke Witteveen <j.witteveen@gmail.com>2013-04-23 11:02:06 +0200
committerJouke Witteveen <j.witteveen@gmail.com>2013-04-23 11:02:06 +0200
commitf69e0bd186f9243ff71ba8b39fa24a3ef98f640d (patch)
tree7fc268c18e1056a13a68084a91c798c97df48fe4
parente01b395b0a297edd4b865f83fc1ada84a37f7458 (diff)
downloadnetctl-f69e0bd186f9243ff71ba8b39fa24a3ef98f640d.tar.gz
netctl-f69e0bd186f9243ff71ba8b39fa24a3ef98f640d.tar.xz
Small review of PPP related connections (take 2)
The previous take did not contain the stuff that initially motivated rewriting the quoting function. The code of both PPP connection types is still sub-par, but at least functionally, it is a little better now.
-rw-r--r--src/lib/connections/mobile_ppp2
-rw-r--r--src/lib/connections/pppoe2
2 files changed, 2 insertions, 2 deletions
diff --git a/src/lib/connections/mobile_ppp b/src/lib/connections/mobile_ppp
index d117367..cd82c64 100644
--- a/src/lib/connections/mobile_ppp
+++ b/src/lib/connections/mobile_ppp
@@ -7,7 +7,7 @@
quote_word() {
set -- "${@//\\/\\\\}"
- printf '"%s"\n' "${@/\"/\\\"}"
+ printf '"%s"\n' "${@//\"/\\\"}"
}
mobile_ppp_up() {
diff --git a/src/lib/connections/pppoe b/src/lib/connections/pppoe
index 177f575..87f9ee5 100644
--- a/src/lib/connections/pppoe
+++ b/src/lib/connections/pppoe
@@ -4,7 +4,7 @@
quote_word() {
set -- "${@//\\/\\\\}"
- printf '"%s"\n' "${@/\"/\\\"}"
+ printf '"%s"\n' "${@//\"/\\\"}"
}
pppoe_up() {