summaryrefslogtreecommitdiffstats
path: root/src/connections
AgeCommit message (Collapse)AuthorFilesLines
2009-09-07Lots of little tweaks that should never hurt. Some of them may help inJames Rayner3-20/+23
corner cases; others probably make no difference. Signed-off-by: Jim Pryor <profjim@jimpryor.net>
2009-09-07respect TMPDIRJim Pryor1-1/+1
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
2009-08-15quotes!Jim Pryor4-55/+55
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
2009-08-15Isolate ip to ethernet-iproute, ifconfig to ethernet + wirelessJim Pryor2-10/+10
* The point of having both ethernet and ethernet-iproute was presumably to transition slowly from ifconfig/net-tools to iproute2. But the current codebase mixes the two in handling ethernet and wireless connections. This commit separates all the ip calls to the newer connections, and the ifconfig calls to the older connections. The latter now call set_interface with up-old, down-old, forcedown-old. * I'm not urging that ifconfig code sticks around. Just trying to make the code consistent with what seems to me to be its implicit design principles. * the check for NO-CARRIER in ethernet is now also done without calling iproute2 tools. I saw this technique recommended somewhere but have no citation. I don't know how many kernel revisions one can rely on any given part of /sys to remain stable for. It may be possible to achieve the same goal here in other ways. If in fact it's worth the effort to keep the ifconfig code around. * Began also to integrate the IPROUTE variable introduced in ethernet, but stopped. If that's integrated everywhere, shouldn't it make connection=ethernet equivalent to connection=ethernet-iproute? Is there justification for using it at some places but not everywhere? I just let it alone for now. Signed-off-by: Jim Pryor <profjim@jimpryor.net>
2009-08-15start consolidation of ifconfig/ip/set_interfaceJim Pryor3-13/+33
* try to factor all the ifconfig/ip set dev code to single location (currently networks/set_interface, though I recommend a different name for this function because it's too close in name and different in functionality from set_iface, set_profile). * added "forcedown" option to set_interface, meaning "just go down don't worry about 'nodown' quirks" * even with "forcedown", this factoring would introduce "ip addr flush dev $INTERFACE" calls to existing code. I assume that's harmless? or even beneficial? * one code block (in ethernet_iproute) had stdout,stderr of the down calls redirected to /dev/null. I've moved that to set_interface, so now everyone's getting that behavior. I assume that's appropriate... * now no more calls to "ip" or "ifconfig" outside of set_interface, except the checks for NO-CARRIER after ethernet*/set_interface up. They might also be moved to network/set_interface? * as of this commit, all the set_interface calls are now using ip instead of ifconfig. A subsequent commit will isolate the ip-use to ethernet-iproute and the ifconfig-use to ethernet. * ALERT: attend to wireless_down, it seems to be calling set_interface down twice (once in ethernet_down, once in itself). And neither this commit nor the code it's patching respects quirk nodown in the ethernet_down block. Signed-off-by: Jim Pryor <profjim@jimpryor.net>
2009-08-15Add AP argument to profile, also let ESSID arguments be regexpsJim Pryor1-9/+39
* AP= arguments in profiles take precedence over ESSID= arguments * ESSID= arguments regexps instead of literals. To avoid screwing up any currently working profiles, I restricted the interpretation as a regexp to just the new wireless-dbus connection types. * But a global change involved in implementing this is that the connection up/down calls will be passed a literal ESSID (which of the local networks matches the regexp) as an additional argument. Signed-off-by: Jim Pryor <profjim@jimpryor.net>
2009-08-15Improve debugging and error-reporting.Jim Pryor3-12/+13
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
2009-08-15grep tweaksJim Pryor3-8/+8
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
2009-08-15More secure temp WPA_CONFIG fileJim Pryor1-15/+13
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
2009-08-15Don't overwrite existing $WEP_OPTSJim Pryor1-5/+7
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
2009-08-15ethernet_up will create resolv.conf also for $DNSJim Pryor1-1/+1
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
2009-08-15Sanitize quotes for wpa_startJim Pryor1-0/+5
Arguments to wpa_start shouldn't be expanded until wpa_start receives them: so should be quoted by all calling functions. I added quotes throughout. In general, it seems wise to quote except when it's absolutely certain not to be needed---or you specifically _do_ want to expand arguments. In this case, it's extra important. Because this might be missed in later code, I also wrangled wpa_start so that it doesn't rely on WPA_OPTS being all in $3. One of these fixes would have sufficed, but what the hell I did both. Signed-off-by: Jim Pryor <profjim@jimpryor.net>
2009-08-15wpa_cli, start/stop_wpa, wpa_check tweaksJim Pryor3-11/+14
* Supply -i switch to wpa_cli * Have wpa_check call stop_wpa on failure, instead of duplicating (only some of) the termination code. * Need brief sleep in termination code. * Note that functions which call wpa_check don't need to call stop_wpa themselves, when wpa_check fails. * Functions which call wpa_check and start_wpa are however responsible for all error reporting on failure. * Add some debugging calls to announce calls to wpa_start/wpa_check Signed-off-by: Jim Pryor <profjim@jimpryor.net>
2009-08-10Add interface setting, a debug mode and interface setting hooksJames Rayner3-14/+5
2009-08-10merge improved find_ap/find_essidJames Rayner1-3/+3
2009-08-10merge logging code from Jim PryorJames Rayner3-43/+100
2009-08-10Add wireless+iproute support, extend wait for some slower cardsJames Rayner3-6/+10
2009-08-10Added basic rfkill support; prototype connection query supportJames Rayner3-1/+58
2009-06-27Workaround for FS#15072James Rayner1-1/+1
2009-06-06Another attempt at a working link check, FS#13334James Rayner2-21/+10
2009-05-18fixed typo by Robson Roberto Souza PeixotoAndrea Scarpino1-1/+1
2009-05-18wireless: check if iface is real, stop wpa_supplicant on failuresJames Rayner1-8/+20
2009-05-07remove infinite loop causing wireless to failJames Rayner1-5/+0
2009-04-29undo WPA and ethernetAndrea Scarpino1-1/+12
2009-04-29ethernet doesn't need check for wpaAndrea Scarpino1-12/+0
2009-04-29set SECURITY to none if not setAndrea Scarpino1-0/+3
2009-04-28Fix cable check and handle devices which take some time to report state=up. ↵James Rayner2-13/+22
FS#13334
2009-04-28Add WEP support to wireless-dbus, remove broken interface type check in wirelessJames Rayner1-5/+0
2009-02-26Update and re-arrange examples, update wireless quirk options, stopJames Rayner2-43/+42
using deprecated sys interface
2009-02-17fix netcfg-auto-wireless and a temporary workaround for FS#13299James Rayner1-4/+4
2009-02-16FS#11748 -netcfg takes interface down too earlyJames Rayner2-2/+6
2009-02-16FS#13165 - netcfg creates bad wpa_supplicant config when using full hex keyJames Rayner1-1/+1
2009-02-16remove typoJames Rayner1-1/+0
2009-02-16various fixes, and new quirk 'noacheck'James Rayner3-17/+19
2008-12-25cleanups in ethernet connection typeJames Rayner1-24/+22
2008-12-22add iproute enabled ethernet connection type, fix makefile for new wirelessJames Rayner1-0/+119
2008-12-18Arrange tree for future packagingJames Rayner1-137/+0
2008-12-18Add early wireless via dbus/wpa_supplicant supportJames Rayner1-0/+137
2008-12-18use arguments to scripts rather than sourcing in connection functionsJames Rayner3-7/+20
2008-12-18FS11818, improve key handling, use subshells to avoid scope issues after libifyJames Rayner1-1/+1
2008-12-18Add option to pass arbitrary ifconfig arguments when using dhcpJames Rayner1-1/+1
2008-12-18fix libifyJames Rayner3-0/+259