Age | Commit message (Collapse) | Author | Files | Lines |
|
$STATE_DIR/last_profile was unused and functionality one could want from it will soon be provided by netcfg-daemon.
|
|
This should fix FS#30361 along the way.
|
|
After this change, a profile started by a previous version of netcfg can potentially not be brought down anymore. This only concerns the updating process. Running `netcfg clean` should make everything OK again (potentially leaving your network down, but you can now bring up profiles again).
|
|
Suggestion by Dave Reisner.
|
|
Good drivers indicate when they're up by the IFF_UP flag.
This is the end of the (undocumented) UP_SLEEP variable and introduction of the UP_TIMEOUT (in seconds, default: 5) variable.
This has 'noticeable speed improvement'-potential.
|
|
This was the result of commit b6964 which said to fix FS#17406 by reverting to the subshell-less for-loop that is once again removed in this commit.
The real fix to FS#17406 was commit c3276 to the initscripts repository.
|
|
Configuration is done through /etc/conf.d/netcfg.
Compatibility with configuration through /etc/rc.conf is dropped.
|
|
/etc/rc.d/functions is owned by initscripts on which netcfg does not explicitly depend.
The revised layout is inspired by systemd.
|
|
|
|
It is now possible to reconnect based on the name of the interface.
|
|
|
|
Signed-off-by: Rémy Oudompheng <remy@archlinux.org>
|
|
Avoid duplicating function names in docstrings, and adopt a
style similar to doxygen.
Signed-off-by: Rémy Oudompheng <remy@archlinux.org>
|
|
Signed-off-by: Jesse Young <jesse.young@gmail.com>
|
|
|
|
|
|
Was the intent for is_interface to be passed the INTERFACE as a
parameter (that's how it's called in most or all places)? Or to read
INTERFACE from the current environment? That's how it's implemented.
Also made INTERFACE in bring_interface a local variable. I don't think
this should break anything, but I'm only 95% confident.
|
|
|
|
|
|
CONFIGSECTION will be useful later on for integration with autowifi.
It'll allow WPA configurations to be stored _in_ the profile, rather
than separately.
Experimentally, WEP/none support has been migrated to wpa_supplicant.
Support for string keys has not yet been merged.
|
|
|
|
3. Change the name of "set_interface up/down..." to "bring_interface
up/down" to differentiate it from the similarly-named, merely record-keeping functions.
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
|
|
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
|
|
When we're sourcing a profile just to obtain a single variable, use the
form:
INTERFACE=$(. "$DIR/$profile"; echo "$INTERFACE")
This makes it clearer in the source what we're expecting to obtain from
the profile, and what we're ignoring. Also allows us to eliminate some
more inclusive subshells.
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
|
|
* changed some report_fails that were called without any preceding
report_try --> report_err
* deploy new check_iface functionality to profile_up and profile_down
and interface_down
* have profile_up/down report_debug the results of check_iface
* the call to interface_down doesn't need to be sandboxed; all the profile
sourcing functions it calls as subroutines do their own sandboxing.
Don't they?
* added missing INTERFACE="$1" to check_iface
* tweaks to bring_interface
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
|
|
1. Change the behavior of check_iface to match that of get_iface_prof (that
is, echo either "external" or the profile name, and return 0=true, or
echo nothing and return 1=false).
2. Then eliminate get_iface_prof.
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
|
|
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
|
|
* add some abortive returns
* some exit tweaks
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
|
|
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
|
|
* added various quotes
* made some vars local
* tweaked some [[ ]]s, including one broken one in netcfg-menu
* s/ra0/$INTERFACE/ in ethernet-iproute and wireless
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
|
|
Added some extra debug points
Directed debug out to stderr, as debug messages were being used as
output from find_essid.
|
|
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
|
|
* profile is sourced again after doing so, so profile-level assignments
can override
* folded validate_profile into load_profile: the extra source command in
load_profile was redundant, so all that load_profile effectively did
was just call validate_profile
|
|
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
|
|
corner cases; others probably make no difference.
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
|
|
|
|
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
|
|
* The point of having both ethernet and ethernet-iproute
was presumably to transition slowly from ifconfig/net-tools to
iproute2. But the current codebase mixes the two in handling
ethernet and wireless connections. This commit separates
all the ip calls to the newer connections, and the ifconfig
calls to the older connections. The latter now call set_interface
with up-old, down-old, forcedown-old.
* I'm not urging that ifconfig code sticks around. Just trying
to make the code consistent with what seems to me to be
its implicit design principles.
* the check for NO-CARRIER in ethernet is now also done without
calling iproute2 tools. I saw this technique recommended somewhere
but have no citation. I don't know how many kernel revisions one
can rely on any given part of /sys to remain stable for.
It may be possible to achieve the same goal here in other ways.
If in fact it's worth the effort to keep the ifconfig code
around.
* Began also to integrate the IPROUTE variable introduced in
ethernet, but stopped. If that's integrated everywhere, shouldn't
it make connection=ethernet equivalent to
connection=ethernet-iproute? Is there justification for
using it at some places but not everywhere? I just let it alone
for now.
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
|
|
* try to factor all the ifconfig/ip set dev code to single location
(currently networks/set_interface, though I recommend a different name
for this function because it's too close in name and different
in functionality from set_iface, set_profile).
* added "forcedown" option to set_interface, meaning "just go down
don't worry about 'nodown' quirks"
* even with "forcedown", this factoring would introduce "ip addr
flush dev $INTERFACE" calls to existing code. I assume that's
harmless? or even beneficial?
* one code block (in ethernet_iproute) had stdout,stderr of the
down calls redirected to /dev/null. I've moved that to
set_interface, so now everyone's getting that behavior. I assume
that's appropriate...
* now no more calls to "ip" or "ifconfig" outside of set_interface,
except the checks for NO-CARRIER after ethernet*/set_interface up.
They might also be moved to network/set_interface?
* as of this commit, all the set_interface calls are now using ip
instead of ifconfig. A subsequent commit will isolate the ip-use
to ethernet-iproute and the ifconfig-use to ethernet.
* ALERT: attend to wireless_down, it seems to be calling
set_interface down twice (once in ethernet_down, once in itself).
And neither this commit nor the code it's patching respects
quirk nodown in the ethernet_down block.
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
|
|
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
|
|
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
|
|
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
|
|
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
|
|
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
|
|
|
|
|
|
|
|
|
|
|
|
|