summaryrefslogtreecommitdiffstats
path: root/src
AgeCommit message (Collapse)AuthorFilesLines
2009-08-15quotes!Jim Pryor11-109/+108
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
2009-08-15Isolate ip to ethernet-iproute, ifconfig to ethernet + wirelessJim Pryor3-16/+27
* The point of having both ethernet and ethernet-iproute was presumably to transition slowly from ifconfig/net-tools to iproute2. But the current codebase mixes the two in handling ethernet and wireless connections. This commit separates all the ip calls to the newer connections, and the ifconfig calls to the older connections. The latter now call set_interface with up-old, down-old, forcedown-old. * I'm not urging that ifconfig code sticks around. Just trying to make the code consistent with what seems to me to be its implicit design principles. * the check for NO-CARRIER in ethernet is now also done without calling iproute2 tools. I saw this technique recommended somewhere but have no citation. I don't know how many kernel revisions one can rely on any given part of /sys to remain stable for. It may be possible to achieve the same goal here in other ways. If in fact it's worth the effort to keep the ifconfig code around. * Began also to integrate the IPROUTE variable introduced in ethernet, but stopped. If that's integrated everywhere, shouldn't it make connection=ethernet equivalent to connection=ethernet-iproute? Is there justification for using it at some places but not everywhere? I just let it alone for now. Signed-off-by: Jim Pryor <profjim@jimpryor.net>
2009-08-15start consolidation of ifconfig/ip/set_interfaceJim Pryor4-20/+42
* try to factor all the ifconfig/ip set dev code to single location (currently networks/set_interface, though I recommend a different name for this function because it's too close in name and different in functionality from set_iface, set_profile). * added "forcedown" option to set_interface, meaning "just go down don't worry about 'nodown' quirks" * even with "forcedown", this factoring would introduce "ip addr flush dev $INTERFACE" calls to existing code. I assume that's harmless? or even beneficial? * one code block (in ethernet_iproute) had stdout,stderr of the down calls redirected to /dev/null. I've moved that to set_interface, so now everyone's getting that behavior. I assume that's appropriate... * now no more calls to "ip" or "ifconfig" outside of set_interface, except the checks for NO-CARRIER after ethernet*/set_interface up. They might also be moved to network/set_interface? * as of this commit, all the set_interface calls are now using ip instead of ifconfig. A subsequent commit will isolate the ip-use to ethernet-iproute and the ifconfig-use to ethernet. * ALERT: attend to wireless_down, it seems to be calling set_interface down twice (once in ethernet_down, once in itself). And neither this commit nor the code it's patching respects quirk nodown in the ethernet_down block. Signed-off-by: Jim Pryor <profjim@jimpryor.net>
2009-08-15Improve suspend/resume, allow for subsets of ifacesJim Pryor1-16/+35
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
2009-08-15improve list_networks, report APs tooJim Pryor1-9/+31
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
2009-08-15Add AP argument to profile, also let ESSID arguments be regexpsJim Pryor2-17/+58
* AP= arguments in profiles take precedence over ESSID= arguments * ESSID= arguments regexps instead of literals. To avoid screwing up any currently working profiles, I restricted the interpretation as a regexp to just the new wireless-dbus connection types. * But a global change involved in implementing this is that the connection up/down calls will be passed a literal ESSID (which of the local networks matches the regexp) as an additional argument. Signed-off-by: Jim Pryor <profjim@jimpryor.net>
2009-08-15silence an error in set_ifaceJim Pryor1-1/+1
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
2009-08-15use STATE_DIR in /usr/bin/netcfgJim Pryor1-4/+4
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
2009-08-15make wep_check more robustJim Pryor1-1/+1
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
2009-08-15Integrate netcfg-menu and net-profilesJim Pryor2-12/+42
* net-profiles will only attempt to control the profiles it was told to; if you manually netcfg a different interface, it will be left alone. (This also helps keep netcfg from stomping on other daemons that might be hooking into it.) Signed-off-by: Jim Pryor <profjim@jimpryor.net>
2009-08-15use subshells as sandboxes, and failing POST_UP/PRE_DOWN abortsJim Pryor1-18/+46
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
2009-08-15Improve listing/iterating over profilesJim Pryor2-19/+27
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
2009-08-15Improve debugging and error-reporting.Jim Pryor3-12/+13
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
2009-08-15grep tweaksJim Pryor5-11/+11
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
2009-08-15More secure temp WPA_CONFIG fileJim Pryor1-15/+13
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
2009-08-15Don't overwrite existing $WEP_OPTSJim Pryor1-5/+7
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
2009-08-15ethernet_up will create resolv.conf also for $DNSJim Pryor1-1/+1
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
2009-08-15Sanitize quotes for wpa_startJim Pryor1-0/+5
Arguments to wpa_start shouldn't be expanded until wpa_start receives them: so should be quoted by all calling functions. I added quotes throughout. In general, it seems wise to quote except when it's absolutely certain not to be needed---or you specifically _do_ want to expand arguments. In this case, it's extra important. Because this might be missed in later code, I also wrangled wpa_start so that it doesn't rely on WPA_OPTS being all in $3. One of these fixes would have sufficed, but what the hell I did both. Signed-off-by: Jim Pryor <profjim@jimpryor.net>
2009-08-15wpa_cli, start/stop_wpa, wpa_check tweaksJim Pryor4-19/+28
* Supply -i switch to wpa_cli * Have wpa_check call stop_wpa on failure, instead of duplicating (only some of) the termination code. * Need brief sleep in termination code. * Note that functions which call wpa_check don't need to call stop_wpa themselves, when wpa_check fails. * Functions which call wpa_check and start_wpa are however responsible for all error reporting on failure. * Add some debugging calls to announce calls to wpa_start/wpa_check Signed-off-by: Jim Pryor <profjim@jimpryor.net>
2009-08-15Everyone use i/o functions from globals/hooksJim Pryor6-21/+10
Signed-off-by: Jim Pryor <profjim@jimpryor.net>
2009-08-15netcfg current and netcfg listJim Pryor1-2/+26
These and "netcfg version" don't require root privileges. Signed-off-by: Jim Pryor <profjim@jimpryor.net>
2009-08-15Add contrib dir and logging hooksJim Pryor2-17/+27
* Add contrib/logging.hook * Update Makefile and manpage * Propose that hooks go into /etc, not /usr---latter should be shareable and possibly read-only, not good spot for user-configurable files like these. * Since we have hooks/arch as part of the package, this commit attempts to load hooks from both /usr/lib/network/hooks and /etc/network.d/hooks. (Executable hooks in /etc take precedence over hooks with same name from /usr.) * Need to load /etc/rc.conf before /etc/rc.d/functions (e.g. for USECOLORS) Signed-off-by: Jim Pryor <profjim@jimpryor.net>
2009-08-10Erase any suspended profiles on a newly connected interfaceJames Rayner1-0/+13
2009-08-10allow interfaces to be marked as externally controlledJames Rayner1-14/+28
2009-08-10add missing globals and 'arch' hookJames Rayner2-0/+131
2009-08-10merge changes since revertJames Rayner7-90/+301
2009-08-10Add interface setting, a debug mode and interface setting hooksJames Rayner5-15/+25
2009-08-10merge improved find_ap/find_essidJames Rayner2-14/+55
2009-08-10merge logging code from Jim PryorJames Rayner7-78/+115
2009-08-10Add wireless+iproute support, extend wait for some slower cardsJames Rayner3-6/+10
2009-08-10Added basic rfkill support; prototype connection query supportJames Rayner3-1/+58
2009-08-10revert pryor patchJames Rayner12-1384/+405
2009-08-07rename wireless fileJames Rayner1-0/+141
2009-08-07rename wireless fileJames Rayner1-141/+0
2009-08-07Patch from Jim PryorJames Rayner12-436/+1353
2009-06-27netcfg v2.2.1James Rayner1-1/+1
2009-06-27fix taking all profiles downJames Rayner1-1/+1
2009-06-27netcfg v2.2.0James Rayner1-1/+1
2009-06-27Workaround for FS#15072James Rayner1-1/+1
2009-06-06netcfg v2.2.0 beta 3James Rayner1-1/+1
2009-06-06Another attempt at a working link check, FS#13334James Rayner2-21/+10
2009-06-01netcfg v2.2.0 beta 2James Rayner1-1/+1
2009-05-19Fix FS#14761 and handle if no profiles are activeJames Rayner1-18/+19
2009-05-19typo (fix #14761)Andrea Scarpino1-2/+2
2009-05-19fix #14761 (again)Andrea Scarpino1-3/+3
2009-05-19fix #14761Andrea Scarpino1-15/+13
2009-05-18fixed typo by Robson Roberto Souza PeixotoAndrea Scarpino1-1/+1
2009-05-18netcfg v2.2.0 beta 1 (again)James Rayner1-1/+1
2009-05-18wireless: check if iface is real, stop wpa_supplicant on failuresJames Rayner2-8/+30
2009-05-12cosmetic fix to help message outputJames Rayner1-1/+1