From 9e316d0a306f8ed2a9b46f76b04806e0a5b1760a Mon Sep 17 00:00:00 2001 From: Jim Pryor Date: Sat, 28 Nov 2009 20:47:12 -0500 Subject: netcfg.action: add quotes Quotes aren't needed inside [[ ]] because that construction doesn't do word expansion. But I think (partly from my own urging) this is the style used throughout the rest of the code. And we should have the quotes in lines like: netcfg "$profile". Signed-off-by: Jim Pryor --- ifplugd/netcfg.action | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/ifplugd/netcfg.action b/ifplugd/netcfg.action index 34796df..bb02151 100755 --- a/ifplugd/netcfg.action +++ b/ifplugd/netcfg.action @@ -14,26 +14,26 @@ case "$2" in # it's difficult to tell if static succeeded # Also check profile is same iface and is right connection for profile in $(list_profiles); do ( - load_profile $profile - [[ $INTERFACE != $1 ]] && continue - [[ $CONNECTION != @(ethernet|ethernet-iproute) ]] && continue - if [[ $IP == "dhcp" ]]; then - netcfg $profile && exit 0 + load_profile "$profile" + [[ "$INTERFACE" != "$1" ]] && continue + [[ "$CONNECTION" != @(ethernet|ethernet-iproute) ]] && continue + if [[ "$IP" == "dhcp" ]]; then + netcfg "$profile" && exit 0 fi ) done for profile in $(list profiles}; do ( - load_profile $profile - [[ $INTERFACE != $1 ]] && continue - [[ $CONNECTION != @(ethernet|ethernet-iproute) ]] && continue - if [[ $IP == "static" ]]; then - netcfg $profile && exit 0 + load_profile "$profile" + [[ "$INTERFACE" != "$1" ]] && continue + [[ "$CONNECTION" != @(ethernet|ethernet-iproute) ]] && continue + if [[ "$IP" == "static" ]]; then + netcfg "$profile" && exit 0 fi ) done exit 1 ;; down) - if check_iface $1; then - netcfg -i $1 + if check_iface "$1"; then + netcfg -i "$1" fi ;; *) -- cgit v1.2.3-24-g4f1b