summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorXavier Chantry <shiningxc@gmail.com>2009-03-03 17:10:26 +0100
committerXavier Chantry <shiningxc@gmail.com>2009-03-15 18:10:24 +0100
commit91d43ba4b44e0827c6d9b66c70485672953f5a6d (patch)
treee95cdf13467cabf8da2ef81a4a0b202ecf8c4985
parent59b4725bbb881140fea47dd2d1b09cef37e8a9dc (diff)
downloadpacman-91d43ba4b44e0827c6d9b66c70485672953f5a6d.tar.gz
pacman-91d43ba4b44e0827c6d9b66c70485672953f5a6d.tar.xz
repo-add : don't change the modification time on depends and desc
The modification time on depends and desc file were changed to match the modification time of the package file. I don't see why and we are actualling losing information here. If we want to know the date of the package file, we can just look inside the depends file. If we want to know when the entry was created, we should not alter the modification time of depends and desc. Besides, this had the non-obvious and undocumented side effect that the depends file was always created, even if it was empty. And pacman actually does require that. So I added a "touch depends" to always create the file. Signed-off-by: Xavier Chantry <shiningxc@gmail.com>
-rw-r--r--scripts/repo-add.sh.in7
1 files changed, 2 insertions, 5 deletions
diff --git a/scripts/repo-add.sh.in b/scripts/repo-add.sh.in
index a760d1b1..186d9fb8 100644
--- a/scripts/repo-add.sh.in
+++ b/scripts/repo-add.sh.in
@@ -262,6 +262,8 @@ db_write_entry()
# create depends entry
msg2 "$(gettext "Creating 'depends' db entry...")"
+ # create the file even if it will remain empty
+ touch "depends"
write_list_entry "DEPENDS" "$_depends" "depends"
write_list_entry "CONFLICTS" "$_conflicts" "depends"
write_list_entry "PROVIDES" "$_provides" "depends"
@@ -269,11 +271,6 @@ db_write_entry()
cd "$startdir"
- # preserve the modification time
- # Xav : what for?
- pkgdir="$gstmpdir/$pkgname-$pkgver"
- touch -r "$pkgfile" "$pkgdir/desc" "$pkgdir/depends"
-
return 0
} # end db_write_entry