summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan McGee <dan@archlinux.org>2011-09-12 16:55:47 +0200
committerDan McGee <dan@archlinux.org>2011-09-15 00:18:07 +0200
commita2356d5ae3cdc6ac28ed614e0e5e7e75174728e9 (patch)
treee8cd1a51009b782e5b57eaaf50774515ae2bc45f
parent4a02350ded318bdc1da5421551784ab2a10dd96b (diff)
downloadpacman-a2356d5ae3cdc6ac28ed614e0e5e7e75174728e9.tar.gz
pacman-a2356d5ae3cdc6ac28ed614e0e5e7e75174728e9.tar.xz
Don't duplicate header strings
There is no need to print them into buffers; we can use the values returned by gettext() directly without issue. Signed-off-by: Dan McGee <dan@archlinux.org>
-rw-r--r--src/pacman/util.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/src/pacman/util.c b/src/pacman/util.c
index 594186f6..9e390b2d 100644
--- a/src/pacman/util.c
+++ b/src/pacman/util.c
@@ -740,15 +740,15 @@ static alpm_list_t *create_verbose_header(int install)
alpm_list_t *res = NULL;
char *str;
- pm_asprintf(&str, "%s", _("Name"));
+ str = _("Name");
res = alpm_list_add(res, str);
- pm_asprintf(&str, "%s", _("Old Version"));
+ str = _("Old Version");
res = alpm_list_add(res, str);
if(install) {
- pm_asprintf(&str, "%s", _("New Version"));
+ str = _("New Version");
res = alpm_list_add(res, str);
}
- pm_asprintf(&str, "%s", _("Size"));
+ str = _("Size");
res = alpm_list_add(res, str);
return res;
@@ -867,7 +867,7 @@ out:
FREELIST(lp);
}
alpm_list_free(targets);
- FREELIST(header);
+ alpm_list_free(header);
} else {
FREELIST(targets);
}