summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAllan McRae <allan@archlinux.org>2014-11-17 15:47:19 +0100
committerAllan McRae <allan@archlinux.org>2014-11-18 02:58:26 +0100
commit5d11605958dd9d07f902287468104a996b3bddcc (patch)
treeda254ea8a96059b30064d14fe528a244ff3e2009
parent5d618438c4831af92e82251051a128e8591fef59 (diff)
downloadpacman-5d11605958dd9d07f902287468104a996b3bddcc.tar.gz
pacman-5d11605958dd9d07f902287468104a996b3bddcc.tar.xz
extract_single_file: fix memory leak in error condition
The memory assigned to checkfile was leaked in the error condition. Signed-off-by: Allan McRae <allan@archlinux.org>
-rw-r--r--lib/libalpm/add.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/libalpm/add.c b/lib/libalpm/add.c
index 1d491fa5..725f2b5c 100644
--- a/lib/libalpm/add.c
+++ b/lib/libalpm/add.c
@@ -317,7 +317,7 @@ static int extract_single_file(alpm_handle_t *handle, struct archive *archive,
if(!backup->name || strcmp(backup->name, entryname_orig) != 0) {
continue;
}
- STRDUP(newhash, hash_pkg, RET_ERR(handle, ALPM_ERR_MEMORY, -1));
+ STRDUP(newhash, hash_pkg, errors++; handle->pm_errno = ALPM_ERR_MEMORY; goto needbackup_cleanup);
FREE(backup->hash);
backup->hash = newhash;
}