diff options
| author | Dan McGee <dan@archlinux.org> | 2012-04-25 03:59:24 +0200 |
|---|---|---|
| committer | Dan McGee <dan@archlinux.org> | 2012-04-25 03:59:24 +0200 |
| commit | 20ff0cd40fd228f56251634a7429439244c24eac (patch) | |
| tree | 81fada55c28ec86b3515dd7ae9d65a3afa809f76 | |
| parent | 1583a2079c8e84c9cd960a596dae2e36c9077bbb (diff) | |
| download | pacman-20ff0cd40fd228f56251634a7429439244c24eac.tar.gz pacman-20ff0cd40fd228f56251634a7429439244c24eac.tar.xz | |
util/testdb: don't return crazy error values
With some contrived examples, you could easily make testdb return a very
high error count, which could easily overflow the 8-bit unsigned integer
limit. Instead, simply return 1 or 0 based on whether errors were found.
Signed-off-by: Dan McGee <dan@archlinux.org>
| -rw-r--r-- | src/util/testdb.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/util/testdb.c b/src/util/testdb.c index f3a7b659..2017b60f 100644 --- a/src/util/testdb.c +++ b/src/util/testdb.c @@ -253,7 +253,7 @@ static void usage(void) int main(int argc, char *argv[]) { - int ret = 0; + int errors = 0; alpm_errno_t err; const char *dbpath = DBPATH; int a = 1; @@ -285,13 +285,13 @@ int main(int argc, char *argv[]) alpm_option_set_logcb(handle, output_cb); if(!dbnames) { - ret = check_localdb(); + errors = check_localdb(); } else { - ret = check_syncdbs(dbnames); + errors = check_syncdbs(dbnames); alpm_list_free(dbnames); } - cleanup(ret); + cleanup(errors > 0); } /* vim: set ts=2 sw=2 noet: */ |