diff options
| author | Emil Velikov <emil.l.velikov@gmail.com> | 2021-01-05 01:48:12 +0100 |
|---|---|---|
| committer | Allan McRae <allan@archlinux.org> | 2021-01-08 15:14:42 +0100 |
| commit | 67a42b9549b3d0bc5a6c1f774e965553b304c1cf (patch) | |
| tree | 353d5877f5e2491ebda6f5864d08580fadf35a5b | |
| parent | d53ba019f5dfee00fd66491c1fa1ac8978fd628d (diff) | |
| download | pacman-67a42b9549b3d0bc5a6c1f774e965553b304c1cf.tar.gz pacman-67a42b9549b3d0bc5a6c1f774e965553b304c1cf.tar.xz | |
meson: use hidden symbol visiblity by default
All the required public API is annotated with SYMEXPORT, so we can just
add the meson notation, to hide all the symbols by default.
Thus we no longer spill all the internal API into the global namespace.
This is effectively a regression from the autotools build, which used
hidden and internal for DARWIN and others respectively.
The use of hidden is considered sufficient, considering:
- internal was introduced with commit 920b0d20 ("Update usage of gcc
__attribute__ flags"), referencing the GCC manual and potential
optimisations, although
- the details about the optimisations or respective benefits are close
to non-existent,
- the code/data size of the binaries is identical across hidden and
internal. While the latter produces slightly larger overall binaries.
- Internal is not widely supported - missing on Darwin, the CMake build
system lacks a wrapper (unlike for hidden)
- Internal is not widely used in projects.
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Signed-off-by: Allan McRae <allan@archlinux.org>
| -rw-r--r-- | meson.build | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/meson.build b/meson.build index 71a3b54e..ea9bd2f7 100644 --- a/meson.build +++ b/meson.build @@ -303,6 +303,7 @@ libcommon = static_library( 'common', libcommon_sources, include_directories : includes, + gnu_symbol_visibility : 'hidden', install : false) alpm_deps = [crypto_provider, libarchive, libcurl, libintl, gpgme] @@ -313,6 +314,7 @@ libalpm_a = static_library( # https://github.com/mesonbuild/meson/issues/3937 objects : libcommon.extract_all_objects(), include_directories : includes, + gnu_symbol_visibility : 'hidden', dependencies : alpm_deps) libalpm = library( |