diff options
| author | Allan McRae <allan@archlinux.org> | 2010-06-19 10:55:08 +0200 |
|---|---|---|
| committer | Allan McRae <allan@archlinux.org> | 2010-06-20 17:04:58 +0200 |
| commit | 59c47aaf529df02ec1577fe727c3c84d13592666 (patch) | |
| tree | 63049bcc89e7058376ce0607ddee116b2f819ddc /lib/libalpm/deps.c | |
| parent | d7dccd541962f0dd8bf323ae11633e595bfb4922 (diff) | |
| download | pacman-59c47aaf529df02ec1577fe727c3c84d13592666.tar.gz pacman-59c47aaf529df02ec1577fe727c3c84d13592666.tar.xz | |
Clarify testing within conditional statements
Follow the HACKING guidelines and always use != 0 or == 0 rather
than negation within conditional statements to improve clarity.
Most of these are !strcmp usages which is the example of what not
to do in the HACKING document.
Signed-off-by: Allan McRae <allan@archlinux.org>
Diffstat (limited to 'lib/libalpm/deps.c')
| -rw-r--r-- | lib/libalpm/deps.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/libalpm/deps.c b/lib/libalpm/deps.c index 26f9b16d..fd893a63 100644 --- a/lib/libalpm/deps.c +++ b/lib/libalpm/deps.c @@ -546,7 +546,7 @@ pmpkg_t *_alpm_resolvedep(pmdepend_t *dep, alpm_list_t *dbs, for(i = dbs; i; i = i->next) { for(j = _alpm_db_get_pkgcache(i->data); j; j = j->next) { pmpkg_t *pkg = j->data; - if(alpm_depcmp(pkg, dep) && strcmp(pkg->name, dep->name) && + if(alpm_depcmp(pkg, dep) && strcmp(pkg->name, dep->name) != 0 && !_alpm_pkg_find(excluding, pkg->name)) { if(_alpm_pkg_should_ignore(pkg)) { int install = 0; |