diff options
| author | Nagy Gabor <ngaba@petra.hos.u-szeged.hu> | 2007-07-16 20:58:58 +0200 |
|---|---|---|
| committer | Dan McGee <dan@archlinux.org> | 2007-08-20 21:23:53 +0200 |
| commit | b1808930ce45a034981626fc20bbc7920890899e (patch) | |
| tree | 7bdcb9fe684c0a9f508abe4503cc93c8ae31b2b5 /lib/libalpm/package.c | |
| parent | 17d9122e01f5a675f4c7882e68ceae65aae7b5aa (diff) | |
| download | pacman-b1808930ce45a034981626fc20bbc7920890899e.tar.gz pacman-b1808930ce45a034981626fc20bbc7920890899e.tar.xz | |
libalpm/add.c,trans.c : cleanup of requiredby handling.
This patch cleans up and fix the _alpm_trans_update_depends function
and ensure that all requiredby fields are filled in case of multiple satisfiers
(previously, the handling of mutliple satisfiers in that function was inconsistent).
This makes a special case handling of requiredby in commit_single_pkg() obsolete,
and so allows cleaning that code as well.
Also fixed upgrade056 pactest because :
1) the requiredby fields were wrong, and this wouldn't happen with the fixed _alpm_trans_update_depends().
2) this is a very unusual case anyway (and handling all corner cases combined to a broken database
seems nearly impossible to achieve).
References :
http://www.archlinux.org/pipermail/pacman-dev/2007-July/008919.html
http://www.archlinux.org/pipermail/pacman-dev/2007-July/008920.html
Signed-off-by: Chantry Xavier <shiningxc@gmail.com>
Diffstat (limited to 'lib/libalpm/package.c')
| -rw-r--r-- | lib/libalpm/package.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/lib/libalpm/package.c b/lib/libalpm/package.c index e11d7476..135a3510 100644 --- a/lib/libalpm/package.c +++ b/lib/libalpm/package.c @@ -1109,6 +1109,9 @@ int _alpm_pkg_splitname(const char *target, char *name, char *version, int witha /* scan the local db to fill in requiredby field of package, * used when we want to install or add a package */ + +/* A depends on B through n depends <=> A listed in B's requiredby n times + * n == 0 or 1 in almost all cases */ void _alpm_pkg_update_requiredby(pmpkg_t *pkg) { const alpm_list_t *i, *j; |