Deal with unused function parameters correctly

This started off removing the "(void)foo" hacks to work around
unused function parameters and ended up fixing every warning
generated by -Wunused-parameter.

Dan: rename to UNUSED.

Signed-off-by: Allan McRae <allan@archlinux.org>
Signed-off-by: Dan McGee <dan@archlinux.org>

1 files changed, 16 insertions, 3 deletions

diff --git a/lib/libalpm/package.c b/lib/libalpm/package.c
index 393dae00..7b93c181 100644
--- a/lib/libalpm/package.c
+++ b/lib/libalpm/package.c
@@ -111,9 +111,22 @@ static alpm_list_t *_pkg_get_deltas(pmpkg_t *pkg)     { return pkg->deltas; }
 static alpm_list_t *_pkg_get_files(pmpkg_t *pkg)      { return pkg->files; }
 static alpm_list_t *_pkg_get_backup(pmpkg_t *pkg)     { return pkg->backup; }
 
-static void *_pkg_changelog_open(pmpkg_t *pkg)        { return NULL; }
-static size_t _pkg_changelog_read(void *ptr, size_t size, const pmpkg_t *pkg, const void *fp) { return 0; }
-static int _pkg_changelog_close(const pmpkg_t *pkg, void *fp) { return EOF; }
+static void *_pkg_changelog_open(pmpkg_t UNUSED *pkg)
+{
+	return NULL;
+}
+
+static size_t _pkg_changelog_read(void UNUSED *ptr, size_t UNUSEDsize,
+		const pmpkg_t UNUSED *pkg, const UNUSED void *fp)
+{
+	return 0;
+}
+
+static int _pkg_changelog_close(const pmpkg_t UNUSED *pkg,
+		void UNUSED *fp)
+{
+	return EOF;
+}
 
 /** The standard package operations struct. Get fields directly from the
  * struct itself with no abstraction layer or any type of lazy loading.