diff options
| author | Nagy Gabor <ngaba@bibl.u-szeged.hu> | 2008-08-24 23:24:53 +0200 |
|---|---|---|
| committer | Dan McGee <dan@archlinux.org> | 2009-01-13 05:44:00 +0100 |
| commit | a888f377a5c805f1da24b556e6a4a9e3678d8eb3 (patch) | |
| tree | 70ffd810a0b240429d2dfaa0d7266e228b6212f2 /lib/libalpm/remove.c | |
| parent | 8017b0bb8ec5364f8a3999caffc6b3c3ea991810 (diff) | |
| download | pacman-a888f377a5c805f1da24b556e6a4a9e3678d8eb3.tar.gz pacman-a888f377a5c805f1da24b556e6a4a9e3678d8eb3.tar.xz | |
HoldPkg rework
The HoldPkg feature is even more important when the packages to be held are
pulled automatically by pacman, in a -Rc and -Rs operation. Before, it only
applied when the packages were explicitly requested by the user to be
removed. This patch extends holdpkg to -Rc and -Rs by doing the HoldPkg
check just before trans_commit.
Additionally, the whole HoldPkg stuff was moved to the front-end.
I changed the default behavior to "don't remove", so I modified remove030.py
pactest as well.
See also: FS#9173.
Original-work-by: Xavier Chantry <shiningxc@gmail.com>
Signed-off-by: Nagy Gabor <ngaba@bibl.u-szeged.hu>
Signed-off-by: Dan McGee <dan@archlinux.org>
Diffstat (limited to 'lib/libalpm/remove.c')
| -rw-r--r-- | lib/libalpm/remove.c | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/lib/libalpm/remove.c b/lib/libalpm/remove.c index 76bb5525..9dfff9c3 100644 --- a/lib/libalpm/remove.c +++ b/lib/libalpm/remove.c @@ -65,16 +65,6 @@ int _alpm_remove_loadtarget(pmtrans_t *trans, pmdb_t *db, char *name) RET_ERR(PM_ERR_PKG_NOT_FOUND, -1); } - /* ignore holdpkgs on upgrade */ - if((trans == handle->trans) - && alpm_list_find_str(handle->holdpkg, info->name)) { - int resp = 0; - QUESTION(trans, PM_TRANS_CONV_REMOVE_HOLDPKG, info, NULL, NULL, &resp); - if(!resp) { - RET_ERR(PM_ERR_PKG_HOLD, -1); - } - } - _alpm_log(PM_LOG_DEBUG, "adding %s in the targets list\n", info->name); trans->packages = alpm_list_add(trans->packages, _alpm_pkg_dup(info)); |