diff options
author | Dan McGee <dan@archlinux.org> | 2011-03-21 01:45:57 +0100 |
---|---|---|
committer | Dan McGee <dan@archlinux.org> | 2011-03-21 01:49:45 +0100 |
commit | 0303b26b1ed6d060e65ec7dbae5db50fc14836ff (patch) | |
tree | 902e26197511ee42a9562bc6b71ae77c20f3c86d /lib/libalpm/util.h | |
parent | 0cf05c77ad86b5c1895e94284b571afba5feebe8 (diff) | |
download | pacman-0303b26b1ed6d060e65ec7dbae5db50fc14836ff.tar.gz pacman-0303b26b1ed6d060e65ec7dbae5db50fc14836ff.tar.xz |
Style change: return(x) --> return x
This was discussed and more or less agreed upon on the mailing list. A
huge checkin, but if we just do it and let people adjust the pain will
end soon enough. Rebasing should be relatively straighforward for anyone
that sees conflicts; just be sure you use the new return style if
possible.
The following semantic patch was used to do the change, along with some
hand-massaging in order to preserve parenthesis where appropriate:
The semantic match that finds this problem is as follows, although some
hand-massaging was done in order to keep parenthesis where appropriate:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression a;
@@
- return(a);
+ return a;
// </smpl>
A macros_file was also provided with the following content:
Additional steps taken, mainly for ASSERT() macros:
$ sed -i -e 's#return(NULL)#return NULL#' lib/libalpm/*.c
$ sed -i -e 's#return(-1)#return -1#' lib/libalpm/*.c
Signed-off-by: Dan McGee <dan@archlinux.org>
Diffstat (limited to 'lib/libalpm/util.h')
-rw-r--r-- | lib/libalpm/util.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/libalpm/util.h b/lib/libalpm/util.h index 3232f004..9f0344fe 100644 --- a/lib/libalpm/util.h +++ b/lib/libalpm/util.h @@ -59,7 +59,7 @@ #define RET_ERR(err, ret) do { pm_errno = (err); \ _alpm_log(PM_LOG_DEBUG, "returning error %d from %s : %s\n", err, __func__, alpm_strerrorlast()); \ - return(ret); } while(0) + return (ret); } while(0) /** * Used as a buffer/state holder for _alpm_archive_fgets(). |