diff options
| author | Nagy Gabor <ngaba@bibl.u-szeged.hu> | 2008-03-10 15:38:08 +0100 |
|---|---|---|
| committer | Dan McGee <dan@archlinux.org> | 2008-03-11 00:57:36 +0100 |
| commit | d060e31be3586ce27382f80eaed7a9edf2c86aeb (patch) | |
| tree | 2e7ded6300e22445e539a8ea913a9f296e0739eb /pactest | |
| parent | f56f7ff39102dab754573b0bc40dbceb5a8ec301 (diff) | |
| download | pacman-d060e31be3586ce27382f80eaed7a9edf2c86aeb.tar.gz pacman-d060e31be3586ce27382f80eaed7a9edf2c86aeb.tar.xz | |
Remove trans->targets
Its implementation was quite broken:
* add_loadtarget() might have silently filtered out some targets when
replacing an older version.
* This was used in sync.c to determine whether a target is implicit or not,
which is incorrect behavior. Before this patch we silently removed user
confirmed replacements; now we always warn on a replacement.
* remove001.py behavior was quite odd in adding same target 5 times to the
target list, we can change this behavior to be a failure.
Signed-off-by: Nagy Gabor <ngaba@bibl.u-szeged.hu>
[Xav: changed remove001 pactest accordingly]
Signed-off-by: Chantry Xavier <shiningxc@gmail.com>
[Dan: rewrote commit message]
Signed-off-by: Dan McGee <dan@archlinux.org>
Diffstat (limited to 'pactest')
| -rw-r--r-- | pactest/tests/remove001.py | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/pactest/tests/remove001.py b/pactest/tests/remove001.py index 809bfdb7..d20dd079 100644 --- a/pactest/tests/remove001.py +++ b/pactest/tests/remove001.py @@ -1,4 +1,3 @@ -# If someone else can come up with a better name, please do so self.description = "Remove a package listed 5 times" p = pmpkg("foo") @@ -6,5 +5,5 @@ self.addpkg2db("local", p) self.args = "-R " + "foo "*5 -self.addrule("PACMAN_RETCODE=0") -self.addrule("!PKG_EXISTS=foo") +self.addrule("PACMAN_RETCODE=1") +self.addrule("PKG_EXISTS=foo") |