diff options
| author | Eli Schwartz <eschwartz@archlinux.org> | 2018-05-02 20:24:44 +0200 |
|---|---|---|
| committer | Allan McRae <allan@archlinux.org> | 2018-05-12 13:11:52 +0200 |
| commit | 542c3cf812e32989610cb09f40dbc237f2fba9bb (patch) | |
| tree | 16e7eb0b36d8d61dc93a3fe6cd0aaa5e888e0940 /scripts/libmakepkg/lint_pkgbuild | |
| parent | 2c94118dc168f16231e38a84c0b569b5b0006fd9 (diff) | |
| download | pacman-542c3cf812e32989610cb09f40dbc237f2fba9bb.tar.gz pacman-542c3cf812e32989610cb09f40dbc237f2fba9bb.tar.xz | |
libmakepkg: only save the shellopts we need
micro-optimization: We only care about temporarily enforcing extglob, so
that is the only one we need to explicitly restore.
Signed-off-by: Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by: Allan McRae <allan@archlinux.org>
Diffstat (limited to 'scripts/libmakepkg/lint_pkgbuild')
4 files changed, 8 insertions, 8 deletions
diff --git a/scripts/libmakepkg/lint_pkgbuild/checkdepends.sh.in b/scripts/libmakepkg/lint_pkgbuild/checkdepends.sh.in index fb289a67..d5648bd4 100644 --- a/scripts/libmakepkg/lint_pkgbuild/checkdepends.sh.in +++ b/scripts/libmakepkg/lint_pkgbuild/checkdepends.sh.in @@ -37,8 +37,8 @@ lint_checkdepends() { get_pkgbuild_all_split_attributes checkdepends checkdepends_list - # save our shell options and turn on extglob - local shellopts=$(shopt -p) + # this function requires extglob - save current status to restore later + local shellopts=$(shopt -p extglob) shopt -s extglob for checkdepend in "${checkdepends_list[@]}"; do diff --git a/scripts/libmakepkg/lint_pkgbuild/conflicts.sh.in b/scripts/libmakepkg/lint_pkgbuild/conflicts.sh.in index 8abad0b0..a18c25fa 100644 --- a/scripts/libmakepkg/lint_pkgbuild/conflicts.sh.in +++ b/scripts/libmakepkg/lint_pkgbuild/conflicts.sh.in @@ -37,8 +37,8 @@ lint_conflicts() { get_pkgbuild_all_split_attributes conflicts conflicts_list - # save our shell options and turn on extglob - local shellopts=$(shopt -p) + # this function requires extglob - save current status to restore later + local shellopts=$(shopt -p extglob) shopt -s extglob for conflict in "${conflicts_list[@]}"; do diff --git a/scripts/libmakepkg/lint_pkgbuild/depends.sh.in b/scripts/libmakepkg/lint_pkgbuild/depends.sh.in index d90a15f8..40cdc65a 100644 --- a/scripts/libmakepkg/lint_pkgbuild/depends.sh.in +++ b/scripts/libmakepkg/lint_pkgbuild/depends.sh.in @@ -37,8 +37,8 @@ lint_depends() { get_pkgbuild_all_split_attributes depends depends_list - # save our shell options and turn on extglob - local shellopts=$(shopt -p) + # this function requires extglob - save current status to restore later + local shellopts=$(shopt -p extglob) shopt -s extglob for depend in "${depends_list[@]}"; do diff --git a/scripts/libmakepkg/lint_pkgbuild/makedepends.sh.in b/scripts/libmakepkg/lint_pkgbuild/makedepends.sh.in index 55ca4e28..4cc4ab5d 100644 --- a/scripts/libmakepkg/lint_pkgbuild/makedepends.sh.in +++ b/scripts/libmakepkg/lint_pkgbuild/makedepends.sh.in @@ -37,8 +37,8 @@ lint_makedepends() { get_pkgbuild_all_split_attributes makedepends makedepends_list - # save our shell options and turn on extglob - local shellopts=$(shopt -p) + # this function requires extglob - save current status to restore later + local shellopts=$(shopt -p extglob) shopt -s extglob for makedepend in "${makedepends_list[@]}"; do |